trentlarson
  • Joined on Nov 17, 2022
Repositories Public Activity Starred Repositories Following Followers
Loading Heatmap…

trentlarson commented on pull request trent_larson/crowd-funder-for-time-pwa#188

Reboot of the ActiveDID migration

Looks good to me.

1 day ago

trentlarson pushed to active_did_redux at trent_larson/crowd-funder-for-time-pwa

  • a1e2d635f7 chore: switch more debug logging to debug

1 day ago

trentlarson pushed to active_did_redux at trent_larson/crowd-funder-for-time-pwa

  • f371ce88a0 chore: remove extra code & logging & error messages, fix quick-start documentation

1 day ago

trentlarson pushed to star-projects at trent_larson/crowd-funder-for-time-pwa

  • 855448d07a feat: add a page to see all the starred projects

5 days ago

trentlarson pushed to active_did_redux at trent_larson/crowd-funder-for-time-pwa

  • 626071281f feat: make the default 'create identifier' be from a new seed

6 days ago

trentlarson pushed to active_did_redux at trent_larson/crowd-funder-for-time-pwa

  • 69c922284e fix: remove the 'migrations' table creation that is done elsewhere

6 days ago

trentlarson pushed to master-patch at trent_larson/crowd-funder-for-time-pwa

  • 6482cfa6a3 fix: fix the claim-add-raw view to work with axios

1 week ago

trentlarson pushed to master at trent_larson/crowd-funder-for-time-pwa

  • b138441d10 chore: change logging level to debug for debug messages

1 week ago

trentlarson pushed to active_did_redux at trent_larson/crowd-funder-for-time-pwa

  • c9cfeafd50 fix: change non-existent 'mirror' icon to 'circle-user'

1 week ago

trentlarson pushed to active_did_redux at trent_larson/crowd-funder-for-time-pwa

  • 52b1e8ffa3 chore: move more logger infos to debugs

1 week ago

trentlarson commented on pull request trent_larson/crowd-funder-for-time-pwa#188

Reboot of the ActiveDID migration

(Unfortunately the lines have changed, but I assume this is all about the $needsActiveIdentitySelection method.) I don't see where this is used now. Maybe the usages have been removed, in which…

2 weeks ago

trentlarson commented on pull request trent_larson/crowd-funder-for-time-pwa#188

Reboot of the ActiveDID migration

If this is necessary then it appears that something is wrong with the ".env.development" environment loading on line 9. Is there something deeper to fix here? (I ask because it's the addition of more environment logic, where it would be preferable to keep these forced settings isolated for maintainability.)

2 weeks ago

trentlarson commented on pull request trent_larson/crowd-funder-for-time-pwa#188

Reboot of the ActiveDID migration

If these timeout, do the tests fail? (I hope so. The Playwright docs don't make it obvious.)

2 weeks ago

trentlarson commented on pull request trent_larson/crowd-funder-for-time-pwa#188

Reboot of the ActiveDID migration

More logging that seems like they should be "debug" statements.

2 weeks ago

trentlarson commented on pull request trent_larson/crowd-funder-for-time-pwa#188

Reboot of the ActiveDID migration

These voids seem unnecessary. Educate me if I'm wrong.

2 weeks ago

trentlarson commented on pull request trent_larson/crowd-funder-for-time-pwa#188

Reboot of the ActiveDID migration

I'm still not sure that these checks are necessary but I won't let that hold up things since I don't see how it can hurt. But: instead of erasing the activeDid, I suggest we keep the value and create a blank entry for it in the settings table.

2 weeks ago