trent_larson/crowd-funder-for-time-pwa
4
1
Fork 2
Code Issues Pull Requests 22 Releases 5 Wiki Activity

refactor(ui): remove unused image cache system and fix TypeScript compilation #164

Open
anomalist wants to merge 0 commits from remove-image-cache into master
pull from: remove-image-cache
merge into: trent_larson:master
Conversation 1 Commits - Files Changed -
anomalist commented 2025-08-12 08:45:05 +00:00
Owner
Copy Link
  • Remove imageCache Map that only stored null values
  • Remove selectedImageData Blob property (never used)
  • Remove cacheImageData method and related function props
  • Remove handleImageLoad method from ActivityListItem
  • Clean up ImageViewer component props
  • Fix TypeScript compilation by replacing legacy logConsoleAndDb calls
  • Replace logConsoleAndDb with logger.error in deepLinks service
  • Images continue to work via direct URL references

The image cache system was non-functional and only stored null values.
ImageViewer component ignored blob data and only used URLs.
Fixed production build failure caused by undefined logConsoleAndDb function.
Removing dead code improves maintainability without affecting functionality.

- Remove imageCache Map that only stored null values - Remove selectedImageData Blob property (never used) - Remove cacheImageData method and related function props - Remove handleImageLoad method from ActivityListItem - Clean up ImageViewer component props - Fix TypeScript compilation by replacing legacy logConsoleAndDb calls - Replace logConsoleAndDb with logger.error in deepLinks service - Images continue to work via direct URL references The image cache system was non-functional and only stored null values. ImageViewer component ignored blob data and only used URLs. Fixed production build failure caused by undefined logConsoleAndDb function. Removing dead code improves maintainability without affecting functionality.
👍 1
anomalist added 1 commit 2025-08-12 08:45:05 +00:00
refactor(ui): remove unused image cache system and fix TypeScript compilation bb357f294a 
- Remove imageCache Map that only stored null values
- Remove selectedImageData Blob property (never used)
- Remove cacheImageData method and related function props
- Remove handleImageLoad method from ActivityListItem
- Clean up ImageViewer component props
- Fix TypeScript compilation by replacing legacy logConsoleAndDb calls
- Replace logConsoleAndDb with logger.error in deepLinks service
- Images continue to work via direct URL references

The image cache system was non-functional and only stored null values.
ImageViewer component ignored blob data and only used URLs.
Fixed production build failure caused by undefined logConsoleAndDb function.
Removing dead code improves maintainability without affecting functionality.
trentlarson commented 2025-08-13 02:02:26 +00:00
Owner
Copy Link

I approve this!

I approve this!
anomalist added 1 commit 2025-08-14 05:24:45 +00:00
Merge branch 'master' into remove-image-cache a3b69fc0d4
This branch is already included in the target branch. There is nothing to merge.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin remove-image-cache:remove-image-cache
git checkout remove-image-cache
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
anomalist jose jsnbuchanan kentbull trentlarson
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: trent_larson/crowd-funder-for-time-pwa#164
Delete Branch "remove-image-cache"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?