trent_larson/crowd-funder-for-time-pwa
4
1
Fork 2
Code Issues Pull Requests 22 Releases 5 Wiki Activity

fix(home): resolve nearby filter not refreshing feed view #162

Open
anomalist wants to merge 0 commits from nearby-filter into master
pull from: nearby-filter
merge into: trent_larson:master
Conversation 4 Commits - Files Changed -
anomalist commented 2025-08-12 06:56:07 +00:00
Owner
Copy Link
  • Fix FeedFilters component missing activeDid context for settings updates
  • Update reloadFeedOnChange to retrieve actual settings without defaults
  • Add comprehensive logging throughout feed refresh process for debugging
  • Ensure filter state changes immediately trigger feed refresh without page reload

The issue was caused by FeedFilters component calling $updateSettings() without
the activeDid parameter, causing settings to be saved to wrong location. Now
properly passes activeDid from HomeView and uses $accountSettings() for
accurate user-specific settings retrieval.

Closes filter refresh issue where turning ON nearby filter required page reload

- Fix FeedFilters component missing activeDid context for settings updates - Update reloadFeedOnChange to retrieve actual settings without defaults - Add comprehensive logging throughout feed refresh process for debugging - Ensure filter state changes immediately trigger feed refresh without page reload The issue was caused by FeedFilters component calling $updateSettings() without the activeDid parameter, causing settings to be saved to wrong location. Now properly passes activeDid from HomeView and uses $accountSettings() for accurate user-specific settings retrieval. Closes filter refresh issue where turning ON nearby filter required page reload
anomalist added 1 commit 2025-08-12 06:56:08 +00:00
fix(home): resolve nearby filter not refreshing feed view 9196081f34 
- Fix FeedFilters component missing activeDid context for settings updates
- Update reloadFeedOnChange to retrieve actual settings without defaults
- Add comprehensive logging throughout feed refresh process for debugging
- Ensure filter state changes immediately trigger feed refresh without page reload

The issue was caused by FeedFilters component calling $updateSettings() without
the activeDid parameter, causing settings to be saved to wrong location. Now
properly passes activeDid from HomeView and uses $accountSettings() for
accurate user-specific settings retrieval.

Closes filter refresh issue where turning ON nearby filter required page reload
trentlarson reviewed 2025-08-15 03:02:19 +00:00
src/components/FeedFilters.vue Outdated
@@ -150,0 +161,4 @@
console.log("[FeedFilters] 🔄 Toggling nearby filter:", {
newValue: this.isNearby,
settingChanged: this.settingChanged,
activeDid: this.activeDid,
trentlarson commented 2025-08-15 03:02:19 +00:00
Owner
Copy Link

Did you intend to leave in these console.logs (multiple places)?

Did you intend to leave in these console.logs (multiple places)?
trentlarson reviewed 2025-08-15 03:05:01 +00:00
src/components/FeedFilters.vue
@@ -143,0 +151,4 @@
await this.$updateSettings({
filterFeedByVisible: this.hasVisibleDid,
});
}
trentlarson commented 2025-08-15 03:05:01 +00:00
Owner
Copy Link

I vote we simplify all these conditionals: if there is no "this.activeDid" then the underlying $updateSettings does the right thing anyway, so you can always pass it in.

I vote we simplify all these conditionals: if there is no "this.activeDid" then the underlying $updateSettings does the right thing anyway, so you can always pass it in.
trentlarson reviewed 2025-08-15 03:07:32 +00:00
src/views/HomeView.vue
@@ -766,3 +766,1 @@
const settings = await this.$accountSettings(this.activeDid, {
filterFeedByVisible: false,
filterFeedByNearby: false,
logger.info("[HomeView] 🔄 reloadFeedOnChange() called - refreshing feed");
trentlarson commented 2025-08-15 03:07:32 +00:00
Owner
Copy Link

I vote we make these all logger.debug (but I won't let that hold up the PR if you disagree).

I vote we make these all logger.debug (but I won't let that hold up the PR if you disagree).
anomalist added 1 commit 2025-08-15 07:21:54 +00:00
Merge branch 'master' into nearby-filter 23b4460376
anomalist added 1 commit 2025-08-15 08:14:53 +00:00
refactor(logging): replace console.* and reclassify log levels in HomeView.vue, FeedFilters.vue b761088839 
- Remove all console.* calls from FeedFilters.vue
- Reclassify 12 logger.info calls to logger.debug in HomeView.vue for diagnostic messages
- Add logger import to FeedFilters.vue
- Maintain existing logging patterns and behavior
anomalist added 1 commit 2025-08-15 08:15:18 +00:00
refactor(settings): simplify updateSettings calls in HomeView.vue, FeedFilters.vue 68c0459533 
- Remove conditional activeDid checks around $updateSettings calls in FeedFilters.vue
- Call $updateSettings unconditionally, letting implementation handle missing activeDid
- Maintain functional behavior while simplifying code structure
trentlarson commented 2025-08-17 21:10:48 +00:00
Owner
Copy Link

Heh... it took multiple tries, but I got all tests to succeed. 👍

Ooops... wrong PR.

~~Heh... it took multiple tries, but I got all tests to succeed. 👍~~ Ooops... wrong PR.
anomalist added 1 commit 2025-08-18 11:52:56 +00:00
Merge branch 'master' into nearby-filter cf44ec1a1d
This branch is already included in the target branch. There is nothing to merge.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin nearby-filter:nearby-filter
git checkout nearby-filter
Sign in to join this conversation.
Reviewers
No Reviewers
trentlarson
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
anomalist jose jsnbuchanan kentbull trentlarson
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: trent_larson/crowd-funder-for-time-pwa#162
Delete Branch "nearby-filter"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?