fix(home): resolve nearby filter not refreshing feed view #162

Open
anomalist wants to merge 4 commits from nearby-filter into master
anomalist commented 5 days ago
Owner
  • Fix FeedFilters component missing activeDid context for settings updates
  • Update reloadFeedOnChange to retrieve actual settings without defaults
  • Add comprehensive logging throughout feed refresh process for debugging
  • Ensure filter state changes immediately trigger feed refresh without page reload

The issue was caused by FeedFilters component calling $updateSettings() without
the activeDid parameter, causing settings to be saved to wrong location. Now
properly passes activeDid from HomeView and uses $accountSettings() for
accurate user-specific settings retrieval.

Closes filter refresh issue where turning ON nearby filter required page reload

- Fix FeedFilters component missing activeDid context for settings updates - Update reloadFeedOnChange to retrieve actual settings without defaults - Add comprehensive logging throughout feed refresh process for debugging - Ensure filter state changes immediately trigger feed refresh without page reload The issue was caused by FeedFilters component calling $updateSettings() without the activeDid parameter, causing settings to be saved to wrong location. Now properly passes activeDid from HomeView and uses $accountSettings() for accurate user-specific settings retrieval. Closes filter refresh issue where turning ON nearby filter required page reload
anomalist added 1 commit 5 days ago
9196081f34 fix(home): resolve nearby filter not refreshing feed view
trentlarson reviewed 2 days ago
console.log("[FeedFilters] 🔄 Toggling nearby filter:", {
newValue: this.isNearby,
settingChanged: this.settingChanged,
activeDid: this.activeDid,
Poster
Owner

Did you intend to leave in these console.logs (multiple places)?

Did you intend to leave in these console.logs (multiple places)?
trentlarson reviewed 2 days ago
await this.$updateSettings({
filterFeedByVisible: this.hasVisibleDid,
});
}
Poster
Owner

I vote we simplify all these conditionals: if there is no "this.activeDid" then the underlying $updateSettings does the right thing anyway, so you can always pass it in.

I vote we simplify all these conditionals: if there is no "this.activeDid" then the underlying $updateSettings does the right thing anyway, so you can always pass it in.
trentlarson reviewed 2 days ago
const settings = await this.$accountSettings(this.activeDid, {
filterFeedByVisible: false,
filterFeedByNearby: false,
logger.info("[HomeView] 🔄 reloadFeedOnChange() called - refreshing feed");
Poster
Owner

I vote we make these all logger.debug (but I won't let that hold up the PR if you disagree).

I vote we make these all logger.debug (but I won't let that hold up the PR if you disagree).
anomalist added 1 commit 2 days ago
anomalist added 1 commit 2 days ago
b761088839 refactor(logging): replace console.* and reclassify log levels in HomeView.vue, FeedFilters.vue
anomalist added 1 commit 2 days ago
68c0459533 refactor(settings): simplify updateSettings calls in HomeView.vue, FeedFilters.vue
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.