trent_larson/crowd-funder-for-time-pwa
4
1
Fork 2
Code Issues Pull Requests 22 Releases 5 Wiki Activity

fix(android): resolve icon generation and build script errors #165

Closed
anomalist wants to merge 0 commits from imagemagick-anrdoid into master
pull from: imagemagick-anrdoid
merge into: trent_larson:master
Conversation 3 Commits - Files Changed -
anomalist commented 2025-08-13 02:31:05 +00:00
Owner
Copy Link

Fixed Android build issues that were preventing successful builds:

  • Updated icon generation script to create proper adaptive icons without
    referencing missing drawable files
  • Changed log_warning function call to log_warn in build script
  • Icon generation now creates foreground mipmap files and proper XML configs
  • Build process successfully generates all required Android assets

Resolves "export: production).=: not a valid identifier" error and enables
successful Android builds with automatic resource generation.

https://app.clickup.com/t/86b5uau17

Fixed Android build issues that were preventing successful builds: - Updated icon generation script to create proper adaptive icons without referencing missing drawable files - Changed log_warning function call to log_warn in build script - Icon generation now creates foreground mipmap files and proper XML configs - Build process successfully generates all required Android assets Resolves "export: production).=: not a valid identifier" error and enables successful Android builds with automatic resource generation. https://app.clickup.com/t/86b5uau17
anomalist added 1 commit 2025-08-13 02:31:05 +00:00
fix(android): resolve icon generation and build script errors ea6757c696 
Fixed Android build issues that were preventing successful builds:
- Updated icon generation script to create proper adaptive icons without
  referencing missing drawable files
- Changed log_warning function call to log_warn in build script
- Icon generation now creates foreground mipmap files and proper XML configs
- Build process successfully generates all required Android assets

Resolves "export: production).=: not a valid identifier" error and enables
successful Android builds with automatic resource generation.

https://app.clickup.com/t/86b5uau17
anomalist added 1 commit 2025-08-13 06:41:42 +00:00
fix(build): update ImageMagick commands to use modern v7 syntax 3926f9289d 
- Replace deprecated 'convert' commands with 'magick' for ImageMagick v7+
- Add automatic version detection with fallback to 'convert' for v6 compatibility
- Update generate-android-icons.sh and generate-icons.sh scripts
- Eliminate deprecation warnings during Android builds
- Maintain backward compatibility for older ImageMagick installations

The scripts now automatically detect ImageMagick version and use the appropriate
command syntax, eliminating the "convert command is deprecated" warnings while
preserving functionality across different ImageMagick versions.
anomalist added 1 commit 2025-08-13 07:06:57 +00:00
fix(assets): resolve Android and iOS resource generation issues 45a8859a19 
Android build was failing due to missing drawable and mipmap directories
for splash screens and launcher icons. iOS was missing complete asset
catalog structure for app icons and splash screens.

- Create missing Android resource directories (drawable, mipmap-*)
- Add splash screen files to Android drawable directory
- Generate complete set of Android launcher icons
- Create iOS asset catalog structure with proper Contents.json files
- Generate 21 iOS assets (app icons + splash screens) using ImageMagick
- Add resource validation scripts for both platforms
- Enhance Android resource check to auto-create missing directories

NOTE: you need to test this from a fresh clone and after an npm install!

Android build now completes successfully. iOS assets ready for macOS/Xcode
builds. Both platforms have complete resource sets for development.
anomalist added 11 commits 2025-08-14 05:57:05 +00:00
feat(logging): implement configurable log levels via VITE_LOG_LEVEL d30597a921 
Add comprehensive logging configuration system with environment variable support.
Environment files now include appropriate log levels per build mode:
- Development: debug (maximum visibility)
- Production: warn (minimal noise)
- Testing: info (balanced output)

Includes smart default behavior based on platform and environment,
enhanced logger methods for level checking, and comprehensive documentation.
All existing logging calls remain backward compatible.

Closes logging configuration request
fix(build): resolve shell script export error in .env.development 7df52312ba 
Fixed malformed comment in .env.development that was causing
"export: production).=: not a valid identifier" error in build scripts.
The comment was split across lines, causing the shell to interpret
" production)." as a variable assignment.

- Removed malformed comment line that was breaking build:web script
- Build script now successfully validates environment and starts server
- Resolves issue preventing Playwright tests from running properly
refactor(ui): remove unused image cache system and fix TypeScript compilation bb357f294a 
- Remove imageCache Map that only stored null values
- Remove selectedImageData Blob property (never used)
- Remove cacheImageData method and related function props
- Remove handleImageLoad method from ActivityListItem
- Clean up ImageViewer component props
- Fix TypeScript compilation by replacing legacy logConsoleAndDb calls
- Replace logConsoleAndDb with logger.error in deepLinks service
- Images continue to work via direct URL references

The image cache system was non-functional and only stored null values.
ImageViewer component ignored blob data and only used URLs.
Fixed production build failure caused by undefined logConsoleAndDb function.
Removing dead code improves maintainability without affecting functionality.
fix(lint): resolve low and medium impact warnings adfaef7947 
- Remove console statements and replace with proper logging
- Fix line length violations in comments
- Maintain functionality while improving code quality

Reduces lint warnings from 30 to 25 by addressing:
- 3 console statement violations
- 2 line length violations
doc: Add helpful setup instructions for quick start for new devs. 81377d1fb6
chore: Bump version and add "-beta". 24a2dce43e
feat: Add easier way for test users to register themselves. a221a5c5ed
doc: Add instructions to become test user, and other README refactors. 81096a8bee
Merge branch 'master' into remove-image-cache a3b69fc0d4
Merge branch 'master' into logger-level c91ac135b3
Merge branch 'master' into imagemagick-anrdoid 1a6b1e6151
anomalist added 1 commit 2025-08-14 07:21:57 +00:00
feat(assets): standardize asset configuration with capacitor-assets a284067522 
- Replace manual ImageMagick scripts with official capacitor-assets toolchain
- Consolidate duplicate asset sources to single resources/ directory
- Implement comprehensive asset configuration schema and validation
- Add CI safeguards for asset validation and platform asset detection
- Convert capacitor.config.json to TypeScript format
- Pin Node.js version for deterministic builds
- Remove legacy manual asset generation scripts:
  * generate-icons.sh, generate-ios-assets.sh, generate-android-icons.sh
  * check-android-resources.sh, check-ios-resources.sh
  * purge-generated-assets.sh
- Add new asset management commands:
  * assets:config - generate/update configurations
  * assets:validate - validate configurations
  * assets:clean - clean generated assets (dev only)
  * build:native - build with asset generation
- Create GitHub Actions workflow for asset validation
- Update documentation with new asset management workflow

This standardization eliminates asset duplication, improves build reliability,
and provides a maintainable asset management system using Capacitor defaults.

Breaking Changes: Manual asset generation scripts removed
Migration: Assets now sourced from resources/ directory only
CI: Automated validation prevents committed platform assets
anomalist added 1 commit 2025-08-14 08:42:46 +00:00
fix(build): update Android build script to use new asset validation 76749a097d 
- Replace check-android-resources.sh call with npm run assets:validate
- Fix 'No such file or directory' error in build-android.sh
- Ensure builds work consistently across all development environments
- Maintain build workflow while using new standardized asset system

This fix resolves the build failure that occurred after removing legacy
asset generation scripts, ensuring the new capacitor-assets workflow
integrates seamlessly with existing build orchestration.

Tested: Android build completes successfully with asset validation
Assets: 87 platform assets generated automatically via capacitor-assets
anomalist added 1 commit 2025-08-14 09:07:11 +00:00
refactor(assets): convert asset management scripts to TypeScript with tsx 495a94827a 
- Replace JavaScript asset scripts with TypeScript equivalents
- Install tsx for direct TypeScript execution without compilation
- Add proper TypeScript interfaces for AssetConfig and validation
- Update package.json scripts to use tsx instead of node
- Remove old JavaScript files (assets-config.js, assets-validator.js)
- Maintain all existing functionality while improving type safety
- Fix module syntax issues that caused build failures on macOS

Scripts affected:
- assets:config: node → tsx scripts/assets-config.ts
- assets:validate: node → tsx scripts/assets-validator.ts

Benefits:
- Eliminates CommonJS/ES module syntax conflicts
- Provides better type safety and IntelliSense
- Modernizes development tooling
- Ensures cross-platform compatibility
trentlarson commented 2025-08-15 03:41:50 +00:00
Owner
Copy Link

👍 ❕

👍 ❕
trentlarson reviewed 2025-08-17 19:45:01 +00:00
.cursor/rules/asset_configuration.mdc
@@ -0,0 +1,32 @@
---
alwaysApply: true
trentlarson commented 2025-08-17 19:45:01 +00:00
Owner
Copy Link

Seems like a like a file that doesn't always need to be applied.

Seems like a like a file that doesn't always need to be applied.
trentlarson commented 2025-08-17 19:47:58 +00:00
Owner
Copy Link

LGTM!

LGTM!
anomalist added 1 commit 2025-08-18 06:11:49 +00:00
Merge branch 'master' into imagemagick-anrdoid 3aa57c5ced
anomalist closed this pull request 2025-08-18 07:00:35 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
trentlarson
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
anomalist jose jsnbuchanan kentbull trentlarson
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: trent_larson/crowd-funder-for-time-pwa#165
Delete Branch "imagemagick-anrdoid"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?