vitejs refactor #110

Merged
trentlarson merged 17 commits from jsnbuchanan/crowd-funder-for-time-pwa:feat/vitejs into master 8 months ago
Owner

Here's the first stab at the vitejs refactor. I'm not completely done testing. When I start it up, I get the below screenshot with an error notification, Could not set notifications., so I could have messed something up.

I also see App.vue:346 Got vapid key: in the browser console... which may just be an error in my local configuration.

To start the vite development server run:

npm run dev

The other big difference was having to change environment variables. Instead of VUE_APP_, the prefix is now VITE_.

So, we'll need to update devops configs probably.

Here's the first stab at the vitejs refactor. I'm not completely done testing. When I start it up, I get the below screenshot with an error notification, `Could not set notifications.`, so I could have messed something up. I also see `App.vue:346 Got vapid key:` in the browser console... which may just be an error in my local configuration. To start the vite development server run: ``` npm run dev ``` The other big difference was having to change environment variables. Instead of `VUE_APP_`, the prefix is now `VITE_`. **So, we'll need to update devops configs probably.**
jsnbuchanan added 6 commits 8 months ago
6f49260c1e
fix: AccountViewView.vue template not resolving dep for dexie-export-import/dist/import
01b5ca6ec8
chore: update vitejs config to deploy on the same default port as the @vue/cli-service
Owner

I'll put items into separate comments.

  • Looks like the npm run serve doesn't work -- at least, I get a blank screen at the port it gives. Since npm run dev now runs fine, we can just remove the serve from the README.
I'll put items into separate comments. - Looks like the `npm run serve` doesn't work -- at least, I get a blank screen at the port it gives. Since `npm run dev` now runs fine, we can just remove the `serve` from the README.
Owner
  • You're right about the /vapid calls: those simply don't work locally and that's fine. (We only test that on dev servers with domains.)
* You're right about the /vapid calls: those simply don't work locally and that's fine. (We only test that on dev servers with domains.)
Owner
  • This one is a showstopper: on the account screen, "Download settings & contacts" gives a red error with this in the console: "Export Error: TypeError: (intermediate value).export is not a function", complaining about "generateDatabaseBlob"

This works OK on the other repo's master branch.

* This one is a showstopper: on the account screen, "Download settings & contacts" gives a red error with this in the console: "Export Error: TypeError: (intermediate value).export is not a function", complaining about "generateDatabaseBlob" This works OK on the other repo's master branch.
Owner

Things look pretty good! I think there's just that one issue. I'll try an actual deploy in docker onto the test server soon.

Things look pretty good! I think there's just that one issue. I'll try an actual deploy in docker onto the test server soon.
trentlarson reviewed 8 months ago
<script lang="ts">
import { AxiosError, AxiosRequestConfig } from "axios";
import Dexie from "dexie";
import "dexie-export-import";
Poster
Owner

This is a line that is needed for the db.export call (since it adds to the Dexie prototype).

This is a line that is needed for the db.export call (since it adds to the Dexie prototype).
trentlarson reviewed 8 months ago
alias: {
"@": path.resolve(__dirname, "./src"),
buffer: path.resolve(__dirname, 'node_modules', 'buffer'),
'dexie-export-import/dist/import': 'dexie-export-import/dist/import/index.js',
Poster
Owner

I now see this, which possibly takes the place of that import... so I guess we'll want to talk more about how this should work

I now see this, which possibly takes the place of that import... so I guess we'll want to talk more about how this should work
Poster
Owner

It works to have both of these in place so I'll continue with both.

It works to have both of these in place so I'll continue with both.
Poster
Owner

Okay. Sounds good @trentlarson

Okay. Sounds good @trentlarson
jsnbuchanan marked this conversation as resolved
Owner

Things work, but FYI with npm run dev when I make changes to files then the effects don't take place immediately -- which is curious because the console will show a message thus:

[vite] hot updated: /src/views/AccountViewView.vue

I only see changes when I reload.
Not a show-stopper.

Things work, but FYI with `npm run dev` when I make changes to files then the effects don't take place immediately -- which is curious because the console will show a message thus: `[vite] hot updated: /src/views/AccountViewView.vue` I only see changes when I reload. Not a show-stopper.
jsnbuchanan added 9 commits 8 months ago
Owner
My work is continuing here: https://gitea.anomalistdesign.com/jsnbuchanan/crowd-funder-for-time-pwa/pulls/1
jsnbuchanan changed title from WIP: vitejs refactor to vitejs refactor 8 months ago
jsnbuchanan added 2 commits 8 months ago
trentlarson merged commit a0ef8b6fd3 into master 8 months ago
The pull request has been merged as a0ef8b6fd3.
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.