jsnbuchanan
/
crowd-funder-for-time-pwa
forked from trent_larson/crowd-funder-for-time-pwa
1
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity
Labels Milestones

A couple small fixes, plus a merge from master #1

Merged
jsnbuchanan merged 45 commits from trentlarson/crowd-funder-from-jason:feat/vitejs-trent into feat/vitejs 8 months ago
Conversation 2 Commits 45 Files Changed 37
trentlarson commented 8 months ago

This includes the following tiny fixes:

All the rest of the changes are due to a merge from master from the original repo. (I did this as a merge instead of a rebase, mostly because I've been experimenting.)

I'm open to other approaches, eg. rebasing, or pulling into your repo from master (which requires some permissions to me), or... whatever.

The only remaining task before merging is to deploy this to my test server and put it through the paces (which I'll do today), but I expect no issues since npm run build and npm run serve already worked.

This includes the following tiny fixes: * a [fix for the contact-download](https://gitea.anomalistdesign.com/trentlarson/crowd-funder-from-jason/commit/0fbd1ad51a9b383b9935b62868d0d354b5985bf4) * a [change to avoid an on-screen error on localhost](https://gitea.anomalistdesign.com/trentlarson/crowd-funder-from-jason/commit/2ae165d56fb9decbeb608872e06896e00abc6731) * a [change to avoid a console error in a common case](https://gitea.anomalistdesign.com/trentlarson/crowd-funder-from-jason/commit/78fab735e6bb331f0e3b7554bbc7edcefeda1f39) All the rest of the changes are due to a merge from master from the original repo. (I did this as a merge instead of a rebase, mostly because I've been experimenting.) I'm open to other approaches, eg. rebasing, or pulling into your repo from master (which requires some permissions to me), or... whatever. The only remaining task before merging is to deploy this to my test server and put it through the paces (which I'll do today), but I expect no issues since `npm run build` and `npm run serve` already worked.
trentlarson added 41 commits 8 months ago
dce4d3cc72 Button width changes
trentlarson added 1 commit 8 months ago
trentlarson commented 8 months ago
Poster

OK, I added some linting fixes.

Note that I changed the default to report lint errors and not fix them, with a separate command to fix them. (I don't mind making "fix" the default as long as we have some command that only reports.)

OK, I added some linting fixes. Note that I changed the default to report lint errors and not fix them, with a separate command to fix them. (I don't mind making "fix" the default as long as we have some command that only reports.)
trentlarson added 1 commit 8 months ago
trentlarson added 1 commit 8 months ago
trentlarson added 1 commit 8 months ago
jsnbuchanan merged commit 333ac773f6 into feat/vitejs 8 months ago
trentlarson commented 8 months ago
Poster

Houston, we have a problem: the vite.config.js is not fully applied on npm run build: the Help page doesn't show a git hash and the sw_scripts-combined.js file is not created and copied into the dist directory.

Houston, we have a problem: the vite.config.js is not fully applied on `npm run build`: the Help page doesn't show a git hash and the sw_scripts-combined.js file is not created and copied into the dist directory.
The pull request has been merged as 333ac773f6.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
No items
No Label
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'trentlarson/crowd-funder-from-jason:feat/vitejs-trent'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes