trent_larson/crowd-funder-for-time-pwa
4
1
Fork 2
Code Issues Pull Requests 22 Releases 5 Wiki Activity

remove code for lowercase checks (that were for old uPort) #1

Merged
anomalist merged 1 commits from remove-unused-lowercases into master 2023-01-01 02:03:38 +00:00
Conversation 1 Commits 1 Files Changed 2 +8 -27
trentlarson commented 2022-12-29 23:18:38 +00:00
Owner
Copy Link

This looks like code from the endorser-mobile project. It was for some weirdness migrating from the old uPort.

I've marked this WIP because I have one user (me) who still has an address with that old format, so I'm gonna ponder if there's an easy way to support my use cases.

This looks like code from the endorser-mobile project. It was for some weirdness migrating from the old uPort. ~~I've marked this WIP because I have one user (me) who still has an address with that old format, so I'm gonna ponder if there's an easy way to support my use cases.~~
trentlarson added 1 commit 2022-12-29 23:18:38 +00:00
fix: remove code for lowercase checks (that were for old uPort) d2cea34242
trentlarson commented 2022-12-30 00:56:19 +00:00
Author
Owner
Copy Link

Yeah, I don't think this makes sense on the creation; there are no previousIdentifiers in this case, and it's just for the import so we could discuss whether it's necessary at that point.

Yeah, I don't think this makes sense on the creation; there are no previousIdentifiers in this case, and it's just for [the import](https://github.com/trentlarson/endorser-mobile/blob/master/src/screens/ExportImportIdentity.tsx#L142) so we could discuss whether it's necessary at that point.
trentlarson changed title from WIP: remove code for lowercase checks (that were for old uPort) to remove code for lowercase checks (that were for old uPort) 2022-12-30 00:56:23 +00:00
anomalist merged commit 236c1c2836 into master 2023-01-01 02:03:38 +00:00
trentlarson deleted branch remove-unused-lowercases 2023-01-01 19:25:09 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
anomalist jose jsnbuchanan kentbull trentlarson
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: trent_larson/crowd-funder-for-time-pwa#1
Delete Branch "remove-unused-lowercases"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?