Labels Milestones

remove code for lowercase checks (that were for old uPort) #1

Merged

anomalist merged 1 commits from remove-unused-lowercases into master 2 years ago

Conversation 1 Commits 1 Files Changed 2

trentlarson commented 2 years ago

Owner

This looks like code from the endorser-mobile project. It was for some weirdness migrating from the old uPort.

I've marked this WIP because I have one user (me) who still has an address with that old format, so I'm gonna ponder if there's an easy way to support my use cases.

This looks like code from the endorser-mobile project. It was for some weirdness migrating from the old uPort. ~~I've marked this WIP because I have one user (me) who still has an address with that old format, so I'm gonna ponder if there's an easy way to support my use cases.~~

trentlarson added 1 commit 2 years ago

d2cea34242 fix: remove code for lowercase checks (that were for old uPort)

trentlarson commented 2 years ago

Poster

Owner

Yeah, I don't think this makes sense on the creation; there are no previousIdentifiers in this case, and it's just for the import so we could discuss whether it's necessary at that point.

Yeah, I don't think this makes sense on the creation; there are no previousIdentifiers in this case, and it's just for [the import](https://github.com/trentlarson/endorser-mobile/blob/master/src/screens/ExportImportIdentity.tsx#L142) so we could discuss whether it's necessary at that point.

trentlarson changed title from WIP: remove code for lowercase checks (that were for old uPort) to remove code for lowercase checks (that were for old uPort) 2 years ago

anomalist merged commit 236c1c2836 into master 2 years ago

anomalist referenced this issue from a commit 2 years ago

Merge pull request 'remove code for lowercase checks (that were for old uPort)' (#1) from remove-unused-lowercases into master

trentlarson deleted branch remove-unused-lowercases 2 years ago

trentlarson referenced this issue from a commit 5 months ago

Merge pull request 'A couple small fixes, plus a merge from master' (#1) from trentlarson/crowd-funder-from-jason:feat/vitejs-trent into feat/vitejs

The pull request has been merged as 236c1c2836.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

Labels

Apply labels

Clear labels

No items

No Label

Milestone

Set milestone

Clear milestone

No items

No Milestone

Assignees

Assign users

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview

Loading…

Cancel

Save

There is no content yet.