trent_larson/crowd-funder-for-time-pwa
4
1
Fork 2
Code Issues Pull Requests 22 Releases 5 Wiki Activity

vitejs refactor #110

Merged
trentlarson merged 17 commits from jsnbuchanan/crowd-funder-for-time-pwa:feat/vitejs into master 2024-04-09 23:49:48 +00:00
Conversation 8 Commits 17 Files Changed 24 +5354 -14128
jsnbuchanan commented 2024-03-25 14:19:03 +00:00
Owner
Copy Link

Here's the first stab at the vitejs refactor. I'm not completely done testing. When I start it up, I get the below screenshot with an error notification, Could not set notifications., so I could have messed something up.

I also see App.vue:346 Got vapid key: in the browser console... which may just be an error in my local configuration.

To start the vite development server run:

npm run dev

The other big difference was having to change environment variables. Instead of VUE_APP_, the prefix is now VITE_.

So, we'll need to update devops configs probably.

Here's the first stab at the vitejs refactor. I'm not completely done testing. When I start it up, I get the below screenshot with an error notification, `Could not set notifications.`, so I could have messed something up. I also see `App.vue:346 Got vapid key:` in the browser console... which may just be an error in my local configuration. To start the vite development server run: ``` npm run dev ``` The other big difference was having to change environment variables. Instead of `VUE_APP_`, the prefix is now `VITE_`. **So, we'll need to update devops configs probably.**
Screenshot 2024-03-25 at 8.15.59 AM.png
95 KiB
Screenshot 2024-03-25 at 8.15.59 AM.png
jsnbuchanan added 6 commits 2024-03-25 14:19:04 +00:00
Initial stab at vitejs update 38f44771e9
fix: AccountViewView.vue template not resolving dep for dexie-export-import/dist/import 6f49260c1e 
Previous error:

Error: The following dependencies are imported but could not be resolved:

  dexie-export-import/dist/import (imported by /Users/jason/dev/src/trent/crowd-funder-for-time-pwa/src/views/AccountViewView.vue?id=0)

Are they installed?
    at file:///Users/jason/dev/src/trent/crowd-funder-for-time-pwa/node_modules/vite/dist/node/chunks/dep-DJaaTb_D.js:52506:23
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async file:///Users/jason/dev/src/trent/crowd-funder-for-time-pwa/node_modules/vite/dist/node/chunks/dep-DJaaTb_D.js:51972:38
chore: update vitejs config to deploy on the same default port as the @vue/cli-service 01b5ca6ec8 
This port is 8080. This is done to not break existing tooling and devops code.
fix: es modules syntax for buffer deps instead of commonjs require ca240ab795
fix: buffer typescript error in util.ts when parsing ArrayBuffer 09dccc34d6
docs: adding do for updated development server run command 035f2a5b04 
- `npm run dev`
trentlarson commented 2024-04-02 01:20:01 +00:00
Owner
Copy Link

I'll put items into separate comments.

  • Looks like the npm run serve doesn't work -- at least, I get a blank screen at the port it gives. Since npm run dev now runs fine, we can just remove the serve from the README.
I'll put items into separate comments. - Looks like the `npm run serve` doesn't work -- at least, I get a blank screen at the port it gives. Since `npm run dev` now runs fine, we can just remove the `serve` from the README.
trentlarson commented 2024-04-02 01:22:11 +00:00
Owner
Copy Link
  • You're right about the /vapid calls: those simply don't work locally and that's fine. (We only test that on dev servers with domains.)
* You're right about the /vapid calls: those simply don't work locally and that's fine. (We only test that on dev servers with domains.)
trentlarson commented 2024-04-02 01:40:42 +00:00
Owner
Copy Link
  • This one is a showstopper: on the account screen, "Download settings & contacts" gives a red error with this in the console: "Export Error: TypeError: (intermediate value).export is not a function", complaining about "generateDatabaseBlob"

This works OK on the other repo's master branch.

* This one is a showstopper: on the account screen, "Download settings & contacts" gives a red error with this in the console: "Export Error: TypeError: (intermediate value).export is not a function", complaining about "generateDatabaseBlob" This works OK on the other repo's master branch.
trentlarson commented 2024-04-02 01:41:20 +00:00
Owner
Copy Link

Things look pretty good! I think there's just that one issue. I'll try an actual deploy in docker onto the test server soon.

Things look pretty good! I think there's just that one issue. I'll try an actual deploy in docker onto the test server soon.
trentlarson reviewed 2024-04-07 00:37:06 +00:00
src/views/AccountViewView.vue Outdated
@@ -516,7 +516,6 @@
<script lang="ts">
import { AxiosError, AxiosRequestConfig } from "axios";
import Dexie from "dexie";
import "dexie-export-import";
trentlarson commented 2024-04-07 00:37:06 +00:00
Owner
Copy Link

This is a line that is needed for the db.export call (since it adds to the Dexie prototype).

This is a line that is needed for the db.export call (since it adds to the Dexie prototype).
trentlarson reviewed 2024-04-07 00:52:28 +00:00
vite.config.mjs
@@ -0,0 +12,4 @@
alias: {
"@": path.resolve(__dirname, "./src"),
buffer: path.resolve(__dirname, 'node_modules', 'buffer'),
'dexie-export-import/dist/import': 'dexie-export-import/dist/import/index.js',
trentlarson commented 2024-04-07 00:52:28 +00:00
Owner
Copy Link

I now see this, which possibly takes the place of that import... so I guess we'll want to talk more about how this should work

I now see this, which possibly takes the place of that import... so I guess we'll want to talk more about how this should work
👍 1
trentlarson commented 2024-04-07 14:42:42 +00:00
Owner
Copy Link

It works to have both of these in place so I'll continue with both.

It works to have both of these in place so I'll continue with both.
👍 1
jsnbuchanan commented 2024-04-07 18:01:18 +00:00
Author
Owner
Copy Link

Okay. Sounds good @trentlarson

Okay. Sounds good @trentlarson
jsnbuchanan marked this conversation as resolved
trentlarson commented 2024-04-07 14:44:40 +00:00
Owner
Copy Link

Things work, but FYI with npm run dev when I make changes to files then the effects don't take place immediately -- which is curious because the console will show a message thus:

[vite] hot updated: /src/views/AccountViewView.vue

I only see changes when I reload.
Not a show-stopper.

Things work, but FYI with `npm run dev` when I make changes to files then the effects don't take place immediately -- which is curious because the console will show a message thus: `[vite] hot updated: /src/views/AccountViewView.vue` I only see changes when I reload. Not a show-stopper.
jsnbuchanan added 9 commits 2024-04-07 17:52:44 +00:00
add missing Dexie import (which causes failure upon download click) 0fbd1ad51a
reorder home page vapid check to avoid an error on localhost 2ae165d56f
avoid a huge error message in a likely-well-known scenario 78fab735e6
Merge remote-tracking branch 'original-origin/master' into feat/vitejs-trent 5828a290c7
fix linting ab81648aca
add linting before any build 28f72640d7
fix title of the test app 5994365a6c
remove a lingering debug console.log 1459719a47
Merge pull request 'A couple small fixes, plus a merge from master' (#1) from trentlarson/crowd-funder-from-jason:feat/vitejs-trent into feat/vitejs 333ac773f6 
Reviewed-on: jsnbuchanan/crowd-funder-for-time-pwa#1
trentlarson commented 2024-04-07 17:56:01 +00:00
Owner
Copy Link

My work is continuing here: jsnbuchanan/crowd-funder-for-time-pwa#1

My work is continuing here: https://gitea.anomalistdesign.com/jsnbuchanan/crowd-funder-for-time-pwa/pulls/1
jsnbuchanan changed title from WIP: vitejs refactor to vitejs refactor 2024-04-07 17:56:43 +00:00
jsnbuchanan added 2 commits 2024-04-09 10:05:57 +00:00
misc tweaks for new vite build 0b446ec134
Merge pull request 'misc tweaks for new vite build' (#4) from trentlarson/crowd-funder-from-jason:feat/vitejs-trent3 into feat/vitejs 1befff0abd 
Reviewed-on: jsnbuchanan/crowd-funder-for-time-pwa#4
trentlarson merged commit a0ef8b6fd3 into master 2024-04-09 23:49:48 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
trentlarson
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
anomalist jose jsnbuchanan kentbull trentlarson
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: trent_larson/crowd-funder-for-time-pwa#110
Delete Branch "jsnbuchanan/crowd-funder-for-time-pwa:feat/vitejs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?