fix(android): resolve icon generation and build script errors
#165
Open
anomalist
wants to merge 7 commits from imagemagick-anrdoid
into master
pull from: imagemagick-anrdoid
merge into: trent_larson:master
trent_larson:ai-context
trent_larson:android-15-check
trent_larson:app_id_fix
trent_larson:ask-for-contacts-export
trent_larson:build-dev-to-dist
trent_larson:build-improvement
trent_larson:build-ios
trent_larson:build-with-env
trent_larson:capacitor-local-save
trent_larson:claim-view-error-handling
trent_larson:claimview-fullfills-offer
trent_larson:contact-gifting-current-user
trent_larson:contacts-view-fixes
trent_larson:cross-platform-factory
trent_larson:cross-platform-factory-redux
trent_larson:d9085ced6df7dc7bdcd899959cea6489cab7f8b8
trent_larson:db-backup-cross-platform
trent_larson:deep-link
trent_larson:deep-links-android-update
trent_larson:deep_linking
trent_larson:design-tweaks-2023-12
trent_larson:electron_fix_20250317
trent_larson:experimental_plugin
trent_larson:eye-slash
trent_larson:fix-contact-import-export
trent_larson:fix-service-worker
trent_larson:friend-tech-inspired-pwa-dialog
trent_larson:get-get-hash
trent_larson:gifting-periphery-improvements
trent_larson:gifting-ui-2025-05
trent_larson:home-icon-enhancements
trent_larson:home-view-notification-improvements
trent_larson:homeview-cleanup-2025-03
trent_larson:homeview-refresh-2025-02
trent_larson:ios-contact-copy
trent_larson:logger-level
trent_larson:logging-upgrade
trent_larson:main
trent_larson:master
trent_larson:master-settings-upgrade
trent_larson:matthew-scratch-2025-06-28
trent_larson:migrate-dexie-to-sqlite
trent_larson:nearby-filter
trent_larson:new-storage
trent_larson:nostr
trent_larson:notification-line-wrapping
trent_larson:notification-request-permission-dialog
trent_larson:notification-section
trent_larson:notify-time
trent_larson:offer-edit
trent_larson:offer-validation-logic
trent_larson:onboarding-dialog-fix
trent_larson:passkey
trent_larson:passkey-cache
trent_larson:performance-optimizations-testing
trent_larson:photo-reverse
trent_larson:plan-loc
trent_larson:platformservicemixin-interface-consolidation
trent_larson:playwright-pwa-install-test
trent_larson:playwright-test-60-fix
trent_larson:playwright-test-updates
trent_larson:profile-pic
trent_larson:project-gives
trent_larson:qrcode-capacitor
trent_larson:registration-gate
trent_larson:remove-image-cache
trent_larson:replace-iconrenderer
trent_larson:script-build-mode
trent_larson:search-map-fix
trent_larson:side_step
trent_larson:simple-signer
trent_larson:split_build_process
trent_larson:sql-absurd-sql
trent_larson:sql-absurd-sql-further
trent_larson:sql-wa-sqlite
trent_larson:star-projects
trent_larson:starred-projects
trent_larson:streamline-attempt
trent_larson:sw-cleanup
trent_larson:tmp
trent_larson:trent-tweaks
trent_larson:tweaks
trent_larson:ui-fixes-2024-03
trent_larson:ui-fixes-2025-03
trent_larson:ui-fixes-2025-06-w2
trent_larson:units-mocking
trent_larson:v-onboarding-2024-04
trent_larson:vite-version
trent_larson:web-serve-fix
trent_larson:web-tests
7 Commits
Author | SHA1 | Message | Date |
---|---|---|---|
|
495a94827a |
refactor(assets): convert asset management scripts to TypeScript with tsx
- Replace JavaScript asset scripts with TypeScript equivalents - Install tsx for direct TypeScript execution without compilation - Add proper TypeScript interfaces for AssetConfig and validation - Update package.json scripts to use tsx instead of node - Remove old JavaScript files (assets-config.js, assets-validator.js) - Maintain all existing functionality while improving type safety - Fix module syntax issues that caused build failures on macOS Scripts affected: - assets:config: node → tsx scripts/assets-config.ts - assets:validate: node → tsx scripts/assets-validator.ts Benefits: - Eliminates CommonJS/ES module syntax conflicts - Provides better type safety and IntelliSense - Modernizes development tooling - Ensures cross-platform compatibility |
3 days ago |
|
76749a097d |
fix(build): update Android build script to use new asset validation
- Replace check-android-resources.sh call with npm run assets:validate - Fix 'No such file or directory' error in build-android.sh - Ensure builds work consistently across all development environments - Maintain build workflow while using new standardized asset system This fix resolves the build failure that occurred after removing legacy asset generation scripts, ensuring the new capacitor-assets workflow integrates seamlessly with existing build orchestration. Tested: Android build completes successfully with asset validation Assets: 87 platform assets generated automatically via capacitor-assets |
3 days ago |
|
a284067522 |
feat(assets): standardize asset configuration with capacitor-assets
- Replace manual ImageMagick scripts with official capacitor-assets toolchain - Consolidate duplicate asset sources to single resources/ directory - Implement comprehensive asset configuration schema and validation - Add CI safeguards for asset validation and platform asset detection - Convert capacitor.config.json to TypeScript format - Pin Node.js version for deterministic builds - Remove legacy manual asset generation scripts: * generate-icons.sh, generate-ios-assets.sh, generate-android-icons.sh * check-android-resources.sh, check-ios-resources.sh * purge-generated-assets.sh - Add new asset management commands: * assets:config - generate/update configurations * assets:validate - validate configurations * assets:clean - clean generated assets (dev only) * build:native - build with asset generation - Create GitHub Actions workflow for asset validation - Update documentation with new asset management workflow This standardization eliminates asset duplication, improves build reliability, and provides a maintainable asset management system using Capacitor defaults. Breaking Changes: Manual asset generation scripts removed Migration: Assets now sourced from resources/ directory only CI: Automated validation prevents committed platform assets |
3 days ago |
|
1a6b1e6151 |
Merge branch 'master' into imagemagick-anrdoid
|
3 days ago |
|
45a8859a19 |
fix(assets): resolve Android and iOS resource generation issues
Android build was failing due to missing drawable and mipmap directories for splash screens and launcher icons. iOS was missing complete asset catalog structure for app icons and splash screens. - Create missing Android resource directories (drawable, mipmap-*) - Add splash screen files to Android drawable directory - Generate complete set of Android launcher icons - Create iOS asset catalog structure with proper Contents.json files - Generate 21 iOS assets (app icons + splash screens) using ImageMagick - Add resource validation scripts for both platforms - Enhance Android resource check to auto-create missing directories NOTE: you need to test this from a fresh clone and after an npm install! Android build now completes successfully. iOS assets ready for macOS/Xcode builds. Both platforms have complete resource sets for development. |
4 days ago |
|
3926f9289d |
fix(build): update ImageMagick commands to use modern v7 syntax
- Replace deprecated 'convert' commands with 'magick' for ImageMagick v7+ - Add automatic version detection with fallback to 'convert' for v6 compatibility - Update generate-android-icons.sh and generate-icons.sh scripts - Eliminate deprecation warnings during Android builds - Maintain backward compatibility for older ImageMagick installations The scripts now automatically detect ImageMagick version and use the appropriate command syntax, eliminating the "convert command is deprecated" warnings while preserving functionality across different ImageMagick versions. |
4 days ago |
|
ea6757c696 |
fix(android): resolve icon generation and build script errors
Fixed Android build issues that were preventing successful builds: - Updated icon generation script to create proper adaptive icons without referencing missing drawable files - Changed log_warning function call to log_warn in build script - Icon generation now creates foreground mipmap files and proper XML configs - Build process successfully generates all required Android assets Resolves "export: production).=: not a valid identifier" error and enables successful Android builds with automatic resource generation. https://app.clickup.com/t/86b5uau17 |
4 days ago |