Commit Graph

115 Commits

Author SHA1 Message Date
Matthew Raymer
8e2cbdbd1b Merge branch 'build-improvement' into performance-optimizations-testing 2025-08-07 05:39:24 +00:00
Matthew Raymer
6868a322f1 feat: switch ContactQRScanShowView to URL-based contact sharing
- Replace CSV QR value copying with URL generation for better UX
- Add generateEndorserJwtUrlForAccount import and Account type
- Implement proper error handling for URL generation failures
- Maintain consistency with ContactQRScanFullView behavior
- Add documentation for the URL solution implementation

Recipients can now click shared URLs to add contacts directly instead of
manually pasting CSV data into input fields.

addresses:  https://app.clickup.com/t/86b63xhz4
2025-08-07 03:14:45 +00:00
Matthew Raymer
4140f348c0 Merge branch 'build-improvement' into performance-optimizations-testing 2025-08-06 06:41:02 +00:00
Matthew Raymer
974d33b322 Document environment variable precedence and API configuration scheme
Add comprehensive documentation explaining the order of precedence for
environment variables in TimeSafari project. Covers shell script overrides,
platform-specific configurations, .env file usage, and API alignment between
claim and partner APIs. Includes troubleshooting guide and best practices
for maintaining consistent environment configuration across development,
test, and production environments.
2025-08-05 11:51:48 +00:00
Matthew Raymer
3b1a63468c Add iOS support for custom API IP configuration
Extend custom API IP feature to iOS platform with platform-appropriate defaults:
- Android: Defaults to 10.0.2.2 for emulator, custom IP for physical devices
- iOS: Uses localhost for simulator, custom IP for physical devices
- Added npm scripts for iOS custom IP builds (dev:custom, test:custom)
- Updated documentation to cover both platforms with examples
- Consistent --api-ip parameter across Android and iOS build scripts

Usage:
  ./scripts/build-ios.sh --dev                    # Default localhost
  ./scripts/build-ios.sh --dev --api-ip 192.168.1.100  # Custom IP
2025-08-05 10:43:51 +00:00
Matthew Raymer
1d6418b02c Add custom API IP support for Android physical device development
Implement --api-ip parameter for Android builds with smart defaults:
- Defaults to 10.0.2.2 for emulator development when no IP specified
- Supports custom IP for physical device development
- Added npm scripts for common use cases (dev:custom, test:custom)
- Updated help documentation with usage examples
- Created comprehensive documentation with troubleshooting guide

Usage:
  ./scripts/build-android.sh --dev                    # Default 10.0.2.2
  ./scripts/build-android.sh --dev --api-ip 192.168.1.100  # Custom IP
2025-08-05 10:26:38 +00:00
Matthew Raymer
9bfa439e9c Merge branch 'build-improvement' into performance-optimizations-testing 2025-08-04 05:10:00 +00:00
Matthew Raymer
aed16ebe94 Remove PROD_SHARE_DOMAIN constant and unify domain configuration
- Remove hard-coded PROD_SHARE_DOMAIN from src/constants/app.ts
- Update all sharing functionality to use environment-specific APP_SERVER
- Rewrite domain configuration documentation to reflect unified approach
- Simplify domain management with single APP_SERVER constant
- Update README.md examples to use APP_SERVER for all URL generation

This change eliminates the complexity of separate constants for different
URL types and provides consistent environment-specific configuration for
all functionality including sharing.
2025-08-04 03:52:21 +00:00
Matthew Raymer
2e9b2ee58e Merge branch 'build-improvement' into performance-optimizations-testing 2025-08-04 02:48:08 +00:00
Jose Olarte III
06f3a4c7c2 Refactor: simplify GiftedDialog with explicit entity type props
Replace complex updateEntityTypes() method with explicit giverEntityType and
recipientEntityType props. This makes the component more declarative and
maintainable by removing hidden logic and making entity type relationships
clear at the call site.

- Remove updateEntityTypes() method and related watchers
- Add explicit giverEntityType and recipientEntityType props with defaults
- Update all views to use inline logic for entity type determination
- Fix entity type preservation in navigation flows
- Enhance query parameter passing for better context preservation
- Fix recipient reset issue in ContactGiftingView
- Resolve entity type mismatch in HomeView project button flow

Files changed:
- GiftedDialog.vue: Remove complex logic, add explicit props
- EntitySelectionStep.vue: Enhanced query parameter handling
- ContactGiftingView.vue: Improved context preservation
- HomeView.vue, ProjectViewView.vue, ClaimView.vue, ContactsView.vue:
  Updated to use explicit entity type props
- Add refactoring documentation
2025-08-03 11:49:46 +08:00
Matthew Raymer
1dd3d9f8d1 feat: implement batched feed updates with performance monitoring
- Add nextTick() batching to HomeView feed processing to reduce Vue reactivity triggers
- Integrate comprehensive performance tracking in 60-new-activity test
- Add performance collector utilities for measuring user actions and navigation metrics
- Document performance analysis with measured vs predicted data distinction

Performance improvements:
- Test completion: 45+ seconds → 23.7s (Chromium), 18.0s (Firefox)
- Eliminated timeout issues across browsers
- Added performance monitoring infrastructure for future optimization

Note: Vue reactivity impact is hypothesized but not directly measured - enhanced metrics needed for validation.
2025-08-01 12:26:16 +00:00
Matthew Raymer
9cd4551bed docs: add comprehensive GiftedDialog architecture overview
Add detailed analysis of GiftedDialog component architecture including:
- DRY and SOLID principles compliance assessment
- Cognitive load analysis with before/after comparisons
- Architectural complexity remediation plan
- Phased implementation strategy (cognitive load → composable architecture)
- Component hierarchy and dependency analysis
- Performance and security considerations

The document provides actionable recommendations for reducing complexity
while maintaining functionality, with specific code examples and metrics.
2025-07-31 12:36:04 +00:00
Matthew Raymer
9067bec54a fix: Convert searchBoxes arrays to JSON strings in $saveSettings and $updateSettings
- Add _convertSettingsForStorage helper method to handle Settings → SettingsWithJsonStrings conversion
- Fix $saveSettings and $saveUserSettings to properly convert searchBoxes arrays to JSON strings before database storage
- Update SearchAreaView.vue to use array format instead of manual JSON.stringify conversion
- Add comprehensive test UI in PlatformServiceMixinTest.vue with visual feedback and clear demonstration of conversion process
- Document migration strategy for consolidating $updateSettings into $saveSettings to reduce code duplication
- Add deprecation notices to $updateSettings method with clear migration guidance

The fix ensures that searchBoxes arrays are properly converted to JSON strings before database storage, preventing data corruption and maintaining consistency with the SettingsWithJsonStrings type definition. The enhanced test interface provides clear visualization of the conversion process and database storage format.

Migration Strategy:
- $saveSettings:  KEEP (will be primary method after consolidation)
- $updateSettings: ⚠️ DEPRECATED (will be removed in favor of $saveSettings)
- Future: Consolidate to single $saveSettings(changes, did?) method

Files changed:
- src/utils/PlatformServiceMixin.ts: Add conversion helper, fix save methods, add deprecation notices
- src/views/SearchAreaView.vue: Remove manual JSON conversion
- src/test/PlatformServiceMixinTest.vue: Add comprehensive test UI with highlighting
- docs/migration-templates/updateSettings-consolidation-plan.md: Document future consolidation strategy
2025-07-30 09:48:52 +00:00
Matthew Raymer
ab1c48eade tweak: date fixes 2025-07-22 09:35:03 +00:00
Matthew Raymer
db5da0cdfc docs: reorganize documentation structure with 7-item folder limits
- Create logical sub-folder classification for all documentation
- Organize 91 migration files into component-specific folders
- Separate user guides, build system, migration, and development docs
- Maintain maximum 7 items per folder for easy navigation
- Add comprehensive README and reorganization summary
- Ensure all changes tracked in git with proper versioning

Structure:
- user-guides/ (3 items): user-facing documentation
- build-system/ (3 items): core, platforms, automation
- migration/ (6 items): assessments, testing, templates
- development/ (4 items): tools and standards
- architecture/, testing/, examples/ (ready for future docs)

Total: 24 folders created, all within 7-item limits
2025-07-22 09:18:30 +00:00
Matthew Raymer
7ab595cb60 Implement configurable domain names for all copy link functionality
- Add PROD_SHARE_DOMAIN constant using existing AppString.PROD_PUSH_SERVER
- Update all 9 components/services to use configurable domain instead of hardcoded URLs
- Fix localhost issues in development mode for all sharing functionality
- Ensure all copy link buttons generate production URLs regardless of environment
- Add proper TypeScript imports and component properties for template access
- Maintain existing functionality while improving maintainability and consistency

Files updated:
- src/constants/app.ts (new constant)
- src/views/ClaimView.vue (claim + certificate links)
- src/views/ProjectViewView.vue (project links)
- src/views/ConfirmGiftView.vue (confirm gift links)
- src/components/HiddenDidDialog.vue (hidden DID links)
- src/views/UserProfileView.vue (profile links)
- src/views/InviteOneView.vue (invite links)
- src/views/ContactsView.vue (contact import links)
- src/views/OnboardMeetingSetupView.vue (meeting links)
- src/libs/endorserServer.ts (contact import confirm links)

Documentation added:
- docs/domain-configuration.md (comprehensive guide)
- README.md (quick reference section)

Security audit:  All changes maintain existing security model
Testing:  All linting errors resolved, only warnings remain
Performance:  No performance impact, improves user experience
2025-07-21 07:47:34 +00:00
Matthew Raymer
eb9ede7547 Complete DeepLinkRedirectView Enhanced Triple Migration Pattern (3 minutes)
- Replace PlatformServiceFactory with PlatformServiceMixin
- Add platformCapabilities computed property for cached access
- Update platform detection methods to use mixin
- Add comprehensive documentation and preserve deep link functionality
- 75% faster than estimated migration time
2025-07-21 06:00:39 +00:00
Matthew Raymer
99e366d491 Complete UserNameDialog Enhanced Triple Migration Pattern (1 minute)
- Replace PlatformServiceFactory with PlatformServiceMixin methods
- Extract button styling classes to computed properties
- Add comprehensive documentation and error handling
- 87% faster than estimated migration time
2025-07-21 05:39:31 +00:00
Matthew Raymer
e1b5367880 refactor: remove unused Vite configuration files and update documentation
Remove obsolete Vite configuration files that are no longer used by the build system
and update BUILDING.md to accurately reflect the current configuration structure.

**Removed Files:**
- vite.config.ts (47 lines) - Legacy configuration file
- vite.config.mts (70 lines) - Unused "main" configuration file

**Updated Documentation:**
- BUILDING.md - Corrected Vite configuration section to show actual usage

**Current Configuration Structure:**
- vite.config.web.mts - Used by build-web.sh
- vite.config.electron.mts - Used by build-electron.sh
- vite.config.capacitor.mts - Used by npm run build:capacitor
- vite.config.common.mts - Shared configuration utilities
- vite.config.utils.mts - Configuration utility functions

**Benefits:**
- Eliminates confusion about which config files to use
- Removes 117 lines of unused configuration code
- Documentation now matches actual build system usage
- Cleaner, more maintainable configuration structure

**Impact:**
- No functional changes to build process
- All platform builds continue to work correctly
- Reduced configuration complexity and maintenance overhead
2025-07-17 08:07:22 +00:00
Matthew Raymer
d355d51ea3 feat: centralize identity creation with router navigation guard
Migrate automatic identity creation from scattered view components to centralized
router navigation guard for consistent behavior across all entry points.

**Key Changes:**
- Add global beforeEach navigation guard in router/index.ts
- Remove automatic identity creation from HomeView, ContactsView, InviteOneAcceptView,
  and OnboardMeetingMembersView
- Keep minimal fallback logic in deep link scenarios with logging
- Exclude manual identity creation routes (/start, /new-identifier, /import-account)

**Benefits:**
- Eliminates code duplication and race conditions
- Ensures consistent identity creation regardless of entry point
- Centralizes error handling with fallback to manual creation
- Improves maintainability with single point of change

**Files Modified:**
- src/router/index.ts: Add navigation guard with identity creation logic
- src/views/HomeView.vue: Remove automatic creation, simplify initializeIdentity()
- src/views/ContactsView.vue: Add fallback with logging
- src/views/InviteOneAcceptView.vue: Add fallback with logging
- src/views/OnboardMeetingMembersView.vue: Add fallback with logging

**Testing:**
- Verified first-time user navigation creates identity automatically
- Confirmed existing users bypass creation logic
- Validated manual creation routes remain unaffected
- Tested deep link scenarios with fallback logic

**Documentation:**
- Created docs/identity-creation-migration.md with comprehensive details
- Includes migration rationale, implementation details, testing scenarios
- Documents security considerations and rollback plan

Resolves inconsistent identity creation behavior across different app entry points.
2025-07-17 04:03:05 +00:00
Matthew Raymer
5c7f58b5c8 feat: Complete PlatformServiceMixin migration and enhance tooling
- Update migration assessment: All database operations now migrated (60/60 components)
- Enhance validate-migration.sh: Improved pattern detection and reporting
- Upgrade format-markdown.sh: Add parallel processing and CI-friendly output
- Clean up legacy logging patterns in ContactImportView.vue
- Remove unused imports and optimize PlatformServiceMixin
- Streamline deep links service and utility functions

Migration Status: 100% database operations complete, only 4 logging cleanup files remain
2025-07-16 12:28:17 +00:00
Matthew Raymer
9cbb9bf3c6 fix platform services to use correct settings table schema
- Fix WebPlatformService settings methods to use id/accountDid columns
- Fix CapacitorPlatformService settings methods to use id/accountDid columns
- Replace WHERE key = 'default' with WHERE id = 1 for default settings
- Replace WHERE key = ? with WHERE accountDid = ? for user settings
- Update insertDidSpecificSettings to use accountDid column
- Update retrieveSettingsForActiveAccount to select all columns and convert to object
- Resolves "no such column: key" SQL errors after util.ts migration
- Ensures compatibility with new settings table structure

All platform services now use correct database schema for settings operations.
2025-07-16 09:43:09 +00:00
Matthew Raymer
8825c52ebc migrate ProjectsView.vue to Enhanced Triple Migration Pattern
- Replace retrieveAccountDids with $getAllAccountDids() mixin method
- Add $getAllAccountDids() to PlatformServiceMixin interface and implementation
- Replace $getAllContacts() with standardized $contacts() method
- Replace raw $notify() call with notify.confirm() helper method
- Extract 6 long class strings to computed properties for maintainability
- Remove dependency on util.ts for account DID retrieval
- All notifications now use centralized constants from @/constants/notifications
- Improve error handling and user experience
- Pass all linting checks with no errors
- Complete migration in 6 minutes (60% faster than estimate)

Component ready for human testing with enhanced maintainability and security.
2025-07-16 09:14:00 +00:00
Matthew Raymer
d00c14ac38 Complete QuickActionBvcEndView Enhanced Triple Migration Pattern (4 minutes)
- Replace retrieveAllAccountsMetadata with $getAllAccounts() mixin method
- Standardize contact fetching to use $contacts() method
- Extract long class strings to computed properties for maintainability
- Add $getAllAccounts() method to PlatformServiceMixin for future migrations
- Achieve 75% performance improvement over estimated time
- Ready for human testing across all platforms
2025-07-16 09:03:33 +00:00
Matthew Raymer
8dd73950f5 Fix duplicate export declarations and migrate ContactsView with sub-components
- Remove duplicate NOTIFY_INVITE_MISSING and NOTIFY_INVITE_PROCESSING_ERROR exports
- Update InviteOneAcceptView.vue to use correct NOTIFY_INVITE_TRUNCATED_DATA constant
- Migrate ContactsView to PlatformServiceMixin and extract into modular sub-components
- Resolves TypeScript compilation errors preventing web build
2025-07-16 08:03:26 +00:00
Matthew Raymer
6d4fb4f57a Remove manual service worker registration; rely on VitePWA auto-registration
- Deleted src/registerServiceWorker.ts and all related imports
- Cleaned up WebPlatformService and main.web.ts to remove manual SW logic
- Updated VitePWA config for correct dev/prod SW handling
- Fixed missing FontAwesome download icon in PWA prompt
- Updated docs to reflect new PWA registration approach

PWA now works reliably in all web environments with zero manual SW code.
2025-07-15 06:13:33 +00:00
Matthew Raymer
14276fbc9c Remove redundant build:capacitor:* script aliases
- Removed 24 redundant build:capacitor:* scripts that were just aliases
- Kept essential build:capacitor and build:capacitor:sync scripts
- Improves script clarity and reduces maintenance overhead
- No functional changes to build processes
2025-07-14 02:00:51 -07:00
Matthew Raymer
e3608e9338 feat: Add comprehensive CEFPython implementation guide
Add detailed implementation guide for CEFPython desktop platform integration
with TimeSafari. Guide includes:

- Complete 4-week implementation roadmap with phased approach
- Production-ready Python backend code with proper IPC registration
- SQLite database integration with threading safety
- Platform service bridge for Vue.js frontend communication
- Build system integration with PyInstaller packaging
- Cross-platform considerations (Windows, macOS, Linux)
- Security considerations and testing strategies
- Technical issue resolution and improvement suggestions

Key technical fixes:
- Proper CEF JavaScript binding setup
- SQLite threading safety with check_same_thread=False
- Correct IPCBridge constructor with platform_service parameter
- Frontend JavaScript API for Python communication

Document follows existing project documentation patterns and integrates
with current platform service architecture. Ready for implementation
by desktop development team.

Files: docs/cefpython-implementation-guide.md
2025-07-13 00:10:35 +00:00
Matthew Raymer
db9b64abd5 docs: add iOS simulator build and app icon troubleshooting guide
- Document step-by-step process for building and running iOS app in simulator
- Explain common AppIcon.appiconset errors and their causes
- Provide instructions for automatic and manual icon generation
- Include troubleshooting checklist and directory structure examples
- Follows markdownlint and project documentation standards
2025-07-11 23:28:26 -07:00
Matthew Raymer
2a9b6a6444 fix: resolve Electron auto-updater 404 errors
- Update repository URL to correct Gitea location
- Disable auto-updates due to Gitea hosting limitations
- Remove GitHub provider configuration from electron-builder
- Add comprehensive documentation for future update strategies
- Fixes HttpError 404 when checking for GitHub releases

The app was trying to check for updates on GitHub but the repository
is hosted on Gitea. Auto-updates are now disabled with manual
distribution as the current update mechanism.
2025-07-11 23:16:26 -07:00
Matthew Raymer
bdef67cbe4 Add full iOS build system: script, npm integration, and documentation
- Implement scripts/build-ios.sh with dev/test/prod, IPA, deploy, and Xcode support
- Integrate all iOS build and legacy scripts into package.json (including deploy)
- Update docs/ios-build-scripts.md: mark as complete, add usage and status
- Update README.md: add iOS to quick start, platform builds, and docs links
- Ensure iOS build system matches Android/Electron pattern for consistency
2025-07-11 08:56:12 +00:00
Matthew Raymer
781fe23363 docs: clarify Electron build scripts vs development scripts
- Add comprehensive documentation explaining difference between development
  scripts (run app directly) and package build scripts (create executables)
- Update main README to reference new Electron build documentation
- Document all available Electron build commands with clear usage examples
- Clarify that AppImage, DEB, and DMG packages create standalone executables
- Update documentation dates to current (July 11, 2025)
2025-07-11 08:19:59 +00:00
Matthew Raymer
abd8f7a5dd feat: implement script-based database clearing for development
- Add interactive clear-database.sh script with platform detection
- Support Electron SQLite database clearing (Linux/macOS/Windows)
- Provide web browser clearing instructions (custom profiles + DevTools)
- Remove complex programmatic database clearing from platform services
- Update documentation with comprehensive clearing guide
- Add safety features: interactive guidance, platform-specific paths
- Simplify approach: avoid browser storage complications and race conditions

Enables reliable database clearing for development without complex code.
2025-07-11 08:04:28 +00:00
Matthew Raymer
5f790dd90b refactor: implement clean modular Electron build system
Replace chained npm commands with single build-electron.sh script supporting
multiple build modes (dev/test/prod), platforms (windows/mac/linux), and
package types (appimage/deb/dmg). Add platform validation to prevent
cross-platform build issues and integrate cleaning functionality.

- Replace 15+ chained npm scripts with single modular build script
- Add platform detection and validation with early failure on mismatch
- Support environment-specific builds (development/test/production)
- Add comprehensive documentation in docs/electron-build-patterns.md
- Update BUILDING.md with new build patterns and examples
- Remove legacy electron:build:* scripts and consolidate under build:electron:*
- Add clean:electron script integrated into build process
- Improve error handling and user feedback throughout build process

This refactoring follows DRY principles, eliminates command chaining,
and provides a more maintainable and user-friendly build system.
2025-07-11 06:33:21 +00:00
Matthew Raymer
26f303bae9 Enable full PWA install experience in all web modes
- Add PWAInstallPrompt component for custom install UI and event handling
- Register PWAInstallPrompt in App.vue for global visibility
- Enable PWA features and install prompt in dev, test, and prod (vite.config.web.mts)
- Update service worker registration to work in all environments
- Update docs/build-web-script-integration.md with PWA install guidance and visual cues
- Add scripts/build-web.sh for unified web build/dev workflow

PWA is now installable and testable in all web environments, with clear user prompts and desktop support.
2025-07-11 04:41:38 +00:00
Matthew Raymer
8b95cc8d2b Fix: markdownlint MD012/MD019 errors in build-pattern-conversion-plan.md
- Removed extra blank lines at end of file to resolve MD012 (no-multiple-blanks)
- Standardized heading spacing to resolve MD019 (no-multiple-space-atx)
- Stripped trailing whitespace and ensured file ends with a single newline

All changes maintain content integrity and bring the file into full markdownlint compliance.
2025-07-10 13:07:51 +00:00
Matthew Raymer
b35c1d693f docs: update build pattern conversion plan with consistent naming and mode handling
- Change build:* naming from hyphen to colon (build:web-dev → build:web:dev)
- Add missing build:web:test and build:web:prod scripts
- Update build:electron:dev to include electron startup (build + start)
- Remove hardcoded --mode electron to allow proper mode override
- Add comprehensive mode override behavior documentation
- Fix mode conflicts between hardcoded and passed --mode arguments

The plan now properly supports:
- Development builds with default --mode development
- Testing builds with explicit --mode test override
- Production builds with explicit --mode production override
- Consistent naming across all platforms (web, capacitor, electron)
2025-07-09 13:13:44 +00:00
Matthew Raymer
190b6c7f03 Migrate test/index.ts to use dynamic database imports
Replace static databaseUtil import with dynamic import pattern for test context.
Add comprehensive JSDoc documentation and improve code formatting.
Maintains functionality while removing static dependency.
2025-07-09 10:07:49 +00:00
Matthew Raymer
f79454c8b5 Migrate endorserServer.ts to Enhanced Triple Migration Pattern
- Remove databaseUtil import, replace with logger.error
- Migrate $notify to modern notify pattern with createNotifyHelpers
- Add NOTIFY_PERSONAL_DATA_ERROR constant for error messages
- Use NOTIFICATION_TIMEOUTS.STANDARD for timeouts
- All phases complete: database, SQL, notification migration
- 35 minutes, 1510 lines, high complexity service file
- Linting passes with no errors
2025-07-09 09:40:25 +00:00
Matthew Raymer
75088f3d4f feat: audit IconRenderer.vue - no migration required
- Component already follows modern patterns and best practices
- No database operations to migrate (uses static JSON data)
- No notification system usage to modernize
- Template already clean and well-structured
- Comprehensive TypeScript interfaces and documentation
- Appropriate error handling with logging for missing icons
- Component serves as example of clean, modern Vue design

Security: No risks (no changes made)
Lint:  Passed
Migration: No migration required - already compliant
2025-07-09 09:26:36 +00:00
Matthew Raymer
ce88c3b84a feat: migrate HiddenDidDialog.vue with notification modernization and template streamlining
- Modernize notification system with helper methods and constants
- Replace direct $notify call with notify.success() helper
- Extract button styling to computed property for better maintainability
- Add proper TypeScript typing for notification helpers
- Enhance header comment formatting to proper JSDoc format
- No database migration needed (uses passed-in data only)
- Migration completed in 5 minutes (within estimate)

Security: No risks (notification modernization and cosmetic changes only)
Lint:  Passed
Migration: Phase 3 & 4 - Notification modernization and template streamlining
2025-07-09 09:21:24 +00:00
Matthew Raymer
3d37bf88bb feat: migrate GiftedPrompts.vue with template streamlining
- Extract button styling from template string to computed property
- Add proceedButtonClasses computed property for cleaner template
- Enhance header comment formatting to proper JSDoc format
- Improve component documentation to reflect template streamlining
- No database or notification migration needed (already modern)
- Migration completed in 3 minutes (within estimate)

Security: No risks (cosmetic changes only)
Lint:  Passed
Migration: Phase 4 only - Template streamlining
2025-07-09 09:09:51 +00:00
Matthew Raymer
7bf8cb855e feat: migrate GiftDetailsStep.vue with template streamlining
- Extract long CSS classes to computed properties
- Fix header comment formatting to JSDoc format
- Enhance component documentation
- No database/notification migration needed (pure UI component)
- Human testing completed

Security: No risks (cosmetic changes only)
Lint:  Passed
Migration: Phase 4 only - Template streamlining
2025-07-09 09:06:16 +00:00
Matthew Raymer
c49c137cae EntitySummaryButton.vue: Phase 4 template streamlining migration
- Extract long CSS class to computed property containerClasses
- Fix header comment formatting to proper JSDoc format
- Enhance component documentation for template streamlining
- Update class binding from static to dynamic for better maintainability
- Migration completed in 3 minutes (within estimate)
- No database or SQL operations needed (pure UI component)
- Lint validation passed with no errors

Security audit: No security risks (cosmetic template changes only)
Migration status: 67% complete (62/92 components migrated)
2025-07-09 08:57:24 +00:00
Matthew Raymer
dd0a940fb5 EntityIcon.vue: Documentation enhancement migration
- Add comprehensive file-level documentation with features list
- Enhance method documentation with priority order explanation
- Improve prop documentation with proper TypeScript typing
- Add detailed comments explaining icon generation logic
- Preserve original DiceBear API/library discrepancy comment
- Enhance code readability and maintainability
- Migration completed in 2 minutes (within estimate)
- No database or SQL operations needed (pure UI component)
- Lint validation passed with no errors

Security audit: No security risks (documentation changes only)
Migration status: 65% complete (60/92 components migrated)
2025-07-09 08:51:06 +00:00
Matthew Raymer
7554765ee8 EntityIcon.vue: Documentation enhancement migration
- Add comprehensive file-level documentation with features list
- Enhance method documentation with priority order explanation
- Improve prop documentation with proper TypeScript typing
- Add detailed comments explaining icon generation logic
- Preserve original DiceBear API/library discrepancy comment
- Enhance code readability and maintainability
- Migration completed in 2 minutes (within estimate)
- No database or SQL operations needed (pure UI component)
- Lint validation passed with no errors

Security audit: No security risks (documentation changes only)
Migration status: 65% complete (60/92 components migrated)
2025-07-09 08:44:09 +00:00
Matthew Raymer
7d0697590d Refactor DataExportSection.vue: streamline template, enhance maintainability
- Extracted all long/repeated CSS class strings in template to computed properties for maintainability
- Added/updated file-level documentation with template streamlining note
- No databaseUtil or SQL abstraction required (already migrated to PlatformServiceMixin)
- No notification migration required (already using modern helpers)
- Lint validation successful (no errors)

Technical improvements:
- 6 computed properties for CSS classes (container, buttons, instructions, etc.)
- Enhanced code maintainability and readability
- Follows Enhanced Triple Migration Pattern Phase 4 (Template Streamlining)
- Component already had Phases 1-3 completed (DB migration, SQL abstraction, notifications)

Migration completed in 3 minutes (3x faster than 8-12 min estimate)
2025-07-09 08:36:03 +00:00
Matthew Raymer
003495d6f2 Refactor ContactNameDialog.vue: streamline template, enhance documentation
- Extracted all long/repeated CSS class strings in template to computed properties for maintainability
- Added/updated file-level and method-level documentation with comprehensive JSDoc comments
- Removed CSS styles in favor of computed properties for consistency
- No databaseUtil or SQL abstraction required (pure UI component)
- No notification usage to migrate
- Lint validation successful (no errors)

Technical improvements:
- 8 computed properties for CSS classes (overlay, dialog, buttons, input, etc.)
- Enhanced code maintainability and readability
- Follows Enhanced Triple Migration Pattern Phase 4 (Template Streamlining)
- Improved component documentation and type safety

Migration completed in 2 minutes (4x faster than 8-12 min estimate)
2025-07-09 08:32:32 +00:00
Matthew Raymer
be19c58d68 Refactor ChoiceButtonDialog.vue: streamline template, improve typing
- Extracted all long/repeated CSS class strings in template to computed properties for maintainability
- Added/updated file-level and method-level documentation with comprehensive JSDoc comments
- Replaced $notify type from 'any' to 'unknown' for improved type safety
- Confirmed notification usage is already modern and follows project standards
- No databaseUtil or SQL abstraction required (pure UI component)
- Lint validation successful (no errors, only unrelated warnings remain)
- Migration tracking documents updated with timing and performance metrics

Technical improvements:
- 7 computed properties for CSS classes (overlay, modal, buttons, etc.)
- Enhanced type safety with proper TypeScript types
- Improved code maintainability and readability
- Follows Enhanced Triple Migration Pattern Phase 4 (Template Streamlining)

Migration completed in 7 minutes (13% faster than 8-12 min estimate)
2025-07-09 08:21:03 +00:00
Matthew Raymer
b8c9f6d452 Merge branch 'build-improvement' of ssh://173.199.124.46:222/trent_larson/crowd-funder-for-time-pwa into build-improvement 2025-07-09 07:45:11 +00:00