A couple small fixes, plus a merge from master #1

Merged
jsnbuchanan merged 45 commits from trentlarson/crowd-funder-from-jason:feat/vitejs-trent into feat/vitejs 2024-04-07 17:52:43 +00:00
Contributor

This includes the following tiny fixes:

All the rest of the changes are due to a merge from master from the original repo. (I did this as a merge instead of a rebase, mostly because I've been experimenting.)

I'm open to other approaches, eg. rebasing, or pulling into your repo from master (which requires some permissions to me), or... whatever.

The only remaining task before merging is to deploy this to my test server and put it through the paces (which I'll do today), but I expect no issues since npm run build and npm run serve already worked.

This includes the following tiny fixes: * a [fix for the contact-download](https://gitea.anomalistdesign.com/trentlarson/crowd-funder-from-jason/commit/0fbd1ad51a9b383b9935b62868d0d354b5985bf4) * a [change to avoid an on-screen error on localhost](https://gitea.anomalistdesign.com/trentlarson/crowd-funder-from-jason/commit/2ae165d56fb9decbeb608872e06896e00abc6731) * a [change to avoid a console error in a common case](https://gitea.anomalistdesign.com/trentlarson/crowd-funder-from-jason/commit/78fab735e6bb331f0e3b7554bbc7edcefeda1f39) All the rest of the changes are due to a merge from master from the original repo. (I did this as a merge instead of a rebase, mostly because I've been experimenting.) I'm open to other approaches, eg. rebasing, or pulling into your repo from master (which requires some permissions to me), or... whatever. The only remaining task before merging is to deploy this to my test server and put it through the paces (which I'll do today), but I expect no issues since `npm run build` and `npm run serve` already worked.
trentlarson added 41 commits 2024-04-07 15:50:39 +00:00
Reviewed-on: trent_larson/crowd-funder-for-time-pwa#108
Reviewed-on: trent_larson/crowd-funder-for-time-pwa#109
For buttons that are next to each other
Reviewed-on: trent_larson/crowd-funder-for-time-pwa#111
Reviewed-on: trent_larson/crowd-funder-for-time-pwa#112
Reviewed-on: trent_larson/crowd-funder-for-time-pwa#113
trentlarson added 1 commit 2024-04-07 17:02:26 +00:00
Author
Contributor

OK, I added some linting fixes.

Note that I changed the default to report lint errors and not fix them, with a separate command to fix them. (I don't mind making "fix" the default as long as we have some command that only reports.)

OK, I added some linting fixes. Note that I changed the default to report lint errors and not fix them, with a separate command to fix them. (I don't mind making "fix" the default as long as we have some command that only reports.)
trentlarson added 1 commit 2024-04-07 17:21:49 +00:00
trentlarson added 1 commit 2024-04-07 17:32:04 +00:00
trentlarson added 1 commit 2024-04-07 17:39:07 +00:00
jsnbuchanan merged commit 333ac773f6 into feat/vitejs 2024-04-07 17:52:43 +00:00
Author
Contributor

Houston, we have a problem: the vite.config.js is not fully applied on npm run build: the Help page doesn't show a git hash and the sw_scripts-combined.js file is not created and copied into the dist directory.

Houston, we have a problem: the vite.config.js is not fully applied on `npm run build`: the Help page doesn't show a git hash and the sw_scripts-combined.js file is not created and copied into the dist directory.
Sign in to join this conversation.
No Reviewers
No Label
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: jsnbuchanan/crowd-funder-for-time-pwa#1