Convert JSON storage to SQLite #3

jose · 2026-07-24T13:10:54Z

jose commented

2026-07-24 13:10:54 +00:00

No description provided.

jose added 6 commits 2026-07-24 13:10:54 +00:00

feat(db): add SQLite foundation for FCM registration storage fa8ab86cdb

Introduce better-sqlite3 and a schema-init module so we can migrate off JSON storage without changing runtime behavior yet.

feat(db): add SQLite FCM registration repository 5a3c22a4e3

Mirror the JSON repository API on SQLite without switching callers; clarify that SQLite is the storage backend and there is no JSON data migration.

feat(db): switch runtime storage to SQLite repository 11bd45b460

Point routes, scheduler, and push service at fcmTokensSqlite so the service no longer reads or writes the JSON store.

perf(db): tighten SQLite FCM registration queries e79d55fac6

Drop the upsert pre-read, project only needed columns, and add a (user_id, fcm_token) index for token lookups and dedupe deletes.

chore(db): remove obsolete JSON FCM token repository ddb969c26d

Delete the unused JSON storage implementation now that SQLite is the sole persistence backend.

docs: document SQLite storage for FCM registrations 06ec0f63e4

Update README and .env.example for the SQLite database location, schema overview, backup/WAL notes, and clarify that JSON data is not migrated.

trentlarson reviewed 2026-07-25 23:08:21 +00:00

src/db/sqlite.ts Outdated

						
				@@ -0,0 +4,4 @@

				const dataDir =

				  process.env.FCM_TOKEN_DATA_DIR ?? path.join(process.cwd(), "data");

				const dbFile = path.join(dataDir, "fcm-tokens.sqlite");

trentlarson commented

2026-07-25 23:08:21 +00:00

Let's make this DB a generic name for all wakeup notification purposes, eg. "notify.sqlite"

jose commented

2026-07-27 10:47:44 +00:00

I renamed the database file accordingly.

I asked AI about also changing the name to FCM_TOKEN_DATA_DIR (as a what-if), and it brought up good points for and against. I'm curious what your thoughts are on it?

I renamed the database file accordingly. I asked AI about also changing the name to FCM_TOKEN_DATA_DIR (as a what-if), and it brought up good points for and against. I'm curious what your thoughts are on it?

trentlarson commented

2026-07-28 03:13:48 +00:00

I'm not clear on that... it sounds like you are saying that it would be "FCM_TOKEN_DATA_DIR.sqlite", but it seems odd to put a "_DIR" name on the file.

Maybe you mean to have another environment variable like FCM_TOKEN_DATA_FILENAME, so the full change would be something like this:

const dataDir = process.env.FCM_TOKEN_DATA_DIR ?? path.join(process.cwd(), "data");
const fileName = (process.env.FCM_TOKEN_DATA_FILENAME ?? "notify") + ".sqlite";
const dbFile = path.join(dataDir, fileName);

That seems reasonable, but my feeling is that it adds some complexity (eg. if people name it something else then the file is harder to find) and it doesn't seem like the benefit of flexibility is worth it.

Or maybe you meant something else.

I'm not clear on that... it sounds like you are saying that it would be "FCM_TOKEN_DATA_DIR.sqlite", but it seems odd to put a "_DIR" name on the file. Maybe you mean to have another environment variable like FCM_TOKEN_DATA_FILENAME, so the full change would be something like this: ``` const dataDir = process.env.FCM_TOKEN_DATA_DIR ?? path.join(process.cwd(), "data"); const fileName = (process.env.FCM_TOKEN_DATA_FILENAME ?? "notify") + ".sqlite"; const dbFile = path.join(dataDir, fileName); ``` That seems reasonable, but my feeling is that it adds some complexity (eg. if people name it something else then the file is harder to find) and it doesn't seem like the benefit of flexibility is worth it. Or maybe you meant something else.

jose commented

2026-07-28 06:45:59 +00:00

Ahh sorry, I bungled the wording on that last reply. I meant "…changing the name of FCM_TOKEN_DATA_DIR" (the name of the environment variable that specifies the directory where notify.sqlite resides).

Ahh sorry, I bungled the wording on that last reply. I meant _"…changing the name **of** FCM_TOKEN_DATA_DIR"_ (the name of the environment variable that specifies the directory where notify.sqlite resides).

jose added 1 commit 2026-07-27 08:54:04 +00:00

chore(db): rename SQLite database file to notify.sqlite 9e6597638e

Use a generic database filename for future notification-related storage, and update docs and env comments to match.

jose merged commit d8989f587e into master

2026-07-29 11:40:59 +00:00

jose referenced this issue from a commit

2026-07-29 11:41:01 +00:00

Merge pull request 'Convert JSON storage to SQLite' (#3) from sqlite-storage into master

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: trent_larson/notification-wakeup-service#3