trent_larson
/
crowd-funder-for-time-pwa
4
1
Fork 2
Code Pull Requests 4 Releases 5 Wiki Activity
Labels Milestones

Added gatekeeping dialogs for PWA install requirement #71

Open
jose wants to merge 1 commits from friend-tech-inspired-pwa-dialog into master
Conversation 3 Commits 1 Files Changed 2
jose commented 1 year ago
Owner
There is no content yet.
jose added 1 commit 1 year ago
trentlarson commented 1 year ago
Owner

This makes sense. I'd like to understand how the pwa-install-gate-* flags are set.

Note that we'd like to make this an optional step, such that they can still interact even if they're not installed on the desktop. Is this allowed with this setup?

This makes sense. I'd like to understand how the pwa-install-gate-* flags are set. Note that we'd like to make this an optional step, such that they can still interact even if they're not installed on the desktop. Is this allowed with this setup?
trentlarson commented 10 months ago
Owner

Jose says: "maybe we can change the wording on the dialog to indicate a "soft requirement", and only trigger it where appropriate"

Jose says: "maybe we can change the wording on the dialog to indicate a "soft requirement", and only trigger it where appropriate"
trentlarson commented 10 months ago
Owner

The flags were not straightforward. I ended up inserting some UI for this in the HomePage here.

You can see that it's a check for notification support, because I found that there was no trustworthy flags to use to see if the app was installed, at least on iOS. I have some potential Android checks documented here.

I'd also like to put this front-and-center, but not in a way that they have to close a pop-up to get around it. Maybe there's a better way.

So... I'd love to see better approaches. If there is a different workflow & set of logic that works better, let's discuss it.

The flags were not straightforward. I ended up inserting some UI for this [in the HomePage here](https://gitea.anomalistdesign.com/trent_larson/crowd-funder-for-time-pwa/src/branch/master/src/views/HomeView.vue#L14). You can see that it's a check for notification support, because I found that there was no trustworthy flags to use to see if the app was installed, at least on iOS. I have some potential Android checks documented [here](https://gitea.anomalistdesign.com/trent_larson/crowd-funder-for-time-pwa/src/branch/master/project.task.yaml#L71). I'd also like to put this front-and-center, but not in a way that they have to close a pop-up to get around it. Maybe there's a better way. So... I'd love to see better approaches. If there is a different workflow & set of logic that works better, let's discuss it.
This pull request has changes conflicting with the target branch.
src/main.ts
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
No items
No Label
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'friend-tech-inspired-pwa-dialog'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes