bulk-members-dialog-refactor

Conversation 0 Commits 2 Files Changed 2

jose commented 1 day ago

Owner

ClickUp: https://app.clickup.com/t/86b79j4fr

jose added 2 commits 1 day ago

8b199ec76c refactor: remove redundant dialogType prop from BulkMembersDialog

Remove dialogType prop and consolidate to use only isOrganizer prop.

- Remove dialogType prop from BulkMembersDialog component
- Replace all dialogType checks with isOrganizer boolean checks
- Add comments clarifying isOrganizer true/false meanings
- Remove dialog-type prop binding from MembersList component

This simplifies the component API while maintaining the same functionality.

c06ffec466 refactor: combine member processing methods in BulkMembersDialog

Consolidate organizerAdmitAndAddWithVisibility() and
memberAddContactWithVisibility() into a single unified method
processSelectedMembers() that handles both organizer and member
modes based on the isOrganizer prop.

- Remove redundant handleMainAction() wrapper method
- Update template to call processSelectedMembers directly
- Reduce code duplication by ~30% (140 lines → 98 lines)
- Maintain identical functionality for both modes

This simplifies the component structure and makes the processing
logic easier to maintain.

jose merged commit 1053bb6e4c into master 11 hours ago

jose referenced this issue from a commit 11 hours ago

Merge pull request 'bulk-members-dialog-refactor' (#218) from bulk-members-dialog-refactor into master

The pull request has been merged as 1053bb6e4c.

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No Assignees

1 Participants

Notifications

Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

bulk-members-dialog-refactor #218