trent_larson/crowd-funder-for-time-pwa
4
1
Fork 2
Code Issues Pull Requests 22 Releases 5 Wiki Activity

Meeting Members Admission -- skipping directly to master #212

Closed
trentlarson wants to merge 0 commits from meeting-members-admission-dialog-refactor into master
pull from: meeting-members-admission-dialog-refactor
merge into: trent_larson:master
Conversation 1 Commits - Files Changed -
trentlarson commented 2025-10-26 20:17:20 +00:00
Owner
Copy Link

This is to see a complete set of changes for the latest meeting-members-admission-dialog-refactor branch directly to production. It is provided as a reference so that we can see the full set of changes compared to master; may not be worth keeping.

This is to see a complete set of changes for the latest `meeting-members-admission-dialog-refactor` branch directly to production. It is provided as a reference so that we can see the full set of changes compared to master; may not be worth keeping.
trentlarson added 15 commits 2025-10-26 20:17:20 +00:00
feat: enhance members list UI with visual indicators and improved styling e9ea89edae 
- Sort members list with organizer first, then non-admitted, then admitted
- Add crown icon for meeting organizer identification
- Add spinner icon for non-admitted members
- Implement conditional styling for non-admitted members
- Update button styling to use circle icons instead of rounded backgrounds
- Improve visual hierarchy with better spacing and color coding
feat: change icon for pending members 035509224b 
- Changed from an animating spinner to a static hourglass
feat: Add AdmitPendingMembersDialog for bulk member admission 6fbc9c2a5b 
- Add new AdmitPendingMembersDialog component with checkbox selection
- Support two action modes: "Admit + Add Contacts" and "Admit Only"
- Integrate dialog into MembersList with proper sequencing
- Show admit dialog before visibility dialog when pending members exist
- Fix auto-refresh pause/resume logic for both dialogs
- Ensure consistent dialog behavior between initial load and manual refresh
- Add proper async/await handling for data refresh operations
- Optimize dialog state management and remove redundant code
- Maintain proper flag timing to prevent race conditions

The admit dialog now shows automatically when there are pending members,
allowing organizers to efficiently admit multiple members at once while
optionally adding them as contacts and setting visibility preferences.
Update AdmitPendingMembersDialog.vue ad51c187aa 
feat: add DID display to Pending Members dialog

- Restructure member display with better visual hierarchy
- Add DID display with responsive truncation for mobile
- Simplify button labels ("Admit + Add Contacts" and "Admit Only")
feat: restrict dialog access based on user roles 16ed5131c4 
- AdmitPendingMembersDialog now only triggers for meeting organizers
- SetBulkVisibilityDialog now only triggers for members who can see other members
- Removes overly restrictive admission status check for visibility dialog
- Ensures proper role-based access control for meeting management features
fix: restrict pending member styling to organizers only e048e4c86b 
- Apply special styling (blue background, grayed text, hourglass icon) only when current user is organizer
- Non-organizers now see consistent styling for all visible members
- Maintains organizer's ability to distinguish between admitted and pending members
- Fixes issue where non-organizers saw inconsistent styling for all members
fix: resolve duplicate names in Visibility dialog after Admit dialog 2f1eeb6700 
- Add deduplication logic to getMembersForVisibility() method to prevent duplicate entries
- Fix timing issue with isManualRefresh flag reset in showSetBulkVisibilityDialog()
- Ensure Visibility dialog shows each member only once when following Admit dialog
- Remove debugging console logs after issue resolution

The issue was caused by multiple calls to getMembersForVisibility() returning
duplicate member entries, which were then displayed in the Visibility dialog.
The fix deduplicates members by DID to ensure each member appears only once.
chore: move a variable into most local scope f0f0f1681e
refactor: simplify logic for opening onboarding dialogs 7ea6a2ef69
fix: linting 39173a8db2
test: trying the new pre-commit logic (with a bad linting change) 9f3c62a29c
fix: linting 9a94843b68
feat: prompt user if the pre-commit lint-fix changed anything 723a0095a0
refactor: make the meeting member "set visibility" screen much like the organizer's "admit" screen 9e1c267bc0
fix: linting 5c0ce2d1fb
trentlarson added 1 commit 2025-10-26 20:34:47 +00:00
refactor: remove mistakenly-committed file e8e00d3eae
trentlarson closed this pull request 2025-11-03 15:07:43 +00:00
trentlarson commented 2025-11-03 15:08:01 +00:00
Author
Owner
Copy Link

Jose merged his version.

Jose merged his version.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
anomalist jose jsnbuchanan kentbull trentlarson
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: trent_larson/crowd-funder-for-time-pwa#212
Delete Branch "meeting-members-admission-dialog-refactor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?