trent_larson/crowd-funder-for-time-pwa
4
1
Fork 2
Code Issues Pull Requests 22 Releases 5 Wiki Activity

feat: meeting members admission dialog #210

Merged
jose merged 27 commits from meeting-members-admission-dialog into master 2025-10-30 13:58:18 +00:00
Conversation 1 Commits 27 Files Changed 8 +598 -388
jose commented 2025-10-23 13:47:47 +00:00
Owner
Copy Link

ClickUp: https://app.clickup.com/t/86b75mhhn

ClickUp: https://app.clickup.com/t/86b75mhhn
jose added 4 commits 2025-10-23 13:47:47 +00:00
feat: enhance members list UI with visual indicators and improved styling e9ea89edae 
- Sort members list with organizer first, then non-admitted, then admitted
- Add crown icon for meeting organizer identification
- Add spinner icon for non-admitted members
- Implement conditional styling for non-admitted members
- Update button styling to use circle icons instead of rounded backgrounds
- Improve visual hierarchy with better spacing and color coding
feat: change icon for pending members 035509224b 
- Changed from an animating spinner to a static hourglass
feat: Add AdmitPendingMembersDialog for bulk member admission 6fbc9c2a5b 
- Add new AdmitPendingMembersDialog component with checkbox selection
- Support two action modes: "Admit + Add Contacts" and "Admit Only"
- Integrate dialog into MembersList with proper sequencing
- Show admit dialog before visibility dialog when pending members exist
- Fix auto-refresh pause/resume logic for both dialogs
- Ensure consistent dialog behavior between initial load and manual refresh
- Add proper async/await handling for data refresh operations
- Optimize dialog state management and remove redundant code
- Maintain proper flag timing to prevent race conditions

The admit dialog now shows automatically when there are pending members,
allowing organizers to efficiently admit multiple members at once while
optionally adding them as contacts and setting visibility preferences.
Update AdmitPendingMembersDialog.vue ad51c187aa 
feat: add DID display to Pending Members dialog

- Restructure member display with better visual hierarchy
- Add DID display with responsive truncation for mobile
- Simplify button labels ("Admit + Add Contacts" and "Admit Only")
jose changed title from meeting-members-admission-dialog to feat: meeting members admission dialog 2025-10-23 13:48:20 +00:00
trentlarson reviewed 2025-10-24 00:35:44 +00:00
src/components/MembersList.vue Outdated
@@ -392,0 +464,4 @@
// If admission status is the same, maintain original order
return 0;
});
trentlarson commented 2025-10-24 00:35:44 +00:00
Owner
Copy Link

Nice touch to sort the items!

Nice touch to sort the items!
jose added 3 commits 2025-10-24 09:31:53 +00:00
feat: restrict dialog access based on user roles 16ed5131c4 
- AdmitPendingMembersDialog now only triggers for meeting organizers
- SetBulkVisibilityDialog now only triggers for members who can see other members
- Removes overly restrictive admission status check for visibility dialog
- Ensures proper role-based access control for meeting management features
fix: restrict pending member styling to organizers only e048e4c86b 
- Apply special styling (blue background, grayed text, hourglass icon) only when current user is organizer
- Non-organizers now see consistent styling for all visible members
- Maintains organizer's ability to distinguish between admitted and pending members
- Fixes issue where non-organizers saw inconsistent styling for all members
fix: resolve duplicate names in Visibility dialog after Admit dialog 2f1eeb6700 
- Add deduplication logic to getMembersForVisibility() method to prevent duplicate entries
- Fix timing issue with isManualRefresh flag reset in showSetBulkVisibilityDialog()
- Ensure Visibility dialog shows each member only once when following Admit dialog
- Remove debugging console logs after issue resolution

The issue was caused by multiple calls to getMembersForVisibility() returning
duplicate member entries, which were then displayed in the Visibility dialog.
The fix deduplicates members by DID to ensure each member appears only once.
jose changed title from feat: meeting members admission dialog to WIP: feat: meeting members admission dialog 2025-10-24 10:24:34 +00:00
jose added 9 commits 2025-10-27 11:42:32 +00:00
chore: move a variable into most local scope f0f0f1681e
refactor: simplify logic for opening onboarding dialogs 7ea6a2ef69
fix: linting 39173a8db2
test: trying the new pre-commit logic (with a bad linting change) 9f3c62a29c
fix: linting 9a94843b68
feat: prompt user if the pre-commit lint-fix changed anything 723a0095a0
refactor: make the meeting member "set visibility" screen much like the organizer's "admit" screen 9e1c267bc0
fix: linting 5c0ce2d1fb
refactor: remove mistakenly-committed file e8e00d3eae
jose added 1 commit 2025-10-28 08:00:06 +00:00
refactor: migrate dialog styles from scoped CSS to Tailwind utilities 1e3ecf6d0f 
- Remove scoped CSS styles for .dialog-overlay and .dialog from AdmitPendingMembersDialog.vue
- Remove scoped CSS overflow style from FeedFilters.vue dialog
- Update Tailwind .dialog utility class to include max-height and overflow-y-auto
- Consolidate dialog styling into reusable Tailwind components for consistency
jose added 1 commit 2025-10-28 09:22:01 +00:00
feat: improve auto-refresh handling during member admission dialogs 27e38f583b 
- Add stopAutoRefresh() calls before showing confirmation dialogs
- Add startAutoRefresh() calls after dialog interactions complete
- Ensure auto-refresh resumes properly in all dialog callback paths
- Fix missing onCancel handler for contact confirmation dialog

This prevents auto-refresh from interfering with user interactions
during member admission workflows while ensuring it resumes afterward.
jose added 1 commit 2025-10-28 09:34:18 +00:00
refactor: simplify pending members dialog description text 966ca8276d 
- Replace verbose explanation with concise, direct question
- Streamline the admission dialog interface
jose added 1 commit 2025-10-28 10:44:37 +00:00
refactor: optimize success message logic in AdmitPendingMembersDialog 8100ee5be4 
- Simplify success message generation using ternary operators
- Remove visibilitySetCount due to its implied nature
- Handle case when contactAddedCount is 0 by omitting contact-related text
- Use more compact logic that only applies ternaries to variable parts
- Maintain proper pluralization for both admitted members and contacts

The message now shows:
- "n member/s admitted." when no contacts added
- "n member/s admitted and added as contact/s." when counts equal
- "n member/s admitted, n added as contact/s." when counts differ
jose added 1 commit 2025-10-28 10:58:41 +00:00
feat: hide contact instruction when no non-contact members exist 562713d5a4 
- Add condition to only show "add to contacts" instruction when there are members who are not already contacts
- Use existing getNonContactMembers() method to check for non-contact members
- Fix line length warning by breaking long comment into multiple lines
jose added 1 commit 2025-10-28 13:05:06 +00:00
fix: resolve admission status styling issues for non-organizers in MembersList bfc2f07326 
- Fix undefined admitted property for non-organizers by defaulting to true
- Update conditional styling logic to show blue background for non-admitted current user
- Add hand icon indicator for current user in members list
- Improve sorting to prioritize current user after organizer
- Refactor currentUserInList variable inline for cleaner code
- Update text color and hourglass icon conditions to include current user

The server was returning undefined for the admitted property when non-organizers
viewed the members list, causing incorrect styling. Non-organizers now properly
see their admission status and get appropriate visual indicators.
jose added 1 commit 2025-10-29 07:18:58 +00:00
fix: resolve PostCSS parsing error in FeedFilters.vue ca7ead224b 
- Add missing <style scoped> section to FeedFilters.vue to fix PostCSS error

The PostCSS error was occurring because Vue single-file components require
a <style> section, even if empty, for proper CSS processing.
jose added 1 commit 2025-10-29 07:24:35 +00:00
feat: add "Select All" footer to member selection dialogs 7b87ab2a5c 
- Add tfoot with "Select All" checkbox to AdmitPendingMembersDialog
- Add tfoot with "Select All" checkbox to SetBulkVisibilityDialog
- Both footer checkboxes sync with header checkboxes for consistent UX
- Users can now select/deselect all members from top or bottom of table
jose added 1 commit 2025-10-29 13:46:00 +00:00
refactor: unify member dialogs into reusable BulkMembersDialog component b37051f25d 
- Merge AdmitPendingMembersDialog and SetBulkVisibilityDialog into single BulkMembersDialog
- Add dynamic props for dialog type, title, description, button text, and empty state
- Support both 'admit' and 'visibility' modes with conditional behavior
- Rename setVisibilityForSelectedMembers to addContactWithVisibility for clarity
- Update success counting to track contacts added vs visibility set
- Improve error messages to reflect primary action of adding contacts
- Update MembersList to use unified dialog with role-based configuration
- Remove unused libsUtil import from MembersList
- Update comments and method names to reflect unified functionality
- Rename closeMemberSelectionDialogCallback to closeBulkMembersDialogCallback

This consolidation eliminates ~200 lines of duplicate code while maintaining
all existing functionality and improving maintainability through a single
source of truth for bulk member operations.
jose added 1 commit 2025-10-30 08:11:43 +00:00
refactor: move display text logic to BulkMembersDialog component 9628d5c8c6 
- Replace individual text props with single isOrganizer boolean prop
- Add computed properties for title, description, buttonText, and emptyStateText
- Simplify parent component interface by removing text prop passing
- Update quote style from single to double quotes for consistency
- Improve component encapsulation and maintainability
jose changed title from WIP: feat: meeting members admission dialog to feat: meeting members admission dialog 2025-10-30 13:46:47 +00:00
jose added 1 commit 2025-10-30 13:56:27 +00:00
Merge branch 'master' into meeting-members-admission-dialog d7db7731cf
jose merged commit 4b1a724246 into master 2025-10-30 13:58:18 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
trentlarson
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
anomalist jose jsnbuchanan kentbull trentlarson
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: trent_larson/crowd-funder-for-time-pwa#210
Delete Branch "meeting-members-admission-dialog"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?