trent_larson
/
crowd-funder-for-time-pwa
4
1
Fork 2
Code Issues Pull Requests 17 Releases 5 Wiki Activity
Labels Milestones

refactor: standardize view headings across all components #207

Merged
jose merged 6 commits from view-headings-refresh into master 4 days ago
Conversation 2 Commits 6 Files Changed 51
jose commented 1 week ago
Owner
  • Add consistent view heading IDs and structure
  • Add consistent help buttons and back navigation
  • Improve spacing and typography consistency
- Add consistent view heading IDs and structure - Add consistent help buttons and back navigation - Improve spacing and typography consistency
jose added 3 commits 1 week ago
be8230d046 refactor: standardize view headings across all components
trentlarson reviewed 1 week ago
src/views/AccountViewView.vue Outdated
<template>
<QuickNav selected="Profile" />
<TopMessage />
trentlarson commented 1 week ago
Poster
Owner

Is there a reason this is removed? (You can see what it should show if you go to the Profile page, then Advanced, then turn on either of the "Show warning" toggles.) It's removed from many files.

I don't mind if we have to reconsider how we show that warning, but I think it's still useful. Explain more if you think we should totally get rid of it.

Is there a reason this is removed? (You can see what it should show if you go to the Profile page, then Advanced, then turn on either of the "Show warning" toggles.) It's removed from many files. I don't mind if we have to reconsider how we show that warning, but I think it's still useful. Explain more if you think we should totally get rid of it.
jose commented 5 days ago
Poster
Owner

Ahh, my bad. I should've only removed the help button from TopMessage. But now that you mention it, I should relocate the message itself to the inside of #Content for proper positioning, andgive it a bit of styling. I'll rectify this shortly.

Ahh, my bad. I should've only removed the help button from `TopMessage`. But now that you mention it, I should relocate the message itself to the inside of `#Content` for proper positioning, andgive it a bit of styling. I'll rectify this shortly.
jose added 1 commit 5 days ago
756688bf75 feat: restored TopMessage
jose commented 5 days ago
Poster
Owner

I brought back the TopMessage tag, but in a different location so I could more easily position it in relation to the rest of the content. I also styled it similar to warning blocks elsewhere in the UI.

I brought back the TopMessage tag, but in a different location so I could more easily position it in relation to the rest of the content. I also styled it similar to warning blocks elsewhere in the UI.
trentlarson commented 5 days ago
Owner

Great!

Great!
jose added 2 commits 4 days ago
jose merged commit d9f9460be7 into master 4 days ago
The pull request has been merged as d9f9460be7.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
No items
No Label
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'view-headings-refresh'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes