Labels Milestones

feat(NewActivityView): enhance "See all" links to mark offers as read before navigation #198

Open

jose wants to merge 4 commits from new-activity-mark-read into master

pull from: new-activity-mark-read

merge into: trent_larson:master

trent_larson:account-import-duplicate-prevention

trent_larson:active_did_redux

trent_larson:activedid_migration

trent_larson:ai-context

trent_larson:android-15-check

trent_larson:android-file-save

trent_larson:android-safe-area-insets

trent_larson:app_id_fix

trent_larson:ask-for-contacts-export

trent_larson:build-dev-to-dist

trent_larson:build-improvement

trent_larson:build-ios

trent_larson:build-web-serve-test

trent_larson:build-with-env

trent_larson:capacitor-local-save

trent_larson:claim-view-error-handling

trent_larson:claimview-fullfills-offer

trent_larson:contact-gifting-current-user

trent_larson:contacts-view-fixes

trent_larson:cross-platform-factory

trent_larson:cross-platform-factory-redux

trent_larson:d9085ced6df7dc7bdcd899959cea6489cab7f8b8

trent_larson:db-backup-cross-platform

trent_larson:deep-link

trent_larson:deep-link-views-safe-area-inset

trent_larson:deep-links-android-update

trent_larson:deep_linking

trent_larson:design-tweaks-2023-12

trent_larson:dialog-notification-z-index

trent_larson:dialog-styles-unified

trent_larson:didview-invalid-did-handling

trent_larson:electron-build-capacitor-config

trent_larson:electron-build-config-overwrite

trent_larson:electron-copy-paste-keyboard-shortcuts

trent_larson:electron_fix_20250317

trent_larson:experimental_plugin

trent_larson:eye-slash

trent_larson:fix-contact-import-export

trent_larson:fix-deep-link

trent_larson:fix-service-worker

trent_larson:friend-tech-inspired-pwa-dialog

trent_larson:get-get-hash

trent_larson:gifting-periphery-improvements

trent_larson:gifting-ui-2025-05

trent_larson:home-icon-enhancements

trent_larson:home-view-notification-improvements

trent_larson:homeview-cleanup-2025-03

trent_larson:homeview-refresh-2025-02

trent_larson:imagemagick-anrdoid

trent_larson:ios-contact-copy

trent_larson:ios-qr-code-copy

trent_larson:load-build-mode-env-file

trent_larson:logger-level

trent_larson:logging-upgrade

trent_larson:main

trent_larson:master

trent_larson:master-patch

trent_larson:master-settings-upgrade

trent_larson:matthew-scratch-2025-06-28

trent_larson:migrate-dexie-to-sqlite

trent_larson:nearby-filter

trent_larson:new-storage

trent_larson:nostr

trent_larson:notification-line-wrapping

trent_larson:notification-request-permission-dialog

trent_larson:notification-section

trent_larson:notification-system

trent_larson:notify-initialization-fix

trent_larson:notify-time

trent_larson:offer-edit

trent_larson:offer-validation-logic

trent_larson:onboard-alert-component

trent_larson:onboarding-dialog-fix

trent_larson:passkey

trent_larson:passkey-cache

trent_larson:performance-optimizations-testing

trent_larson:photo-reverse

trent_larson:plan-loc

trent_larson:platformservicemixin-interface-consolidation

trent_larson:playwright-pwa-install-test

trent_larson:playwright-test-00-fix

trent_larson:playwright-test-60-fix

trent_larson:playwright-test-updates

trent_larson:profile-pic

trent_larson:profile_include_location

trent_larson:project-gives

trent_larson:projectview-hide-offer-link-unregistered

trent_larson:qrcode-capacitor

trent_larson:registration-gate

trent_larson:registration-prompt-parity

trent_larson:remove-image-cache

trent_larson:replace-iconrenderer

trent_larson:search-map-fix

trent_larson:seed-phrase-backup-prompt

trent_larson:side_step

trent_larson:simple-signer

trent_larson:split_build_process

trent_larson:sql-absurd-sql

trent_larson:sql-absurd-sql-further

trent_larson:sql-wa-sqlite

trent_larson:star-projects

trent_larson:starred-projects

trent_larson:streamline-attempt

trent_larson:sw-cleanup

trent_larson:switching-identities-change-name

trent_larson:tmp

trent_larson:trent-tweaks

trent_larson:tweaks

trent_larson:ui-fixes-2024-03

trent_larson:ui-fixes-2025-03

trent_larson:ui-fixes-2025-06-w2

trent_larson:units-mocking

trent_larson:v-onboarding-2024-04

trent_larson:vite-version

trent_larson:web-serve-fix

trent_larson:web-tests

trent_larson:wip_new_notifications

Conversation 1 Commits 4 Files Changed 6

jose commented 1 week ago

Owner

• Replace router-links with click handlers for both "See all" offers links
• Add handleSeeAllOffersToUser and handleSeeAllOffersToUserProjects methods
• Modify expandOffersToUserAndMarkRead to accept fromSeeAll parameter for contextual notifications
• Modify expandOffersToUserProjectsAndMarkRead to accept fromSeeAll parameter for contextual notifications
• Show shorter notification messages when called from "See all" vs chevron expand buttons
• Add safety checks to prevent errors when offers arrays are empty
• Standardize notification message text consistency
• TypeScript and formatting lint fixes

Both "See all" links now properly mark offers as viewed before navigation,
preventing users from seeing unread offers in the detailed views.

- Replace router-links with click handlers for both "See all" offers links - Add handleSeeAllOffersToUser and handleSeeAllOffersToUserProjects methods - Modify expandOffersToUserAndMarkRead to accept fromSeeAll parameter for contextual notifications - Modify expandOffersToUserProjectsAndMarkRead to accept fromSeeAll parameter for contextual notifications - Show shorter notification messages when called from "See all" vs chevron expand buttons - Add safety checks to prevent errors when offers arrays are empty - Standardize notification message text consistency - TypeScript and formatting lint fixes Both "See all" links now properly mark offers as viewed before navigation, preventing users from seeing unread offers in the detailed views.

jose added 2 commits 1 week ago

9bdd66b9c9 feat(NewActivityView): enhance "See all" links to mark offers as read before navigation

- Replace router-links with click handlers for both "See all" offers links
- Add handleSeeAllOffersToUser and handleSeeAllOffersToUserProjects methods
- Modify expandOffersToUserAndMarkRead to accept fromSeeAll parameter for contextual notifications
- Modify expandOffersToUserProjectsAndMarkRead to accept fromSeeAll parameter for contextual notifications
- Show shorter notification messages when called from "See all" vs chevron expand buttons
- Add safety checks to prevent errors when offers arrays are empty
- Standardize notification message text consistency
- TypeScript and formatting lint fixes

Both "See all" links now properly mark offers as viewed before navigation,
preventing users from seeing unread offers in the detailed views.

ac603f66e2 Lint fix

jose added 1 commit 3 days ago

c3ff471ea1 Merge branch 'master' into new-activity-mark-read

jose added 1 commit 3 days ago

5d9f455fc8 feat: move mark-as-read logic from navigation to view loading

- Remove mark-as-read logic from NewActivityView navigation handlers
- Add mark-as-read logic to RecentOffersToUserView and RecentOffersToUserProjectsView after data loading
- Improve "You've already seen all the following" marker positioning
- Update marker styling with dashed border and centered text

This ensures the marker appears at the correct position in the list
instead of always at the top, providing better UX when viewing offers.

trentlarson commented 22 hours ago

Owner

Looks great!

Looks great!

This pull request has changes conflicting with the target branch.

src/libs/util.ts

src/views/ClaimView.vue

src/views/ConfirmGiftView.vue

Sign in to join this conversation.

Reviewers

Request review

No reviewers

Labels

Apply labels

Clear labels

No items

No Label

Milestone

Set milestone

Clear milestone

No items

No Milestone

Assignees

Assign users

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview

Loading…

Cancel

Save

There is no content yet.