trent_larson/crowd-funder-for-time-pwa
4
1
Fork 2
Code Issues Pull Requests 22 Releases 5 Wiki Activity

feat(NewActivityView): enhance "See all" links to mark offers as read before navigation #198

Merged
jose merged 6 commits from new-activity-mark-read into master 2025-09-19 07:14:24 +00:00
Conversation 1 Commits 6 Files Changed 3 +48 -19
jose commented 2025-09-10 10:19:23 +00:00
Owner
Copy Link
  • Replace router-links with click handlers for both "See all" offers links
  • Add handleSeeAllOffersToUser and handleSeeAllOffersToUserProjects methods
  • Modify expandOffersToUserAndMarkRead to accept fromSeeAll parameter for contextual notifications
  • Modify expandOffersToUserProjectsAndMarkRead to accept fromSeeAll parameter for contextual notifications
  • Show shorter notification messages when called from "See all" vs chevron expand buttons
  • Add safety checks to prevent errors when offers arrays are empty
  • Standardize notification message text consistency
  • TypeScript and formatting lint fixes

Both "See all" links now properly mark offers as viewed before navigation,
preventing users from seeing unread offers in the detailed views.

- Replace router-links with click handlers for both "See all" offers links - Add handleSeeAllOffersToUser and handleSeeAllOffersToUserProjects methods - Modify expandOffersToUserAndMarkRead to accept fromSeeAll parameter for contextual notifications - Modify expandOffersToUserProjectsAndMarkRead to accept fromSeeAll parameter for contextual notifications - Show shorter notification messages when called from "See all" vs chevron expand buttons - Add safety checks to prevent errors when offers arrays are empty - Standardize notification message text consistency - TypeScript and formatting lint fixes Both "See all" links now properly mark offers as viewed before navigation, preventing users from seeing unread offers in the detailed views.
jose added 2 commits 2025-09-10 10:19:24 +00:00
feat(NewActivityView): enhance "See all" links to mark offers as read before navigation 9bdd66b9c9 
- Replace router-links with click handlers for both "See all" offers links
- Add handleSeeAllOffersToUser and handleSeeAllOffersToUserProjects methods
- Modify expandOffersToUserAndMarkRead to accept fromSeeAll parameter for contextual notifications
- Modify expandOffersToUserProjectsAndMarkRead to accept fromSeeAll parameter for contextual notifications
- Show shorter notification messages when called from "See all" vs chevron expand buttons
- Add safety checks to prevent errors when offers arrays are empty
- Standardize notification message text consistency
- TypeScript and formatting lint fixes

Both "See all" links now properly mark offers as viewed before navigation,
preventing users from seeing unread offers in the detailed views.
Lint fix ac603f66e2
jose added 1 commit 2025-09-16 08:19:19 +00:00
Merge branch 'master' into new-activity-mark-read c3ff471ea1
jose added 1 commit 2025-09-16 10:09:32 +00:00
feat: move mark-as-read logic from navigation to view loading 5d9f455fc8 
- Remove mark-as-read logic from NewActivityView navigation handlers
- Add mark-as-read logic to RecentOffersToUserView and RecentOffersToUserProjectsView after data loading
- Improve "You've already seen all the following" marker positioning
- Update marker styling with dashed border and centered text

This ensures the marker appears at the correct position in the list
instead of always at the top, providing better UX when viewing offers.
trentlarson commented 2025-09-18 00:26:21 +00:00
Owner
Copy Link

Looks great!

Looks great!
jose added 1 commit 2025-09-19 06:59:04 +00:00
refactor: simplify notification messages for offer viewing 6fd53b020e 
- Remove conditional notification logic in NewActivityView
- Remove redundant notification in RecentOffersToUserView and RecentOffersToUserProjectsView
- Standardize to single notification message format
jose added 1 commit 2025-09-19 07:13:31 +00:00
Merge branch 'master' into new-activity-mark-read e2c2d54c20
jose merged commit 823fa51275 into master 2025-09-19 07:14:24 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
anomalist jose jsnbuchanan kentbull trentlarson
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: trent_larson/crowd-funder-for-time-pwa#198
Delete Branch "new-activity-mark-read"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?