trent_larson/crowd-funder-for-time-pwa
4
1
Fork 2
Code Issues Pull Requests 22 Releases 5 Wiki Activity

refactor: modernize registration prompt notification in ContactQRScanShowView #197

Merged
jose merged 2 commits from registration-prompt-parity into master 2025-09-08 08:38:22 +00:00
Conversation 1 Commits 2 Files Changed 1 +18 -14
jose commented 2025-09-05 13:41:12 +00:00
Owner
Copy Link
  • Replace deprecated notify.confirm() with modern $notify() API
  • Add structured notification object with group, type, and title properties
  • Extract registration prompt response logic into reusable handleRegistrationPromptResponse method
  • Update settings method from $updateSettings to $saveSettings for consistency
  • Align implementation with ContactsView.vue for better code consistency

This brings the registration prompt notification in ContactQRScanShowView up to parity with the modern implementation used in ContactsView.

- Replace deprecated notify.confirm() with modern $notify() API - Add structured notification object with group, type, and title properties - Extract registration prompt response logic into reusable handleRegistrationPromptResponse method - Update settings method from $updateSettings to $saveSettings for consistency - Align implementation with ContactsView.vue for better code consistency This brings the registration prompt notification in ContactQRScanShowView up to parity with the modern implementation used in ContactsView.
jose added 1 commit 2025-09-05 13:41:13 +00:00
refactor: modernize registration prompt notification in ContactQRScanShowView ca1190aa47 
- Replace deprecated notify.confirm() with modern $notify() API
- Add structured notification object with group, type, and title properties
- Extract registration prompt response logic into reusable handleRegistrationPromptResponse method
- Update settings method from $updateSettings to $saveSettings for consistency
- Align implementation with ContactsView.vue for better code consistency

This brings the registration prompt notification in ContactQRScanShowView up to parity with the modern implementation used in ContactsView.
trentlarson commented 2025-09-06 00:22:22 +00:00
Owner
Copy Link

👍

👍
jose added 1 commit 2025-09-08 08:37:55 +00:00
Merge branch 'master' into registration-prompt-parity 631aa468e6
jose merged commit 8815f36596 into master 2025-09-08 08:38:22 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
anomalist jose jsnbuchanan kentbull trentlarson
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: trent_larson/crowd-funder-for-time-pwa#197
Delete Branch "registration-prompt-parity"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?