Labels Milestones

refactor: modernize registration prompt notification in ContactQRScanShowView #197

Merged

jose merged 2 commits from registration-prompt-parity into master 2 months ago

Conversation 1 Commits 2 Files Changed 1

jose commented 2 months ago

Owner

• Replace deprecated notify.confirm() with modern $notify() API
• Add structured notification object with group, type, and title properties
• Extract registration prompt response logic into reusable handleRegistrationPromptResponse method
• Update settings method from $updateSettings to $saveSettings for consistency
• Align implementation with ContactsView.vue for better code consistency

This brings the registration prompt notification in ContactQRScanShowView up to parity with the modern implementation used in ContactsView.

- Replace deprecated notify.confirm() with modern $notify() API - Add structured notification object with group, type, and title properties - Extract registration prompt response logic into reusable handleRegistrationPromptResponse method - Update settings method from $updateSettings to $saveSettings for consistency - Align implementation with ContactsView.vue for better code consistency This brings the registration prompt notification in ContactQRScanShowView up to parity with the modern implementation used in ContactsView.

jose added 1 commit 2 months ago

ca1190aa47 refactor: modernize registration prompt notification in ContactQRScanShowView

- Replace deprecated notify.confirm() with modern $notify() API
- Add structured notification object with group, type, and title properties
- Extract registration prompt response logic into reusable handleRegistrationPromptResponse method
- Update settings method from $updateSettings to $saveSettings for consistency
- Align implementation with ContactsView.vue for better code consistency

This brings the registration prompt notification in ContactQRScanShowView up to parity with the modern implementation used in ContactsView.

trentlarson commented 2 months ago

Owner

👍

👍

jose added 1 commit 2 months ago

631aa468e6 Merge branch 'master' into registration-prompt-parity

jose merged commit 8815f36596 into master 2 months ago

jose referenced this issue from a commit 2 months ago

Merge pull request 'refactor: modernize registration prompt notification in ContactQRScanShowView' (#197) from registration-prompt-parity into master

The pull request has been merged as 8815f36596.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

Labels

Apply labels

Clear labels

No items

No Label

Milestone

Set milestone

Clear milestone

No items

No Milestone

Assignees

Assign users

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview

Loading…

Cancel

Save

There is no content yet.