fix: persist identity names per user instead of globally #191

Merged
jose merged 3 commits from switching-identities-change-name into master 2 days ago
jose commented 5 days ago
Owner

Fixes issue where identity names were not saved when switching between
multiple identities. Names were being saved to master settings instead
of user-specific settings.

Changes:

  • UserNameDialog: Load/save names from/to user-specific settings
  • NewEditAccountView: Save names to user-specific settings for active DID
  • Both components now use $accountSettings() and $saveUserSettings()
    instead of $settings() and $updateSettings()

Each identity now properly retains their assigned name when switching
between identities. Previously only "User Zero" would show their name
due to using master settings instead of per-identity settings.

Fixes: Identity name persistence across identity switches

Fixes issue where identity names were not saved when switching between multiple identities. Names were being saved to master settings instead of user-specific settings. Changes: - UserNameDialog: Load/save names from/to user-specific settings - NewEditAccountView: Save names to user-specific settings for active DID - Both components now use $accountSettings() and $saveUserSettings() instead of $settings() and $updateSettings() Each identity now properly retains their assigned name when switching between identities. Previously only "User Zero" would show their name due to using master settings instead of per-identity settings. Fixes: Identity name persistence across identity switches
jose added 2 commits 5 days ago
83c0c18db2 fix: persist identity names per user instead of globally
trentlarson reviewed 4 days ago
// Save to user-specific settings for the current identity
await this.$saveUserSettings(activeDid, {
firstName: this.givenName,
lastName: "", // deprecated, pre v 0.1.3
Poster
Owner

Remove the lastName. We don't want any value in that slot at this point.

Remove the lastName. We don't want any value in that slot at this point.
jose added 1 commit 2 days ago
5f8d1fc8c6 refactor: remove deprecated lastName field from user settings
jose merged commit 2b9b43d08f into master 2 days ago
The pull request has been merged as 2b9b43d08f.
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.