trent_larson/crowd-funder-for-time-pwa
4
1
Fork 2
Code Issues Pull Requests 22 Releases 5 Wiki Activity

fix: persist identity names per user instead of globally #191

Merged
jose merged 3 commits from switching-identities-change-name into master 2025-09-01 08:54:41 +00:00
Conversation 1 Commits 3 Files Changed 2 +30 -6
jose commented 2025-08-29 08:43:44 +00:00
Owner
Copy Link

Fixes issue where identity names were not saved when switching between
multiple identities. Names were being saved to master settings instead
of user-specific settings.

Changes:

  • UserNameDialog: Load/save names from/to user-specific settings
  • NewEditAccountView: Save names to user-specific settings for active DID
  • Both components now use $accountSettings() and $saveUserSettings()
    instead of $settings() and $updateSettings()

Each identity now properly retains their assigned name when switching
between identities. Previously only "User Zero" would show their name
due to using master settings instead of per-identity settings.

Fixes: Identity name persistence across identity switches

Fixes issue where identity names were not saved when switching between multiple identities. Names were being saved to master settings instead of user-specific settings. Changes: - UserNameDialog: Load/save names from/to user-specific settings - NewEditAccountView: Save names to user-specific settings for active DID - Both components now use $accountSettings() and $saveUserSettings() instead of $settings() and $updateSettings() Each identity now properly retains their assigned name when switching between identities. Previously only "User Zero" would show their name due to using master settings instead of per-identity settings. Fixes: Identity name persistence across identity switches
jose added 2 commits 2025-08-29 08:43:45 +00:00
fix: persist identity names per user instead of globally 83c0c18db2 
Fixes issue where identity names were not saved when switching between
multiple identities. Names were being saved to master settings instead
of user-specific settings.

Changes:
- UserNameDialog: Load/save names from/to user-specific settings
- NewEditAccountView: Save names to user-specific settings for active DID
- Both components now use $accountSettings() and $saveUserSettings()
  instead of $settings() and $updateSettings()

Each identity now properly retains their assigned name when switching
between identities. Previously only "User Zero" would show their name
due to using master settings instead of per-identity settings.

Fixes: Identity name persistence across identity switches
Lint fixes dde37e73e1
trentlarson reviewed 2025-08-30 01:32:46 +00:00
src/views/NewEditAccountView.vue
@@ -117,0 +118,4 @@
// Save to user-specific settings for the current identity
await this.$saveUserSettings(activeDid, {
firstName: this.givenName,
lastName: "", // deprecated, pre v 0.1.3
trentlarson commented 2025-08-30 01:32:46 +00:00
Owner
Copy Link

Remove the lastName. We don't want any value in that slot at this point.

Remove the lastName. We don't want any value in that slot at this point.
jose added 1 commit 2025-09-01 08:53:35 +00:00
refactor: remove deprecated lastName field from user settings 5f8d1fc8c6 
- Remove lastName field from $saveUserSettings and $saveSettings calls
- Clean up deprecated pre v0.1.3 code
jose merged commit 2b9b43d08f into master 2025-09-01 08:54:41 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
trentlarson
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
anomalist jose jsnbuchanan kentbull trentlarson
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: trent_larson/crowd-funder-for-time-pwa#191
Delete Branch "switching-identities-change-name"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?