Labels Milestones

Refactor: create reusable component version of registration/onboarding notice #179

Open

jose wants to merge 4 commits from onboard-alert-component into master

pull from: onboard-alert-component

merge into: trent_larson:master

trent_larson:activedid_migration

trent_larson:ai-context

trent_larson:android-15-check

trent_larson:android-file-save

trent_larson:app_id_fix

trent_larson:ask-for-contacts-export

trent_larson:build-dev-to-dist

trent_larson:build-improvement

trent_larson:build-ios

trent_larson:build-web-serve-test

trent_larson:build-with-env

trent_larson:capacitor-local-save

trent_larson:claim-view-error-handling

trent_larson:claimview-fullfills-offer

trent_larson:contact-gifting-current-user

trent_larson:contacts-view-fixes

trent_larson:cross-platform-factory

trent_larson:cross-platform-factory-redux

trent_larson:d9085ced6df7dc7bdcd899959cea6489cab7f8b8

trent_larson:db-backup-cross-platform

trent_larson:deep-link

trent_larson:deep-links-android-update

trent_larson:deep_linking

trent_larson:design-tweaks-2023-12

trent_larson:dialog-styles-unified

trent_larson:didview-invalid-did-handling

trent_larson:electron_fix_20250317

trent_larson:experimental_plugin

trent_larson:eye-slash

trent_larson:fix-contact-import-export

trent_larson:fix-deep-link

trent_larson:fix-service-worker

trent_larson:friend-tech-inspired-pwa-dialog

trent_larson:get-get-hash

trent_larson:gifting-periphery-improvements

trent_larson:gifting-ui-2025-05

trent_larson:home-icon-enhancements

trent_larson:home-view-notification-improvements

trent_larson:homeview-cleanup-2025-03

trent_larson:homeview-refresh-2025-02

trent_larson:imagemagick-anrdoid

trent_larson:ios-contact-copy

trent_larson:logger-level

trent_larson:logging-upgrade

trent_larson:main

trent_larson:master

trent_larson:master-patch

trent_larson:master-settings-upgrade

trent_larson:matthew-scratch-2025-06-28

trent_larson:migrate-dexie-to-sqlite

trent_larson:nearby-filter

trent_larson:new-storage

trent_larson:nostr

trent_larson:notification-line-wrapping

trent_larson:notification-request-permission-dialog

trent_larson:notification-section

trent_larson:notify-time

trent_larson:offer-edit

trent_larson:offer-validation-logic

trent_larson:onboarding-dialog-fix

trent_larson:passkey

trent_larson:passkey-cache

trent_larson:performance-optimizations-testing

trent_larson:photo-reverse

trent_larson:plan-loc

trent_larson:platformservicemixin-interface-consolidation

trent_larson:playwright-pwa-install-test

trent_larson:playwright-test-60-fix

trent_larson:playwright-test-updates

trent_larson:profile-pic

trent_larson:profile_include_location

trent_larson:project-gives

trent_larson:projectview-hide-offer-link-unregistered

trent_larson:qrcode-capacitor

trent_larson:registration-gate

trent_larson:remove-image-cache

trent_larson:replace-iconrenderer

trent_larson:script-build-mode

trent_larson:search-map-fix

trent_larson:side_step

trent_larson:simple-signer

trent_larson:split_build_process

trent_larson:sql-absurd-sql

trent_larson:sql-absurd-sql-further

trent_larson:sql-wa-sqlite

trent_larson:star-projects

trent_larson:starred-projects

trent_larson:streamline-attempt

trent_larson:sw-cleanup

trent_larson:tmp

trent_larson:trent-tweaks

trent_larson:tweaks

trent_larson:ui-fixes-2024-03

trent_larson:ui-fixes-2025-03

trent_larson:ui-fixes-2025-06-w2

trent_larson:units-mocking

trent_larson:v-onboarding-2024-04

trent_larson:vite-version

trent_larson:web-serve-fix

trent_larson:web-tests

Conversation 0 Commits 4 Files Changed 5

jose commented 8 hours ago

Owner

• Improve existing notice style by introducing visual hierarchy to buttons and laying them out responsively
• Centralize all registration notice logic within upgraded RegistrationNotice component, for use in HomeView, AccountViewView and ProjectsView
• Clean up unused methods and imports in affected views
• Enable customizable messages to maintain original contextual wordings unique to each view
• Update Playwright test 00 to use the correct ID locator

- Improve existing notice style by introducing visual hierarchy to buttons and laying them out responsively - Centralize all registration notice logic within upgraded RegistrationNotice component, for use in HomeView, AccountViewView and ProjectsView - Clean up unused methods and imports in affected views - Enable customizable messages to maintain original contextual wordings unique to each view - Update Playwright test 00 to use the correct ID locator

jose added 4 commits 8 hours ago

7f5a64dceb UI: update HomeView onboard alert style

- Style-wise, make it consistent with similar alerts
- Introduce visual hierarchy to buttons
- Responsive button layout

47a7b03cca Refactor: simplify RegistrationNotice component interface

- Centralize all registration notice logic within upgraded RegistrationNotice component
- Clean up unused methods and imports in HomeView and AccountViewView
- Customizable message to maintain original contextual wordings unique to each view

Component is now more focused and follows Vue.js best practices
for conditional rendering.

2cb2f3ef3a Fix: update notice locator

25e79249dd Feat: integrate RegistrationNotice component into ProjectsView

- Replace custom onboarding button with RegistrationNotice component
- Maintain v-else conditional rendering for unregistered users
- Remove unused methods and imports related to custom registration flow
- Use contextual message "To announce a project, get someone to onboard you."
- Remove unnecessary wrapping div in RegistrationNotice

Completes registration UI standardization across all main views.

This pull request can be merged automatically.

This branch is out-of-date with the base branch

You are not authorized to merge this pull request.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

Labels

Apply labels

Clear labels

No items

No Label

Milestone

Set milestone

Clear milestone

No items

No Milestone

Assignees

Assign users

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview

Loading…

Cancel

Save

There is no content yet.