Fix offer fulfillment detection + consistencies between ClaimView and ConfirmGiftView
#167
Open
jose
wants to merge 4 commits from claimview-fullfills-offer into master
pull from: claimview-fullfills-offer
merge into: trent_larson:master
trent_larson:activedid_migration
trent_larson:ai-context
trent_larson:android-15-check
trent_larson:android-file-save
trent_larson:app_id_fix
trent_larson:ask-for-contacts-export
trent_larson:build-dev-to-dist
trent_larson:build-improvement
trent_larson:build-ios
trent_larson:build-web-serve-test
trent_larson:build-with-env
trent_larson:capacitor-local-save
trent_larson:claim-view-error-handling
trent_larson:contact-gifting-current-user
trent_larson:contacts-view-fixes
trent_larson:cross-platform-factory
trent_larson:cross-platform-factory-redux
trent_larson:d9085ced6df7dc7bdcd899959cea6489cab7f8b8
trent_larson:db-backup-cross-platform
trent_larson:deep-link
trent_larson:deep-links-android-update
trent_larson:deep_linking
trent_larson:design-tweaks-2023-12
trent_larson:dialog-styles-unified
trent_larson:didview-invalid-did-handling
trent_larson:electron_fix_20250317
trent_larson:experimental_plugin
trent_larson:eye-slash
trent_larson:fix-contact-import-export
trent_larson:fix-deep-link
trent_larson:fix-service-worker
trent_larson:friend-tech-inspired-pwa-dialog
trent_larson:get-get-hash
trent_larson:gifting-periphery-improvements
trent_larson:gifting-ui-2025-05
trent_larson:home-icon-enhancements
trent_larson:home-view-notification-improvements
trent_larson:homeview-cleanup-2025-03
trent_larson:homeview-refresh-2025-02
trent_larson:imagemagick-anrdoid
trent_larson:ios-contact-copy
trent_larson:logger-level
trent_larson:logging-upgrade
trent_larson:main
trent_larson:master
trent_larson:master-patch
trent_larson:master-settings-upgrade
trent_larson:matthew-scratch-2025-06-28
trent_larson:migrate-dexie-to-sqlite
trent_larson:nearby-filter
trent_larson:new-storage
trent_larson:nostr
trent_larson:notification-line-wrapping
trent_larson:notification-request-permission-dialog
trent_larson:notification-section
trent_larson:notify-time
trent_larson:offer-edit
trent_larson:offer-validation-logic
trent_larson:onboard-alert-component
trent_larson:onboarding-dialog-fix
trent_larson:passkey
trent_larson:passkey-cache
trent_larson:performance-optimizations-testing
trent_larson:photo-reverse
trent_larson:plan-loc
trent_larson:platformservicemixin-interface-consolidation
trent_larson:playwright-pwa-install-test
trent_larson:playwright-test-60-fix
trent_larson:playwright-test-updates
trent_larson:profile-pic
trent_larson:profile_include_location
trent_larson:project-gives
trent_larson:projectview-hide-offer-link-unregistered
trent_larson:qrcode-capacitor
trent_larson:registration-gate
trent_larson:remove-image-cache
trent_larson:replace-iconrenderer
trent_larson:script-build-mode
trent_larson:search-map-fix
trent_larson:side_step
trent_larson:simple-signer
trent_larson:split_build_process
trent_larson:sql-absurd-sql
trent_larson:sql-absurd-sql-further
trent_larson:sql-wa-sqlite
trent_larson:star-projects
trent_larson:starred-projects
trent_larson:streamline-attempt
trent_larson:sw-cleanup
trent_larson:tmp
trent_larson:trent-tweaks
trent_larson:tweaks
trent_larson:ui-fixes-2024-03
trent_larson:ui-fixes-2025-03
trent_larson:ui-fixes-2025-06-w2
trent_larson:units-mocking
trent_larson:v-onboarding-2024-04
trent_larson:vite-version
trent_larson:web-serve-fix
trent_larson:web-tests
4 Commits
| Author | SHA1 | Message | Date |
|---|---|---|---|
Jose Olarte III
|
e5ad71505c |
Chore: move function to serverUtil
- capitalizeAndInsertSpacesBeforeCapsWithAPrefix() defined in two places, unified and moved to endorserServer.ts - Use capitalizeAndInsertSpacesBeforeCaps() that's already defined in endorserServer.ts |
3 days ago |
 Trent Larson
|
19f0c270d3 |
chore: Rename variable for clarity
|
4 days ago |
|
Jose Olarte III
|
693173f09d |
UI: wording and spacing consistencies
- Added grouped conditional spacing to ensure a top margin before fulfills links - Brought over icons and wording from ConfirmGiftView to ClaimView |
1 week ago |
|
Jose Olarte III
|
a1388539c1 |
Fix: improve offer fulfillment detection in ClaimView
- Remove outdated fulfillsType logic that was checking for non-PlanAction items - Keep only the new offer fulfillment extraction from fullClaim.fulfills array - Apply consistent changes to both ClaimView and ConfirmGiftView This ensures that "Fulfills Offer..." links appear correctly when gives are created from offers, by directly parsing the fulfills array instead of relying on API-processed fields that only capture the first relationship. |
1 week ago |