Labels Milestones

docs: correct PlatformServiceMixin caching documentation and fix interface comments #166

Open

anomalist wants to merge 3 commits from platformservicemixin-interface-consolidation into master

pull from: platformservicemixin-interface-consolidation

merge into: trent_larson:master

trent_larson:activedid_migration

trent_larson:ai-context

trent_larson:android-15-check

trent_larson:android-file-save

trent_larson:app_id_fix

trent_larson:ask-for-contacts-export

trent_larson:build-dev-to-dist

trent_larson:build-improvement

trent_larson:build-ios

trent_larson:build-web-serve-test

trent_larson:build-with-env

trent_larson:capacitor-local-save

trent_larson:claim-view-error-handling

trent_larson:claimview-fullfills-offer

trent_larson:contact-gifting-current-user

trent_larson:contacts-view-fixes

trent_larson:cross-platform-factory

trent_larson:cross-platform-factory-redux

trent_larson:d9085ced6df7dc7bdcd899959cea6489cab7f8b8

trent_larson:db-backup-cross-platform

trent_larson:deep-link

trent_larson:deep-links-android-update

trent_larson:deep_linking

trent_larson:design-tweaks-2023-12

trent_larson:dialog-styles-unified

trent_larson:didview-invalid-did-handling

trent_larson:electron_fix_20250317

trent_larson:experimental_plugin

trent_larson:eye-slash

trent_larson:fix-contact-import-export

trent_larson:fix-deep-link

trent_larson:fix-service-worker

trent_larson:friend-tech-inspired-pwa-dialog

trent_larson:get-get-hash

trent_larson:gifting-periphery-improvements

trent_larson:gifting-ui-2025-05

trent_larson:home-icon-enhancements

trent_larson:home-view-notification-improvements

trent_larson:homeview-cleanup-2025-03

trent_larson:homeview-refresh-2025-02

trent_larson:imagemagick-anrdoid

trent_larson:ios-contact-copy

trent_larson:logger-level

trent_larson:logging-upgrade

trent_larson:main

trent_larson:master

trent_larson:master-patch

trent_larson:master-settings-upgrade

trent_larson:matthew-scratch-2025-06-28

trent_larson:migrate-dexie-to-sqlite

trent_larson:nearby-filter

trent_larson:new-storage

trent_larson:nostr

trent_larson:notification-line-wrapping

trent_larson:notification-request-permission-dialog

trent_larson:notification-section

trent_larson:notify-time

trent_larson:offer-edit

trent_larson:offer-validation-logic

trent_larson:onboard-alert-component

trent_larson:onboarding-dialog-fix

trent_larson:passkey

trent_larson:passkey-cache

trent_larson:performance-optimizations-testing

trent_larson:photo-reverse

trent_larson:plan-loc

trent_larson:playwright-pwa-install-test

trent_larson:playwright-test-60-fix

trent_larson:playwright-test-updates

trent_larson:profile-pic

trent_larson:profile_include_location

trent_larson:project-gives

trent_larson:projectview-hide-offer-link-unregistered

trent_larson:qrcode-capacitor

trent_larson:registration-gate

trent_larson:remove-image-cache

trent_larson:replace-iconrenderer

trent_larson:script-build-mode

trent_larson:search-map-fix

trent_larson:side_step

trent_larson:simple-signer

trent_larson:split_build_process

trent_larson:sql-absurd-sql

trent_larson:sql-absurd-sql-further

trent_larson:sql-wa-sqlite

trent_larson:star-projects

trent_larson:starred-projects

trent_larson:streamline-attempt

trent_larson:sw-cleanup

trent_larson:tmp

trent_larson:trent-tweaks

trent_larson:tweaks

trent_larson:ui-fixes-2024-03

trent_larson:ui-fixes-2025-03

trent_larson:ui-fixes-2025-06-w2

trent_larson:units-mocking

trent_larson:v-onboarding-2024-04

trent_larson:vite-version

trent_larson:web-serve-fix

trent_larson:web-tests

Conversation 0 Commits 3 Files Changed 16

anomalist commented 1 week ago

Owner

• Fix misleading claims about WeakMap-based caching (all caching code is commented out)
• Correct interface comment from "contacts cached, settings fresh" to "always fresh (no caching)"
• Add comprehensive clarification section explaining caching confusion
• Document that caching system was planned but never implemented
• Update performance optimizations section to reflect actual no-caching reality

The documentation now accurately reflects that this is a no-caching system
that provides convenience methods for database operations, not a
performance-optimized caching system as previously claimed.

- Fix misleading claims about WeakMap-based caching (all caching code is commented out) - Correct interface comment from "contacts cached, settings fresh" to "always fresh (no caching)" - Add comprehensive clarification section explaining caching confusion - Document that caching system was planned but never implemented - Update performance optimizations section to reflect actual no-caching reality The documentation now accurately reflects that this is a no-caching system that provides convenience methods for database operations, not a performance-optimized caching system as previously claimed.

anomalist added 1 commit 1 week ago

18fc31d45a docs: correct PlatformServiceMixin caching documentation and fix interface comments

- Fix misleading claims about WeakMap-based caching (all caching code is commented out)
- Correct interface comment from "contacts cached, settings fresh" to "always fresh (no caching)"
- Add comprehensive clarification section explaining caching confusion
- Document that caching system was planned but never implemented
- Update performance optimizations section to reflect actual no-caching reality

The documentation now accurately reflects that this is a no-caching system
that provides convenience methods for database operations, not a
performance-optimized caching system as previously claimed.

anomalist added 1 commit 2 days ago

1d0c8ac3cf Merge branch 'master' into platformservicemixin-interface-consolidation

anomalist added 1 commit 2 days ago

243c3eea32 feat(platform): complete $updateSettings deprecation and interface consolidation

- Remove deprecated $updateSettings method entirely
- Migrate 21 components to use proper settings methods
- Consolidate IPlatformServiceMixin and ComponentCustomProperties interfaces
- Establish single source of truth for platform service methods
- Update all components to use $saveMySettings, $saveUserSettings, $saveSettings
- Remove interface duplication and deprecated method warnings
- Ensure clean, maintainable codebase with proper separation of concerns

Breaking Change: $updateSettings method removed - use $saveSettings variants instead

This pull request has changes conflicting with the target branch.

src/views/AccountViewView.vue

Sign in to join this conversation.

Reviewers

Request review

No reviewers

Labels

Apply labels

Clear labels

No items

No Label

Milestone

Set milestone

Clear milestone

No items

No Milestone

Assignees

Assign users

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview

Loading…

Cancel

Save

There is no content yet.