trent_larson
/
crowd-funder-for-time-pwa
4
1
Fork 2
Code Issues Pull Requests 18 Releases 5 Wiki Activity
Labels Milestones

Fix iOS contact copy function #154

Merged
jose merged 9 commits from ios-contact-copy into master 2 months ago
Conversation 1 Commits 9 Files Changed 11
jose commented 3 months ago
Owner

Added: native clipboard service

  • Install @capacitor/clipboard@^6.0.0 for native clipboard support
  • Create platform-agnostic ClipboardService with iOS/Android native API

Fix: iOS copy function

  • Update ContactsView, ShareMyContactInfoView, ContactQRScanShowView to use new service
  • Replace unreliable web navigator.clipboard with native Capacitor clipboard
  • Add comprehensive error handling and logging for clipboard operations
  • Sync Capacitor plugins to include clipboard functionality
Added: native clipboard service - Install @capacitor/clipboard@^6.0.0 for native clipboard support - Create platform-agnostic ClipboardService with iOS/Android native API Fix: iOS copy function - Update ContactsView, ShareMyContactInfoView, ContactQRScanShowView to use new service - Replace unreliable web navigator.clipboard with native Capacitor clipboard - Add comprehensive error handling and logging for clipboard operations - Sync Capacitor plugins to include clipboard functionality
jose added 3 commits 3 months ago
c18a6b334f Added: native clipboard service
c3bd22fb83 Fix: iOS copy function
jose changed target branch from build-improvement to master 3 months ago
jose changed title from Fix iOS contact copy function to WIP: Fix iOS contact copy function 3 months ago
jose added 2 commits 3 months ago
jose added 1 commit 3 months ago
jose changed title from WIP: Fix iOS contact copy function to Fix iOS contact copy function 3 months ago
trentlarson reviewed 3 months ago
src/services/ClipboardService.ts Outdated
const platform = Capacitor.getPlatform();
const isNative = Capacitor.isNativePlatform();
logger.log("[ClipboardService] Copying to clipboard:", {
trentlarson commented 3 months ago
Poster
Owner

I vote for this to be a logger.debug call.

I vote for this to be a logger.debug call.
trentlarson commented 3 months ago
Poster
Owner

... in multiple places.

... in multiple places.
jose commented 3 months ago
Poster
Owner

Agreed. Changed level from .log to .debug in two spots in ClipboardService.ts

Agreed. Changed level from `.log` to `.debug` in two spots in ClipboardService.ts
trentlarson commented 3 months ago
Owner

👍

👍
jose added 1 commit 3 months ago
jose added 1 commit 3 months ago
jose added 1 commit 2 months ago
jose merged commit 1e203da9bb into master 2 months ago
The pull request has been merged as 1e203da9bb.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
No items
No Label
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'ios-contact-copy'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes