refactor: centralize QR navigation logic and add export prompt after contact addition #152

anomalist · 2025-07-31T03:49:55Z

anomalist commented

2025-07-31 03:49:55 +00:00

Create QRNavigationService to handle platform-specific QR routing
Remove direct Capacitor imports from ContactsView, ProjectsView, HelpView
Replace duplicated QR routing logic with centralized service calls
Update HelpView template to use platform service methods (isCapacitor, capabilities)
Add export data prompt after successfully adding a contact
Add NOTIFY_EXPORT_DATA_PROMPT notification constant
Implement exportContactData() method with platform service integration
Fix TypeScript compatibility for Vue Router route parameters
Maintain consistent QR navigation behavior across all views

Eliminates code duplication and improves platform abstraction by using
PlatformService instead of direct Capacitor references. Enhances user
experience with automatic export prompts for data backup.

- Create QRNavigationService to handle platform-specific QR routing - Remove direct Capacitor imports from ContactsView, ProjectsView, HelpView - Replace duplicated QR routing logic with centralized service calls - Update HelpView template to use platform service methods (isCapacitor, capabilities) - Add export data prompt after successfully adding a contact - Add NOTIFY_EXPORT_DATA_PROMPT notification constant - Implement exportContactData() method with platform service integration - Fix TypeScript compatibility for Vue Router route parameters - Maintain consistent QR navigation behavior across all views Eliminates code duplication and improves platform abstraction by using PlatformService instead of direct Capacitor references. Enhances user experience with automatic export prompts for data backup.

anomalist added 1 commit 2025-07-31 03:49:56 +00:00

refactor: centralize QR navigation logic and add export prompt after contact addition 6007bc34e4

- Create QRNavigationService to handle platform-specific QR routing
- Remove direct Capacitor imports from ContactsView, ProjectsView, HelpView
- Replace duplicated QR routing logic with centralized service calls
- Update HelpView template to use platform service methods (isCapacitor, capabilities)
- Add export data prompt after successfully adding a contact
- Add NOTIFY_EXPORT_DATA_PROMPT notification constant
- Implement exportContactData() method with platform service integration
- Fix TypeScript compatibility for Vue Router route parameters
- Maintain consistent QR navigation behavior across all views

Eliminates code duplication and improves platform abstraction by using
PlatformService instead of direct Capacitor references. Enhances user
experience with automatic export prompts for data backup.

trentlarson added 1 commit 2025-08-16 22:18:45 +00:00

doc: Add comment about similar code. 799981d1cb

anomalist added 106 commits 2025-08-17 02:36:27 +00:00

Consolidate deep-link paths to be derived from the same source so they don't get out of sync any more. 861408c7bc

fix: quick-and-dirty fix to get the correct environment variables b0d99e7c1e

bump to version 1.0.3 build 36 a9a8ba217c

bump version number and add '-beta' dc21e8dac3

fix: invite-one-accept deep link would not route properly 33ce6bdb72

Merge branch 'master' into deep-link c1477d0266

Merge pull request 'Deep-link fixes' (#145 ) from deep-link into master 6d6816d1a8

Reviewed-on: #145

fix: linting ffe8d90161

bump to version 1.0.4 and build 37 002f240720

bump version and add "-beta", and update commit hashes in changelog 3fce10ae98

fix problem with repeated bad stringifies of contactMethods on contact export/import fd0026ac2d

Merge pull request 'fix problem with repeated bad stringifies of contactMethods on contact export/import' (#148 ) from fix-contact-import-export into master 6ddde21a86

Reviewed-on: #148

bump to version 1.0.5 and build 38 64f24dc473

bump version and add "-beta" bcbb80e034

Fix: switch to CSS-based text-truncate 5cf1759653

- Eliminate dependence on arbitrary maxlength for truncation
- Ensure truncation is purely visual, and does not touch content

fix: usage of testRecursivelyOnStrings method to match new definition 31711e2ea6

change test port to 8081 (to not conflict with running server) and remove unused "logger" setting 219a383015

I believe logger is not an option. https://playwright.dev/docs/api/class-testoptions

undo port change because it may cause a timeout starting the tests (intermittently) cbdd54e383

chore: update cursor rulesets 1180ebd4ca

Ref name change 12b43bf684

Function name change 6d28a7d8a3

Remove 'customTitle' variable 0582954cfa

chore: more cursor rules updates 2a32903326

Fix GiftedDialog functionality 433f3c1154

- Add description, amountInput, and unitCode parameters to GiftedDialog.open()
- Pass offer details to GiftedDialog in ProjectViewView
- Update ContactsView to handle new GiftedDialog parameters

Fix parameter passing in contact gift dialogs f4a7d437c8

- Replace @Emit decorator with direct $emit calls in ContactListItem
- Fix DID comparison from loose to strict equality in nameForDid function
- Resolve issue where giver/recipient names showed as "this unnamed user"

The @Emit decorator was not properly spreading array parameters, causing
the parent component to receive arrays instead of separate string parameters.

docs: add comprehensive GiftedDialog architecture overview 9cd4551bed

Add detailed analysis of GiftedDialog component architecture including:
- DRY and SOLID principles compliance assessment
- Cognitive load analysis with before/after comparisons
- Architectural complexity remediation plan
- Phased implementation strategy (cognitive load → composable architecture)
- Component hierarchy and dependency analysis
- Performance and security considerations

The document provides actionable recommendations for reducing complexity
while maintaining functionality, with specific code examples and metrics.

Merge branch 'build-improvement' of ssh://173.199.124.46:222/trent_larson/crowd-funder-for-time-pwa into build-improvement 8b2c6714ec

Add form field preservation in gifting flow 404a7cbc71

- Preserve description, amount, and unit code when navigating between gifting steps
- Add form field props to EntitySelectionStep and GiftedDialog components
- Update ContactGiftingView to handle form state persistence in URL parameters

Fix ClaimView affirm delivery action e741790d70

- Add offer context support to gifting flow
- Add offerId prop to EntitySelectionStep for offer fulfillment context
- Pass offerId through GiftedDialog to EntitySelectionStep
- Update ContactGiftingView to handle offerId from route query parameters
- Extract offer details (description, amount, unitCode) for pre-population

Integrate TypeScript type checking into build process with conditional execution c30b94dcc7

- Add type checking to build scripts for production/test builds only
- Fix TypeScript errors in migration service, router, and platform services
- Add electronAPI type declarations for Electron platform
- Remove type checking from development builds for faster hot reload
- Update tsconfig.node.json to resolve configuration conflicts
- Ensure type safety for production while maintaining fast development workflow

Merge branch 'build-improvement' of ssh://173.199.124.46:222/trent_larson/crowd-funder-for-time-pwa into build-improvement a63ccae9b1

Fix entity type matching in ClaimView 54bfaafbd0

- Add recipientEntityTypeOverride prop to GiftedDialog component
- Add data-testid and data-recipient-entity-type-override attributes for testing
- Update updateEntityTypes() to respect recipientEntityTypeOverride when set
- Add watcher for recipientEntityTypeOverride prop changes
- Update ClaimView to pass recipient entity type override based on project context
- Improve recipient determination logic in ClaimView for person vs project recipients

chore: remove comments that moved into ClickUp issues 197dea48c9

chore: Restore the dev setting for a variable. e5e01040b2

fix: Adjust VC types. fb2ac963bd

Fix HomeView registration status by using $accountSettings() instead of $settings() 3d38cb89a9

- Change HomeView to use $accountSettings() method which returns correct isRegistered value
- Remove isRegistered: false default that was overriding database values
- Fix settings override issue where empty defaults were overriding activeDid
- Remove excessive settings tracing logs to clean up console output
- Ensure consistent registration status between HomeView and AccountViewView

The HomeView was incorrectly showing users as unregistered while AccountViewView showed them as registered due to using $settings() (returns null) instead of $accountSettings() (returns correct database value).

Merge branch 'build-improvement' of ssh://173.199.124.46:222/trent_larson/crowd-funder-for-time-pwa into build-improvement 371cf763c8

Refactor: simplify GiftedDialog with explicit entity type props 06f3a4c7c2

Replace complex updateEntityTypes() method with explicit giverEntityType and
recipientEntityType props. This makes the component more declarative and
maintainable by removing hidden logic and making entity type relationships
clear at the call site.

- Remove updateEntityTypes() method and related watchers
- Add explicit giverEntityType and recipientEntityType props with defaults
- Update all views to use inline logic for entity type determination
- Fix entity type preservation in navigation flows
- Enhance query parameter passing for better context preservation
- Fix recipient reset issue in ContactGiftingView
- Resolve entity type mismatch in HomeView project button flow

Files changed:
- GiftedDialog.vue: Remove complex logic, add explicit props
- EntitySelectionStep.vue: Enhanced query parameter handling
- ContactGiftingView.vue: Improved context preservation
- HomeView.vue, ProjectViewView.vue, ClaimView.vue, ContactsView.vue:
  Updated to use explicit entity type props
- Add refactoring documentation

Remove PROD_SHARE_DOMAIN constant and unify domain configuration aed16ebe94

- Remove hard-coded PROD_SHARE_DOMAIN from src/constants/app.ts
- Update all sharing functionality to use environment-specific APP_SERVER
- Rewrite domain configuration documentation to reflect unified approach
- Simplify domain management with single APP_SERVER constant
- Update README.md examples to use APP_SERVER for all URL generation

This change eliminates the complexity of separate constants for different
URL types and provides consistent environment-specific configuration for
all functionality including sharing.

Fix contact methods JSON string/array duality in PlatformServiceMixin 0bd0e7c332

- Add ContactMaybeWithJsonStrings type usage for internal database operations
- Implement $normalizeContacts() method to handle both JSON string and array formats
- Update $contacts(), $getContact(), and $getAllContacts() to use normalization
- Fix $updateContact() to properly convert contactMethods arrays to JSON strings
- Add validation to filter out malformed contact method objects
- Update ContactEditView to handle malformed data gracefully

Resolves issue where contactMethods could be stored as JSON strings in database
but expected as arrays in components, causing "Cannot create property 'label' on number '0'" errors.

chore: Remove duplicate checks for bad contact methods. 984244117b

fix: A 'back' from a DID view page goes back to the list (not to edit again) 938cf673fc

Fix Android emulator API connectivity with cleaner build script approach 32f589b866

- Move Android-specific API server logic from common.sh to build-android.sh
- Remove unnecessary ANDROID_BUILD environment variable
- Set localhost:3000 as default in common.sh for all Capacitor builds
- Override to 10.0.2.2:3000 specifically in build-android.sh for Android development
- Fix execution order issue where common.sh ran before ANDROID_BUILD was set
- Maintain proper separation: Android emulator uses 10.0.2.2, iOS simulator uses localhost

Upgrade Android API from 35 to 36 b681905abd

Update Android SDK configuration to target API 36 (Android 16):
- Update compileSdkVersion and targetSdkVersion from 35 to 36
- Update suppressUnsupportedCompileSdk from 34 to 36
- Maintains minSdkVersion at 22 for broad device compatibility
- Verified build system compatibility with Gradle 8.13

Add custom API IP support for Android physical device development 1d6418b02c

Implement --api-ip parameter for Android builds with smart defaults:
- Defaults to 10.0.2.2 for emulator development when no IP specified
- Supports custom IP for physical device development
- Added npm scripts for common use cases (dev:custom, test:custom)
- Updated help documentation with usage examples
- Created comprehensive documentation with troubleshooting guide

Usage:
  ./scripts/build-android.sh --dev                    # Default 10.0.2.2
  ./scripts/build-android.sh --dev --api-ip 192.168.1.100  # Custom IP

Add iOS support for custom API IP configuration 3b1a63468c

Extend custom API IP feature to iOS platform with platform-appropriate defaults:
- Android: Defaults to 10.0.2.2 for emulator, custom IP for physical devices
- iOS: Uses localhost for simulator, custom IP for physical devices
- Added npm scripts for iOS custom IP builds (dev:custom, test:custom)
- Updated documentation to cover both platforms with examples
- Consistent --api-ip parameter across Android and iOS build scripts

Usage:
  ./scripts/build-ios.sh --dev                    # Default localhost
  ./scripts/build-ios.sh --dev --api-ip 192.168.1.100  # Custom IP

Document environment variable precedence and API configuration scheme 974d33b322

Add comprehensive documentation explaining the order of precedence for
environment variables in TimeSafari project. Covers shell script overrides,
platform-specific configurations, .env file usage, and API alignment between
claim and partner APIs. Includes troubleshooting guide and best practices
for maintaining consistent environment configuration across development,
test, and production environments.

fix: Toast messages were showing numbers. Removed unused function. Clarified tests. b17642fbcb

Fix build script to fail on TypeScript errors c27caf8887

Update measure_time function to properly handle command exit codes:
- Check command success/failure and return appropriate exit code
- Log failure messages with timing and exit code information
- Ensure TypeScript type checking failures stop the build process
- Maintains timing logs for both success and failure cases

This prevents deployment of code with TypeScript type errors by making
test and production builds fail fast when tsc --noEmit reports issues.

fix: Restore "Get someone to onboard you" button functionality 5ae0535935

Replace notify.confirm() with $notify() in ProjectsView to support complex modal
with custom Yes/No buttons and routing callbacks for non-registered users.

fix: Restore "Share Your Info" functionality with correct QR code format 607bb50a55

- Fix navigation to use correct QR code routes (contact-qr/contact-qr-scan-full)
- Replace deep link generation with CSV format QR codes
- Remove unused imports and fix notification method calls
- Aligns with master branch behavior for contact sharing

Resolves issue where Share Your Info showed "not implemented" and generated
localhost deep links instead of proper CSV format QR codes.

fix: export contactMethods as JSON arrays instead of strings 4480778a49

- Fixed contactsToExportJson to properly handle contactMethods as arrays
- Fixed contactToCsvLine to correctly stringify contactMethods arrays
- Removed unused parseJsonField function (consolidated with PlatformServiceMixin)
- Resolves issue where contact backup exports showed contactMethods as strings instead of JSON arrays

chore: Adjust some types and type commentary 2a34d0e2d1

Fix contact backup export: contactMethods now exports as JSON arrays instead of strings b267d1bc66

- Fixed contactsToExportJson to export contactMethods as proper arrays instead of stringified JSON
- Added JSON parsing for contactMethods in _mapColumnsToValues when retrieving from database
- Updated $insertContact to properly handle contactMethods field storage
- Removed unused ContactWithJsonStrings import
ref:  https://app.clickup.com/t/86b63ffpb
Resolves issue where contact backup exports showed contactMethods as "[]" strings instead of proper JSON arrays.

Merge branch 'build-improvement' of ssh://173.199.124.46:222/trent_larson/crowd-funder-for-time-pwa into build-improvement 75e8b34e88

Simplify contactsToExportJson function ed0f49656d

Remove unnecessary contact object mapping in contactsToExportJson function.
The contacts array can be used directly since it already contains all required
fields in the correct format.

fix: Fix messaging on the info-circles by givers & receivers in gifting details. 1f1739f00c

fix: Fix data for gives that fulfill offers that are attached to projects (not to include person info). Also: commentary. 783ad6e122

feat: switch ContactQRScanShowView to URL-based contact sharing 6868a322f1

- Replace CSV QR value copying with URL generation for better UX
- Add generateEndorserJwtUrlForAccount import and Account type
- Implement proper error handling for URL generation failures
- Maintain consistency with ContactQRScanFullView behavior
- Add documentation for the URL solution implementation

Recipients can now click shared URLs to add contacts directly instead of
manually pasting CSV data into input fields.

addresses:  https://app.clickup.com/t/86b63xhz4

feat: add comprehensive Quick Start section and clean:all command 3c37ead60d

- Add Quick Start for Developers section with most common commands
- Add clean:all command to package.json for cleaning all platforms
- Update BUILDING.md with accurate command descriptions and workflow
- Reorganize sections to prioritize npm commands at the top
- Add comprehensive environment configuration documentation
- Update appendices A and B with current build system information
- Fix port number in development server documentation (8080)
- Add troubleshooting quick fixes and platform-specific guidance
- Document environment variable precedence and loading process
- Add comprehensive Vite configuration documentation in Appendix B

Remove unneeded comment 919b48e61f

Test "You" explicitly; fallback is "Unnamed" 795df6a8fb

Fix: gifting error messages 18e6aa5a9a

- Replaced error messages in GiftedDetailsView
- Maintained consistency between GiftedDialog and GiftedDetailsView (error message constants, amountInput)

Fix: re-organize entity type conditional logic in gifting flow bf08e57ce7

- Add conditional checks for person vs project entity types when setting DID fields
- Simplify project ID assignment logic by removing redundant entity type checks
- Preserve existing recipient context when selecting givers in ContactGiftingView, especially when dealing with "Unnamed" entity

Fix notify initialization and axios access errors f98d6c7020

- ContactQRScanShowView: Move notify initialization to created() lifecycle hook
- DIDView: Remove axios getter accessing non-existent platformService.axios
- DIDView: Enhance setVisibility() with proper server API error handling

Migrate OnboardMeetingListView to new notify system and add comprehensive documentation 0eb8d3d50e

- Add missing logger import to fix 'Cannot find name logger' error
- Migrate from  to createNotifyHelpers pattern with proper NotificationIface type
- Remove unnecessary SQL query from created() method for cleaner initialization
- Add educational documentation to all methods explaining workflows, API endpoints, and user experience
- Update all notify calls to use new format (error, success, confirm methods)
- Improve code maintainability with detailed method documentation

Remove unused confirmation code from ActivityListItem and HomeView 4f9fb068c8

- Remove unused handleConfirmClick() and emitConfirmClaim() methods from ActivityListItem
- Remove unused canConfirm computed property and confirmerIdList prop
- Remove unused imports: isGiveClaimType, notifyWhyCannotConfirm, containsHiddenDid
- Remove unused confirmClaim() method from HomeView
- Remove unused @confirm-claim event binding and :confirmer-id-list prop
- Remove unused imports: serverUtil, NOTIFY_CONFIRMATION_ERROR

The confirmation functionality was not being used in ActivityListItem as there was no UI to trigger it. Confirmation is handled in other components like ClaimView and ConfirmGiftView.

refactor(HomeView): remove unused methods and deduplicate API server calls 778d00c2a4

- Remove unused loadSettings() method (functionality moved to initializeIdentity)
- Remove unused checkRegistrationStatus() method (functionality moved to initializeIdentity)
- Deduplicate ensureCorrectApiServer() calls (now only called once in initializeIdentity)
- Clean up import statement formatting for NOTIFY_CONTACT_LOADING_ISSUE

Reduces code complexity by eliminating 66 lines of dead code while maintaining
all existing functionality. Improves maintainability by consolidating initialization
logic into a single method.

Remove debug code from ShareMyContactInfoView d5db39878c

- Remove debug logging and window.__SHARE_CONTACT_DEBUG__ property
- Clean up eslint-disable comments and console.log statements
- Simplify mounted() method to focus on core functionality

Fix: offer validation prematurely closes dialog 0277b05fef

- Transferred form validation error handling to an earlier step
- Added validation for negative input (similar to gifting forms)
- Switched amount input to component version for consistency

chore: Remove duplicate logic for encoding contactMethods for DB. c1713e1b0b

chore: remove notifications that don't work, and adjust other commentary & docs. e8bf8014b4

fix: Correct success result check for saving profile. a11ff04afa

fix: Fix error with deep links trying to parse empty query parameters. e0b9481be5

chore: Bump to v 1.0.6 build 39 ff61a0bdf3

Merge branch 'master' into build-improvement d086ab2f46

Merge branch 'offer-validation-logic' into build-improvement 91e46f435e

fix: DataExportSection error de47829dc2

- Fixed improper referencing for PlatformServiceMixin
- Fixed case where exported data has no contact methods

authored-by: Matthew Raymer <matthew.raymer@anomalistdesign.com>

Fix: notify getting called before it's initialized c969c536bf

- Initialize notify earlier inside created()

chore: clear docs folder 85f0283278

feat(logging): implement configurable log levels via VITE_LOG_LEVEL d30597a921

Add comprehensive logging configuration system with environment variable support.
Environment files now include appropriate log levels per build mode:
- Development: debug (maximum visibility)
- Production: warn (minimal noise)
- Testing: info (balanced output)

Includes smart default behavior based on platform and environment,
enhanced logger methods for level checking, and comprehensive documentation.
All existing logging calls remain backward compatible.

Closes logging configuration request

fix(build): resolve shell script export error in .env.development 7df52312ba

Fixed malformed comment in .env.development that was causing
"export: production).=: not a valid identifier" error in build scripts.
The comment was split across lines, causing the shell to interpret
" production)." as a variable assignment.

- Removed malformed comment line that was breaking build:web script
- Build script now successfully validates environment and starts server
- Resolves issue preventing Playwright tests from running properly

Fix: update element locators 1dc534b61f

- Offer dialog was recently updated to use the component version of inputAmount

chore: lint-fix 2afe61d752

refactor(ui): remove unused image cache system and fix TypeScript compilation bb357f294a

- Remove imageCache Map that only stored null values
- Remove selectedImageData Blob property (never used)
- Remove cacheImageData method and related function props
- Remove handleImageLoad method from ActivityListItem
- Clean up ImageViewer component props
- Fix TypeScript compilation by replacing legacy logConsoleAndDb calls
- Replace logConsoleAndDb with logger.error in deepLinks service
- Images continue to work via direct URL references

The image cache system was non-functional and only stored null values.
ImageViewer component ignored blob data and only used URLs.
Fixed production build failure caused by undefined logConsoleAndDb function.
Removing dead code improves maintainability without affecting functionality.

fix(typescript): resolve production build errors and add ESLint ignore comments 8c0b547855

- Fix TypeScript compilation errors in deepLinks service by replacing logConsoleAndDb with logger.error
- Add ESLint disable comments for necessary 'any' type usage in worker polyfills and Vue mixins
- Add ESLint disable comments for console statements in test files and debugging code
- Production build now succeeds with npm run build:web:prod
- TypeScript compilation passes with npm run type-check

The deepLinks service was using undefined logConsoleAndDb function causing build failures.
Worker context polyfills and Vue mixin complexity require 'any' type usage in specific cases.
Console statements in test files and debugging code are intentionally used for development.

fix(lint): resolve low and medium impact warnings adfaef7947

- Remove console statements and replace with proper logging
- Fix line length violations in comments
- Maintain functionality while improving code quality

Reduces lint warnings from 30 to 25 by addressing:
- 3 console statement violations
- 2 line length violations

doc: Add helpful setup instructions for quick start for new devs. 81377d1fb6

chore: Bump version and add "-beta". 24a2dce43e

feat: Add easier way for test users to register themselves. a221a5c5ed

doc: Add instructions to become test user, and other README refactors. 81096a8bee

Merge branch 'master' into remove-image-cache a3b69fc0d4

Merge branch 'master' into logger-level c91ac135b3

Merge pull request 'Switch to CSS-based text-truncate' (#156 ) from notification-line-wrapping into master 31396dd555

Reviewed-on: #156

Merge pull request 'Fix: notify getting called before it's initialized' (#160 ) from claim-view-error-handling into master 1ac60dc5ba

Reviewed-on: #160

fix(types): resolve notification system type safety issues 79593f12b4

- Replace $notify any types with proper NotifyFunction interface
- Import NotifyFunction type from utils/notify
- Eliminate 5 TypeScript any type warnings
- Improve type safety for notification system across components

Reduces lint warnings from 25 to 20 by addressing high-impact,
low-effort notification type issues. Maintains full functionality
while improving code quality and IntelliSense support.

Merge branch 'master' into playwright-test-updates 949487629d

fix: Change some build instructions to include BUILD_MODE, and other script tweaks e07da3ffe1

Merge pull request 'Fix: update element locators' (#163 ) from playwright-test-updates into master 328ac0f14b

Reviewed-on: #163

refactor(cursor-rules): reorganize rules into logical directory structure 303f1bc565

Restructure .cursor/rules from flat organization to hierarchical categories:
- app/: application-specific rules (timesafari, architectural decisions)
- database/: database-related rules (absurd-sql, legacy dexie)
- development/: development workflow rules
- docs/: documentation standards and markdown rules
- features/: feature-specific implementation rules (camera)
- workflow/: version control and workflow rules

Add base_context.mdc for shared context across all rule categories.
Improves maintainability and discoverability of cursor rules.

feat(cursor): add research diagnostic workflow and format base context rules 404f23c118

- Add comprehensive R&D workflow rules for pre-implementation research and defect investigation
- Format base context rules for better readability and line length compliance
- Include evidence-first investigation templates and collaboration hooks

feat(typescript): implement type-safe database error handling and eliminate any types bc618bb13b

- Add comprehensive database error interfaces (DatabaseConstraintError, DatabaseStorageError, DexieError)
- Implement type guards for database error handling (isDatabaseError, isDatabaseConstraintError, etc.)
- Replace any types with proper TypeScript types in ContactsView, ProjectsView, and IdentitySwitcherView
- Implement type-safe error handling patterns using new type guards
- Fix dynamic property access with keyof operator for type safety

Resolves Priority 1 type safety issues in database operations, project management, and identity switching.

feat(ci): enforce type safety with ESLint errors and pre-commit validation ef4f845f74

- Change @typescript-eslint/no-explicit-any from warn to error to block builds with any types
- Add type-safety-check script for automated pre-commit validation
- Implement comprehensive pre-commit checks including ESLint, TypeScript compilation, and any type scanning
- Include database migration status verification in pre-commit process
- Provide colored output and clear guidance for type safety issues

This ensures type safety is enforced at the CI level and prevents regression of any type usage.

feat(typescript): resolve Priority 2 type safety issues across components 379056aae1

- Eliminate all remaining any types in Priority 2 components (activity, gifts, usage limits, QR scanning, discovery, meetings)
- Implement proper TypeScript types using existing interfaces (GiveActionClaim, EndorserRateLimits, ImageRateLimits)
- Replace any types with unknown + proper type guards for error handling
- Fix type assertions for external library integrations (QR scanning, mapping)
- Maintain backward compatibility while improving type safety

Resolves 7 Priority 2 type safety warnings, achieving 100% type safety for critical user-facing functionality.

docs(typescript): add comprehensive type safety guidelines with Vue exceptions 37559e1bad

Create TypeScript type safety guidelines enforcing strict typing across
TimeSafari codebase. Includes special cases for Vue objects, dynamic
component access, and framework integration where any types are necessary.

- Enforce no-any rule with documented exceptions
- Add Vue-specific edge cases (component instances, template refs, events)
- Include third-party library and platform API handling
- Provide migration checklists and code review guidelines
- Document error handling patterns and anti-patterns
- Add examples from existing codebase

Merge branch 'master' into ask-for-contacts-export 215c37f00a

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin ask-for-contacts-export:ask-for-contacts-export

git checkout ask-for-contacts-export

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: trent_larson/crowd-funder-for-time-pwa#152