Extract notification section into reusable component
#150
Open
anomalist
wants to merge 9 commits from notification-section into master
pull from: notification-section
merge into: trent_larson:master
trent_larson:account-import-duplicate-prevention
trent_larson:active_did_redux
trent_larson:activedid_migration
trent_larson:ai-context
trent_larson:android-15-check
trent_larson:android-file-save
trent_larson:android-safe-area-insets
trent_larson:app_id_fix
trent_larson:ask-for-contacts-export
trent_larson:build-dev-to-dist
trent_larson:build-improvement
trent_larson:build-ios
trent_larson:build-web-serve-test
trent_larson:build-with-env
trent_larson:capacitor-local-save
trent_larson:claim-view-error-handling
trent_larson:claimview-fullfills-offer
trent_larson:clean-db-disconnects
trent_larson:contact-gifting-current-user
trent_larson:contacts-view-fixes
trent_larson:cross-platform-factory
trent_larson:cross-platform-factory-redux
trent_larson:d9085ced6df7dc7bdcd899959cea6489cab7f8b8
trent_larson:db-backup-cross-platform
trent_larson:deep-link
trent_larson:deep-link-views-safe-area-inset
trent_larson:deep-links-android-update
trent_larson:deep_linking
trent_larson:design-tweaks-2023-12
trent_larson:dialog-notification-z-index
trent_larson:dialog-styles-unified
trent_larson:didview-invalid-did-handling
trent_larson:electron-build-capacitor-config
trent_larson:electron-build-config-overwrite
trent_larson:electron-copy-paste-keyboard-shortcuts
trent_larson:electron_fix_20250317
trent_larson:emojis
trent_larson:entity-selection-list-component
trent_larson:experimental_plugin
trent_larson:eye-slash
trent_larson:fix-contact-import-export
trent_larson:fix-deep-link
trent_larson:fix-service-worker
trent_larson:friend-tech-inspired-pwa-dialog
trent_larson:get-get-hash
trent_larson:gifting-periphery-improvements
trent_larson:gifting-ui-2025-05
trent_larson:home-icon-enhancements
trent_larson:home-view-notification-improvements
trent_larson:homeview-cleanup-2025-03
trent_larson:homeview-refresh-2025-02
trent_larson:imagemagick-anrdoid
trent_larson:ios-contact-copy
trent_larson:ios-disable-zoom
trent_larson:ios-qr-code-copy
trent_larson:load-build-mode-env-file
trent_larson:logger-level
trent_larson:logging-upgrade
trent_larson:main
trent_larson:master
trent_larson:master-patch
trent_larson:master-settings-upgrade
trent_larson:matthew-scratch-2025-06-28
trent_larson:meeting-members-admission-dialog
trent_larson:meeting-members-admission-improvements
trent_larson:meeting-members-set-visibility
trent_larson:migrate-dexie-to-sqlite
trent_larson:nearby-filter
trent_larson:new-activity-mark-read
trent_larson:new-storage
trent_larson:nostr
trent_larson:notification-line-wrapping
trent_larson:notification-request-permission-dialog
trent_larson:notification-system
trent_larson:notify-initialization-fix
trent_larson:notify-time
trent_larson:offer-edit
trent_larson:offer-validation-logic
trent_larson:onboard-alert-component
trent_larson:onboarding-dialog-fix
trent_larson:passkey
trent_larson:passkey-cache
trent_larson:performance-optimizations-testing
trent_larson:photo-reverse
trent_larson:plan-loc
trent_larson:platformservicemixin-interface-consolidation
trent_larson:playwright-pwa-install-test
trent_larson:playwright-test-00-fix
trent_larson:playwright-test-60-fix
trent_larson:playwright-test-updates
trent_larson:profile-pic
trent_larson:profile_include_location
trent_larson:project-gives
trent_larson:projectview-hide-offer-link-unregistered
trent_larson:qrcode-capacitor
trent_larson:registration-gate
trent_larson:registration-prompt-parity
trent_larson:remove-cannot-upload-images-notification
trent_larson:remove-image-cache
trent_larson:replace-iconrenderer
trent_larson:search-map-fix
trent_larson:seed-phrase-backup-prompt
trent_larson:side_step
trent_larson:simple-signer
trent_larson:split_build_process
trent_larson:sql-absurd-sql
trent_larson:sql-absurd-sql-further
trent_larson:sql-wa-sqlite
trent_larson:star-projects
trent_larson:star-projects2
trent_larson:starred-projects
trent_larson:streamline-attempt
trent_larson:sw-cleanup
trent_larson:switching-identities-change-name
trent_larson:tmp
trent_larson:trent-tweaks
trent_larson:tweaks
trent_larson:ui-fixes-2024-03
trent_larson:ui-fixes-2025-03
trent_larson:ui-fixes-2025-06-w2
trent_larson:units-mocking
trent_larson:v-onboarding-2024-04
trent_larson:view-headings-refresh
trent_larson:vite-version
trent_larson:web-serve-fix
trent_larson:web-tests
trent_larson:wip_new_notifications
9 Commits
| Author | SHA1 | Message | Date |
|---|---|---|---|
|
|
3eecef6d32 |
feat(harbor-pilot): add no time estimates rule and integrate with main directive
Add new Harbor Pilot rule that prohibits time estimates and instead focuses on phases, milestones, and complexity-based planning. Integrate the rule into main Harbor Pilot directive for automatic application. - Replace time estimation with phase-based planning framework - Focus on complexity categories and dependencies instead of deadlines - Integrate rule into main Harbor Pilot system for consistency |
2 months ago |
|
|
9122974fc9 |
refactor(notifications): clean up historical comments and integrate Harbor Pilot rules
- Transform obsolete historical comments into actionable architectural guidance - Remove references to removed turnOffNotifyingFlags method - Update notification settings cleanup comments to reflect current architecture - Create new Harbor Pilot rule for historical comment management - Integrate historical comment management into main Harbor Pilot directive - Improve code clarity for future developers by documenting architectural evolution Addresses team feedback about historical comment value and maintains important migration context while removing clutter. |
2 months ago |
|
|
fbacf740de |
Merge branch 'master' into notification-section
|
2 months ago |
|
|
810bfa1675 |
Merge branch 'master' into notification-section
|
2 months ago |
|
|
cf34952c1f |
Merge branch 'master' into notification-section
|
2 months ago |
|
|
7e5c16446f |
docs(architecture): enhance component creation MDC rules with concision framework
- Added Concision-First Decision Framework to guide component creation - Included Rule of Three guardrail for when to extract components - Added practical PR language guidance for code reviews - Enhanced agent role to prefer concision where appropriate - Restored priority levels, cross-references, and version history - Updated examples to reflect successful NotificationSection refactor - Enhanced .cursor/rules/component-creation-ideals.mdc to v2.0.0 - Added comprehensive migration patterns and testing guidelines - Established architectural standards for future component development |
2 months ago |
|
|
d62178bca5 |
refactor(notification): extract business logic to NotificationSettingsService
- Created NotificationSettingsService class for settings and permission logic - Separates business logic from UI presentation in NotificationSection - Maintains component lifecycle boundary while improving testability - Service handles settings hydration, persistence, and permission management - Component now focuses purely on UI with computed properties for template access - Added src/composables/useNotificationSettings.ts - Updated src/components/NotificationSection.vue to use service - Resolved TypeScript type issues with PlatformServiceMixin integration |
2 months ago |
|
|
1f716100fd |
Merge branch 'master' into notification-section
|
2 months ago |
|
|
0493f4f061 |
Extract notification section into reusable component
- Created NotificationSection.vue with complete notification functionality - Updated AccountViewView to use new component via props - Removed notification methods from AccountViewView - Fixed FontAwesome import to use FontAwesomeIcon - Cleaned up unused imports and dependencies |
3 months ago |