Extract notification section into reusable component #150

Open
anomalist wants to merge 9 commits from notification-section into master

9 Commits

Author SHA1 Message Date
Matthew Raymer
3eecef6d32 feat(harbor-pilot): add no time estimates rule and integrate with main directive
Add new Harbor Pilot rule that prohibits time estimates and instead
focuses on phases, milestones, and complexity-based planning. Integrate
the rule into main Harbor Pilot directive for automatic application.

- Replace time estimation with phase-based planning framework
- Focus on complexity categories and dependencies instead of deadlines
- Integrate rule into main Harbor Pilot system for consistency
2025-08-21 04:41:43 +00:00
Matthew Raymer
9122974fc9 refactor(notifications): clean up historical comments and integrate Harbor Pilot rules
- Transform obsolete historical comments into actionable architectural guidance
- Remove references to removed turnOffNotifyingFlags method
- Update notification settings cleanup comments to reflect current architecture
- Create new Harbor Pilot rule for historical comment management
- Integrate historical comment management into main Harbor Pilot directive
- Improve code clarity for future developers by documenting architectural evolution

Addresses team feedback about historical comment value and maintains
important migration context while removing clutter.
2025-08-21 04:17:35 +00:00
Matthew Raymer
fbacf740de Merge branch 'master' into notification-section 2025-08-21 03:57:16 +00:00
810bfa1675 Merge branch 'master' into notification-section 2025-08-20 23:48:16 -04:00
Matthew Raymer
cf34952c1f Merge branch 'master' into notification-section 2025-08-21 03:46:35 +00:00
Matthew Raymer
7e5c16446f docs(architecture): enhance component creation MDC rules with concision framework
- Added Concision-First Decision Framework to guide component creation
- Included Rule of Three guardrail for when to extract components
- Added practical PR language guidance for code reviews
- Enhanced agent role to prefer concision where appropriate
- Restored priority levels, cross-references, and version history
- Updated examples to reflect successful NotificationSection refactor

- Enhanced .cursor/rules/component-creation-ideals.mdc to v2.0.0
- Added comprehensive migration patterns and testing guidelines
- Established architectural standards for future component development
2025-08-15 09:07:49 +00:00
Matthew Raymer
d62178bca5 refactor(notification): extract business logic to NotificationSettingsService
- Created NotificationSettingsService class for settings and permission logic
- Separates business logic from UI presentation in NotificationSection
- Maintains component lifecycle boundary while improving testability
- Service handles settings hydration, persistence, and permission management
- Component now focuses purely on UI with computed properties for template access

- Added src/composables/useNotificationSettings.ts
- Updated src/components/NotificationSection.vue to use service
- Resolved TypeScript type issues with PlatformServiceMixin integration
2025-08-15 09:07:28 +00:00
Matthew Raymer
1f716100fd Merge branch 'master' into notification-section 2025-08-15 08:22:41 +00:00
Matthew Raymer
0493f4f061 Extract notification section into reusable component
- Created NotificationSection.vue with complete notification functionality
- Updated AccountViewView to use new component via props
- Removed notification methods from AccountViewView
- Fixed FontAwesome import to use FontAwesomeIcon
- Cleaned up unused imports and dependencies
2025-07-30 11:59:23 +00:00