add separate screen for amount confirmations #15

trentlarson · 2023-03-25T04:08:33Z

trentlarson commented

2023-03-25 04:08:33 +00:00

Well, this is now a significant one:

It has the separate screen for seeing all given items and for confirming them.
It also has the ability to switch between accounts. Just go to /import-account and import another one and you can switch between them on the /account screen.

I plan to do one more round of tests tomorrow, and maybe some small tweaks before I'm ready for prime time, but this is ready for review.

Well, this is now a significant one: * It has the separate screen for seeing all given items and for confirming them. * It also has the ability to switch between accounts. Just go to /import-account and import another one and you can switch between them on the /account screen. I plan to do one more round of tests tomorrow, and maybe some small tweaks before I'm ready for prime time, but this is ready for review.

trentlarson added 2 commits 2023-03-25 04:08:33 +00:00

fix unconfirmed give display, and add alert on success c6bb7b9d42

feat: add a page for details about contact transactions (which I'll fill in soon) 9317b59231

trentlarson reviewed 2023-03-25 04:11:42 +00:00

src/views/ContactAmountsView.vue Outdated

						
				@@ -0,0 +58,4 @@

				@Options({})

				export default class ContactsView extends Vue {

				  contact: Contact | null = null;

trentlarson commented

2023-03-25 04:11:42 +00:00

At first I tried this:

contact?: Contact;

... but it complained at me in the console:

[Vue warn]: Property "contactName" was accessed during render but is not defined on instance.

... and it wouldn't load my information -- even though the "contacts.get" a few lines lower loads the right entry, the rest of the page wouldn't recognize that I set this.contact (or any other this value)... it was like the page was broken.

So... this works, but it doesn't seem clean, and if there's a better way than I'm all ears.

At first I tried this: `contact?: Contact;` ... but it complained at me in the console: `[Vue warn]: Property "contactName" was accessed during render but is not defined on instance. ` ... and it wouldn't load my information -- even though the "contacts.get" a few lines lower loads the right entry, the rest of the page wouldn't recognize that I set `this.contact` (or any other `this` value)... it was like the page was broken. So... this works, but it doesn't seem clean, and if there's a better way than I'm all ears.

anomalist commented

2023-03-28 08:09:09 +00:00

Have you tried:

contact: Nullable<Contact>;

?

Have you tried: `contact: Nullable<Contact>;` ?

trentlarson commented

2023-03-28 22:43:32 +00:00

Both lint & Web Storm say that is not defined