trent_larson
/
crowd-funder-for-time-pwa
4
1
Fork 2
Code Pull Requests 11 Releases 5 Wiki Activity
Labels Milestones

WIP: begin corrections for builds in specific environments (dev/test/prod) #146

Open
trentlarson wants to merge 12 commits from build-with-env into build-improvement
Conversation 0 Commits 12 Files Changed 38
trentlarson commented 3 weeks ago
Owner

This was started in order to fix the variables like VITE_APP_SERVER for the deep-links, and these changes helped fix that -- and I realize there is more to do to spread these consistently throughout the codebase, but I figure I should get more input before proceeding.

  • Overall, there's a difference between the target platform (eg. web, capacitor, electron) and the target deployment (eg. dev, test, prod). So I moved the deployment to the NODE_ENV setting.

  • I made that setting required so that there's no confusion when building for one of our platforms.

  • I didn't know the purpose of the vite.config.ts/mts files so I removed them.

  • I like the short names dev/test/prod (rather than development/test/production) but I can be convinced otherwise.

  • I'd like to remove the tsconfig.node.tsbuildinfo file... seems like it might be a generated file, and things like this say it's not necessary to version control: https://github.com/vercel/next.js/discussions/30815

This was started in order to fix the variables like VITE_APP_SERVER for the deep-links, and these changes helped fix that -- and I realize there is more to do to spread these consistently throughout the codebase, but I figure I should get more input before proceeding. * Overall, there's a difference between the target platform (eg. web, capacitor, electron) and the target deployment (eg. dev, test, prod). So I moved the deployment to the NODE_ENV setting. * I made that setting required so that there's no confusion when building for one of our platforms. * I didn't know the purpose of the vite.config.ts/mts files so I removed them. * I like the short names dev/test/prod (rather than development/test/production) but I can be convinced otherwise. * I'd like to remove the tsconfig.node.tsbuildinfo file... seems like it might be a generated file, and things like this say it's not necessary to version control: https://github.com/vercel/next.js/discussions/30815
trentlarson added 4 commits 3 weeks ago
trentlarson added 4 commits 3 weeks ago
trentlarson added 1 commit 3 weeks ago
trentlarson added 1 commit 3 weeks ago
trentlarson changed target branch from master to build-improvement 3 weeks ago
trentlarson added 2 commits 3 weeks ago
This pull request has changes conflicting with the target branch.
package.json
src/libs/endorserServer.ts
CHANGELOG.md
BUILDING.md
doc/database-migration-guide.md
index.html
playwright.config-local.ts
src/components/DataExportSection.vue
.gitignore
README.md
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
No items
No Label
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'build-with-env'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes