improvements to gifting-adjacent views #143
Open
jose
wants to merge 29 commits from gifting-periphery-improvements into master
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'gifting-periphery-improvements'
Deleting a branch is permanent. It CANNOT be undone. Continue?
WIP: improvements to gifting-adjacent viewsto improvements to gifting-adjacent views 4 weeks agoNOTE: includes changes from
gifting-ui-2025-05branchselectProject(project: PlanData) {this.giver = {did: project.handleId,A DID is only for a user, so it can never be a project handle.
// We're selecting a giver, so recipient is either a project or the current userif (this.recipientEntityType === "project") {recipient = {did: this.recipientProjectHandleId,A DID can only be a person's DID, not a project handleId.
`${this.name} gave to you`,undefined,undefined,true,Currently, the "open" method on that branch only contains 6 parameters, so there's something missing on that side or something extra on this side.
Note that the ContactGiftingView.vue already contained a projectID.
If that is still useful, help refactor... maybe it's the same as a recipientProjectId and it should be renamed, or maybe it's different and we should add some commentary on when to use the different projectIds (eg. fromProjectId, toProjectId, giverProjectId, and even the handle IDs).
If that is not useful because it's been replaced, then let's refactor that way.
Feel free to take the time to make the code understandable, and make sure it all makes sense to you.