improvements to gifting-adjacent views #143

Open

jose wants to merge 28 commits from gifting-periphery-improvements into master

jose commented 5 days ago

Owner

There is no content yet.

jose added 19 commits 5 days ago

579cecbe6e WIP: gifting UI revamp

Started to transform the gifting dialog into the two-step setup as per previous mockups

b511f9cd24 WIP: adjustments to bring closer to original mockups

4b355a5448 WIP: two-step dialog + functionality

- Dialog is now presented as two distinct steps
- Gifting functionality reinstated
- Minor UI tweaks
- IN PROGRESS: ensuring calls to dialog from other parts of the app remain functional

988244b7ae Added check for "Unnamed" giver

Pass string "Unnamed" to select unnamed giver and skip contact selection step of dialog.

140c36a416 Merge branch 'master' into gifting-ui-2025-05

7eefee1ea5 Fix: Conditional show-all link

- Only show "Show All" when user has contacts

3daf1c8a5c Feature: Project Gifting

- Gifting dialog: added ability to pick a project to benefit from
- Project view: modified dialog calls in Project view to toggle between giving to and benefiting from a project
- Project view: removed redundant person selection
- Project view: benefiting from a project locks the project selection in dialog to enforce context.

df1c1f0186 Fix: pass project info

In GiftingDialog, project information is passed along if:
- Selecting "Show All" to go to ContactGiftingView
- Selecting "Photos and Other Options" to go to GiftedDetailsView

fa21660fd1 fix spelling

eb7605991c Fixed more gifting use cases

a7e65b3b49 Giver-recipient controls

- Dialog now shows separate cards for giver and recipient
- Ability to change giver and/or recipient
- Project giver/recipient is locked in ProjectView (context reinforcement)

0342c872f4 Fix: added context for ContactGiftingView

d3b80fbe47 Feature: giver-recipient validation

- Ensures person-to-person gifting won't allow the same entity as giver and recipient
- Disable user item selection if it would create conflict
- Error messaging fallback

ca22161f12 Fix: entity-type identifier validation

- Ensure claims contain only correct and necessary giver and recipient identifiers, as per Endorser.ch documentation

357822d713 Fix: truncate text blocks

- Avoid did display stretching screen width

a8cc480960 Merge branch 'master' into gifting-periphery-improvements

ce04312baa Updated amount input controls

Now consistent with gifting dialog version

fe4ae90849 Giver-recipient display fixes

- Truncate very long texts (such as dids)
- Stacked layout in mobile, row layout in wider screens
- Minor design adjustments

c0ddba8898 Various design tweaks

jose added 3 commits 4 days ago

447a7cb089 Style "unnamed" entity

ea49173885 Changed currentStep to boolean

4b539ccc55 Better handling of No-name and Unnamed entities

jose added 1 commit 4 days ago

d8e237f8cb Describe firstStep variable

jose added 1 commit 4 days ago

b6278ca148 Unit codes pulled from util.ts

jose added 2 commits 4 days ago

0e6a9c4f89 adjust grammar for recording receipt

c9405839c3 Merge branch 'gifting-ui-2025-05' into gifting-periphery-improvements

jose added 1 commit 3 days ago

08c46a27d3 Add project-to-project case

jose added 1 commit 2 days ago

bf9fee7ee9 Various aesthetic improvements and optimizations

jose changed title from ~~WIP: improvements to gifting-adjacent views~~ to improvements to gifting-adjacent views 2 days ago

jose commented 2 days ago

Poster

Owner

NOTE: includes changes from gifting-ui-2025-05 branch

trentlarson reviewed 2 days ago

src/components/GiftedDialog.vue

												
					  selectProject(project: PlanData) {
				
					    this.giver = {
				
					      did: project.handleId,

trentlarson commented 2 days ago

Poster

Owner

A DID is only for a user, so it can never be a project handle.

trentlarson reviewed 2 days ago

src/views/ContactGiftingView.vue

												
					        // We're selecting a giver, so recipient is either a project or the current user
				
					        if (this.recipientEntityType === "project") {
				
					          recipient = {
				
					            did: this.recipientProjectHandleId,

trentlarson commented 2 days ago

Poster

Owner

A DID can only be a person's DID, not a project handleId.

trentlarson reviewed 2 days ago

src/views/ProjectViewView.vue

												
					      `${this.name} gave to you`,
				
					      undefined,
				
					      undefined,
				
					      true,

trentlarson commented 2 days ago

Poster

Owner

Currently, the "open" method on that branch only contains 6 parameters, so there's something missing on that side or something extra on this side.

This pull request can be merged automatically.

This branch is out-of-date with the base branch

You are not authorized to merge this pull request.

No reviewers

No Label

No Milestone

No Assignees

2 Participants

Notifications

Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.