trent_larson/crowd-funder-for-time-pwa
4
1
Fork 2
Code Issues Pull Requests 22 Releases 5 Wiki Activity

improvements to gifting-adjacent views #143

Closed
jose wants to merge 0 commits from gifting-periphery-improvements into master
pull from: gifting-periphery-improvements
merge into: trent_larson:master
Conversation 5 Commits - Files Changed -
jose commented 2025-06-24 12:04:41 +00:00
Owner
Copy Link
No description provided.
jose added 19 commits 2025-06-24 12:04:41 +00:00
WIP: gifting UI revamp 579cecbe6e 
Started to transform the gifting dialog into the two-step setup as per previous mockups
WIP: adjustments to bring closer to original mockups b511f9cd24
WIP: two-step dialog + functionality 4b355a5448 
- Dialog is now presented as two distinct steps
- Gifting functionality reinstated
- Minor UI tweaks
- IN PROGRESS: ensuring calls to dialog from other parts of the app remain functional
Added check for "Unnamed" giver 988244b7ae 
Pass string "Unnamed" to select unnamed giver and skip contact selection step of dialog.
Merge branch 'master' into gifting-ui-2025-05 140c36a416
Fix: Conditional show-all link 7eefee1ea5 
- Only show "Show All" when user has contacts
Feature: Project Gifting 3daf1c8a5c 
- Gifting dialog: added ability to pick a project to benefit from
- Project view: modified dialog calls in Project view to toggle between giving to and benefiting from a project
- Project view: removed redundant person selection
- Project view: benefiting from a project locks the project selection in dialog to enforce context.
Fix: pass project info df1c1f0186 
In GiftingDialog, project information is passed along if:
- Selecting "Show All" to go to ContactGiftingView
- Selecting "Photos and Other Options" to go to GiftedDetailsView
fix spelling fa21660fd1
Fixed more gifting use cases eb7605991c
Giver-recipient controls a7e65b3b49 
- Dialog now shows separate cards for giver and recipient
- Ability to change giver and/or recipient
- Project giver/recipient is locked in ProjectView (context reinforcement)
Fix: added context for ContactGiftingView 0342c872f4
Feature: giver-recipient validation d3b80fbe47 
- Ensures person-to-person gifting won't allow the same entity as giver and recipient
- Disable user item selection if it would create conflict
- Error messaging fallback
Fix: entity-type identifier validation ca22161f12 
- Ensure claims contain only correct and necessary giver and recipient identifiers, as per Endorser.ch documentation
Fix: truncate text blocks 357822d713 
- Avoid did display stretching screen width
Merge branch 'master' into gifting-periphery-improvements a8cc480960
Updated amount input controls ce04312baa 
Now consistent with gifting dialog version
Giver-recipient display fixes fe4ae90849 
- Truncate very long texts (such as dids)
- Stacked layout in mobile, row layout in wider screens
- Minor design adjustments
Various design tweaks c0ddba8898
jose added 3 commits 2025-06-25 13:14:44 +00:00
Style "unnamed" entity 447a7cb089
Changed currentStep to boolean ea49173885
Better handling of No-name and Unnamed entities 4b539ccc55
jose added 1 commit 2025-06-25 13:16:51 +00:00
Describe firstStep variable d8e237f8cb
jose added 1 commit 2025-06-25 13:28:04 +00:00
Unit codes pulled from util.ts b6278ca148
jose added 2 commits 2025-06-26 07:27:44 +00:00
adjust grammar for recording receipt 0e6a9c4f89
Merge branch 'gifting-ui-2025-05' into gifting-periphery-improvements c9405839c3
jose added 1 commit 2025-06-26 10:52:29 +00:00
Add project-to-project case 08c46a27d3
jose added 1 commit 2025-06-27 13:59:02 +00:00
Various aesthetic improvements and optimizations bf9fee7ee9
jose changed title from WIP: improvements to gifting-adjacent views to improvements to gifting-adjacent views 2025-06-27 14:03:35 +00:00
jose commented 2025-06-27 14:08:32 +00:00
Author
Owner
Copy Link

NOTE: includes changes from gifting-ui-2025-05 branch

**NOTE**: includes changes from `gifting-ui-2025-05` branch
trentlarson reviewed 2025-06-28 02:08:19 +00:00
src/components/GiftedDialog.vue
@@ -381,0 +1025,4 @@
selectProject(project: PlanData) {
this.giver = {
did: project.handleId,
trentlarson commented 2025-06-28 02:08:19 +00:00
Owner
Copy Link

A DID is only for a user, so it can never be a project handle.

A DID is only for a user, so it can never be a project handle.
trentlarson reviewed 2025-06-28 02:11:44 +00:00
src/views/ContactGiftingView.vue
@@ -158,0 +210,4 @@
// We're selecting a giver, so recipient is either a project or the current user
if (this.recipientEntityType === "project") {
recipient = {
did: this.recipientProjectHandleId,
trentlarson commented 2025-06-28 02:11:44 +00:00
Owner
Copy Link

A DID can only be a person's DID, not a project handleId.

A DID can only be a person's DID, not a project handleId.
trentlarson reviewed 2025-06-28 02:24:52 +00:00
src/views/ProjectViewView.vue Outdated
@@ -1288,0 +1269,4 @@
`${this.name} gave to you`,
undefined,
undefined,
true,
trentlarson commented 2025-06-28 02:24:52 +00:00
Owner
Copy Link

Currently, the "open" method on that branch only contains 6 parameters, so there's something missing on that side or something extra on this side.

Currently, the "open" method on that branch only contains 6 parameters, so there's something missing on that side or something extra on this side.
trentlarson added 1 commit 2025-06-30 00:18:50 +00:00
some fixes to the gifted-dialog logic 25512d3db1
trentlarson commented 2025-07-03 13:57:05 +00:00
Owner
Copy Link

Note that the ContactGiftingView.vue already contained a projectID.

  • If that is still useful, help refactor... maybe it's the same as a recipientProjectId and it should be renamed, or maybe it's different and we should add some commentary on when to use the different projectIds (eg. fromProjectId, toProjectId, giverProjectId, and even the handle IDs).

  • If that is not useful because it's been replaced, then let's refactor that way.

Feel free to take the time to make the code understandable, and make sure it all makes sense to you.

Note that the ContactGiftingView.vue already contained a projectID. * If that is still useful, help refactor... maybe it's the same as a recipientProjectId and it should be renamed, or maybe it's different and we should add some commentary on when to use the different projectIds (eg. fromProjectId, toProjectId, giverProjectId, and even the handle IDs). * If that is not useful because it's been replaced, then let's refactor that way. Feel free to take the time to make the code understandable, and make sure it all makes sense to you.
anomalist closed this pull request 2025-08-13 05:09:43 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
trentlarson
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
anomalist jose jsnbuchanan kentbull trentlarson
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: trent_larson/crowd-funder-for-time-pwa#143
Delete Branch "gifting-periphery-improvements"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?