gifting-ui-2025-05 #140

Closed

jose wants to merge 15 commits from gifting-ui-2025-05 into master

jose commented 1 week ago

Owner

NEW:

Dialog now shows separate cards for giver and recipient
Ability to change giver and/or recipient

PENDING:

Add logic to prevent setting the same person entity as the giver and recipient
Test all gifting use cases

jose added 11 commits 1 week ago

579cecbe6e WIP: gifting UI revamp

Started to transform the gifting dialog into the two-step setup as per previous mockups

b511f9cd24 WIP: adjustments to bring closer to original mockups

4b355a5448 WIP: two-step dialog + functionality

- Dialog is now presented as two distinct steps
- Gifting functionality reinstated
- Minor UI tweaks
- IN PROGRESS: ensuring calls to dialog from other parts of the app remain functional

988244b7ae Added check for "Unnamed" giver

Pass string "Unnamed" to select unnamed giver and skip contact selection step of dialog.

140c36a416 Merge branch 'master' into gifting-ui-2025-05

7eefee1ea5 Fix: Conditional show-all link

- Only show "Show All" when user has contacts

3daf1c8a5c Feature: Project Gifting

- Gifting dialog: added ability to pick a project to benefit from
- Project view: modified dialog calls in Project view to toggle between giving to and benefiting from a project
- Project view: removed redundant person selection
- Project view: benefiting from a project locks the project selection in dialog to enforce context.

df1c1f0186 Fix: pass project info

In GiftingDialog, project information is passed along if:
- Selecting "Show All" to go to ContactGiftingView
- Selecting "Photos and Other Options" to go to GiftedDetailsView

fa21660fd1 fix spelling

eb7605991c Fixed more gifting use cases

a7e65b3b49 Giver-recipient controls

- Dialog now shows separate cards for giver and recipient
- Ability to change giver and/or recipient
- Project giver/recipient is locked in ProjectView (context reinforcement)

jose added 1 commit 1 week ago

0342c872f4 Fix: added context for ContactGiftingView

jose added 2 commits 1 week ago

d3b80fbe47 Feature: giver-recipient validation

- Ensures person-to-person gifting won't allow the same entity as giver and recipient
- Disable user item selection if it would create conflict
- Error messaging fallback

ca22161f12 Fix: entity-type identifier validation

- Ensure claims contain only correct and necessary giver and recipient identifiers, as per Endorser.ch documentation

trentlarson commented 4 days ago

Owner

Great.

Is this finished? (If so, you can take off the WIP.)

jose changed title from ~~WIP: gifting-ui-2025-05~~ to gifting-ui-2025-05 4 days ago

trentlarson added 1 commit 1 day ago

0e6a9c4f89 adjust grammar for recording receipt

jose commented 6 minutes ago

Poster

Owner

NOTE: changes in this branch have already been carried over to gifting-periphery-improvements branch.

jose closed this pull request 6 minutes ago

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No Assignees

2 Participants

Notifications

Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.