trent_larson/crowd-funder-for-time-pwa
4
1
Fork 2
Code Issues Pull Requests 22 Releases 5 Wiki Activity

gifting-ui-2025-05 #140

Closed
jose wants to merge 0 commits from gifting-ui-2025-05 into master
pull from: gifting-ui-2025-05
merge into: trent_larson:master
Conversation 2 Commits - Files Changed - +1040 -258
jose commented 2025-06-19 13:35:14 +00:00
Owner
Copy Link

NEW:

  • Dialog now shows separate cards for giver and recipient
  • Ability to change giver and/or recipient

PENDING:

  • Add logic to prevent setting the same person entity as the giver and recipient
  • Test all gifting use cases
NEW: - Dialog now shows separate cards for giver and recipient - Ability to change giver and/or recipient PENDING: - Add logic to prevent setting the same person entity as the giver and recipient - Test all gifting use cases
jose added 11 commits 2025-06-19 13:35:15 +00:00
WIP: gifting UI revamp 579cecbe6e 
Started to transform the gifting dialog into the two-step setup as per previous mockups
WIP: adjustments to bring closer to original mockups b511f9cd24
WIP: two-step dialog + functionality 4b355a5448 
- Dialog is now presented as two distinct steps
- Gifting functionality reinstated
- Minor UI tweaks
- IN PROGRESS: ensuring calls to dialog from other parts of the app remain functional
Added check for "Unnamed" giver 988244b7ae 
Pass string "Unnamed" to select unnamed giver and skip contact selection step of dialog.
Merge branch 'master' into gifting-ui-2025-05 140c36a416
Fix: Conditional show-all link 7eefee1ea5 
- Only show "Show All" when user has contacts
Feature: Project Gifting 3daf1c8a5c 
- Gifting dialog: added ability to pick a project to benefit from
- Project view: modified dialog calls in Project view to toggle between giving to and benefiting from a project
- Project view: removed redundant person selection
- Project view: benefiting from a project locks the project selection in dialog to enforce context.
Fix: pass project info df1c1f0186 
In GiftingDialog, project information is passed along if:
- Selecting "Show All" to go to ContactGiftingView
- Selecting "Photos and Other Options" to go to GiftedDetailsView
fix spelling fa21660fd1
Fixed more gifting use cases eb7605991c
Giver-recipient controls a7e65b3b49 
- Dialog now shows separate cards for giver and recipient
- Ability to change giver and/or recipient
- Project giver/recipient is locked in ProjectView (context reinforcement)
jose added 1 commit 2025-06-20 07:50:41 +00:00
Fix: added context for ContactGiftingView 0342c872f4
jose added 2 commits 2025-06-20 12:36:58 +00:00
Feature: giver-recipient validation d3b80fbe47 
- Ensures person-to-person gifting won't allow the same entity as giver and recipient
- Disable user item selection if it would create conflict
- Error messaging fallback
Fix: entity-type identifier validation ca22161f12 
- Ensure claims contain only correct and necessary giver and recipient identifiers, as per Endorser.ch documentation
trentlarson commented 2025-06-23 03:05:10 +00:00
Owner
Copy Link

Great.

Is this finished? (If so, you can take off the WIP.)

Great. Is this finished? (If so, you can take off the WIP.)
jose changed title from WIP: gifting-ui-2025-05 to gifting-ui-2025-05 2025-06-23 07:16:23 +00:00
trentlarson added 1 commit 2025-06-26 02:52:13 +00:00
adjust grammar for recording receipt 0e6a9c4f89
jose commented 2025-06-27 14:07:30 +00:00
Author
Owner
Copy Link

NOTE: changes in this branch have already been carried over to gifting-periphery-improvements branch.

**NOTE**: changes in this branch have already been carried over to `gifting-periphery-improvements` branch.
jose closed this pull request 2025-06-27 14:07:40 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
anomalist jose jsnbuchanan kentbull trentlarson
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: trent_larson/crowd-funder-for-time-pwa#140
Delete Branch "gifting-ui-2025-05"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?