trent_larson
/
crowd-funder-for-time-pwa
4
1
Fork 2
Code Pull Requests 4 Releases 5 Wiki Activity
Labels Milestones

feat(feed): Images in the home feed now take up the full width of the card and displays in lightbox when clicked #124

Merged
jsnbuchanan merged 9 commits from jsnbuchanan/crowd-funder-for-time-pwa:fix/adding-nostr-tools-dependency into feat/image-feed-view-improvements 6 days ago
Conversation 5 Commits 9 Files Changed 5
jsnbuchanan commented 2 weeks ago
Owner

Fixed

  • upgrading nostr-tools dependency and update the import to be more conventional
### Fixed - upgrading nostr-tools dependency and update the import to be more conventional
jsnbuchanan added 4 commits 2 weeks ago
7ce00b86e8
deps: npm audit fix to resolve vulnerabilities 1 low, 3 moderate, 1 high
trentlarson commented 2 weeks ago
Owner

Anybody know a way to check out this branch inside the trent_larson repo to test it? (I'm guessing not... but it'd be nice to submit PRs in a way where we don't have to check out the other person's repo.) @anomalist

Anybody know a way to check out this branch inside the trent_larson repo to test it? (I'm guessing not... but it'd be nice to submit PRs in a way where we don't have to check out the other person's repo.) @anomalist
👍 1
trentlarson commented 2 weeks ago
Owner

So, Jason: note that this PR does remove the types so it probably passes typechecking, but it also removes the essential functions accountFromExtendedKey and extendedKeysFromSeedWords.

So, Jason: note that this PR does remove the types so it probably passes typechecking, but it also removes the essential functions `accountFromExtendedKey` and `extendedKeysFromSeedWords`.
👍 1
trentlarson commented 2 weeks ago
Owner

One other note: I bet if you run on master, even though you see some error like Missing "./lib/types/core" specifier in "nostr-tools" package, your dev server is probably running on port 8080 so you can try out other UI things while we figure out these type errors.

One other note: I bet if you run on master, even though you see some error like `Missing "./lib/types/core" specifier in "nostr-tools" package`, your dev server is probably running on port 8080 so you can try out other UI things while we figure out these type errors.
👍 1
trentlarson commented 2 weeks ago
Owner

... at least, that's what happened on my machine: I got the error, but the server was running OK.

... at least, that's what happened on my machine: I got the error, but the server was running OK.
👍 1
jsnbuchanan force-pushed fix/adding-nostr-tools-dependency from 69eb3f923b to 53a06be734 6 days ago
jsnbuchanan added 1 commit 6 days ago
jsnbuchanan added 1 commit 6 days ago
jsnbuchanan added 1 commit 6 days ago
jsnbuchanan added 1 commit 6 days ago
jsnbuchanan added 1 commit 6 days ago
jsnbuchanan added 1 commit 6 days ago
jsnbuchanan changed title from fix(deps): upgrading nostr-tools dependency and update the import to be more conventional to feat(feed): Images in the home feed now take up the full width of the card and displays in lightbox when clicked 6 days ago
jsnbuchanan commented 6 days ago
Poster
Owner

[0.4.0] - 2025.02.14

Changed

  • Images in the home feed now take up the full width of the card.
  • Clicking the image previously, would open the image in a new tab. Now, clicking the image opens the image in a lightbox view.

Added

  • Clicking an image also now displays an in-app lightbox view of the image.
  • The lightbox view includes a download button for the image in mobile view.
## [0.4.0] - 2025.02.14 ### Changed - Images in the home feed now take up the full width of the card. - Clicking the image previously, would open the image in a new tab. Now, clicking the image opens the image in a lightbox view. ### Added - Clicking an image also now displays an in-app lightbox view of the image. - The lightbox view includes a download button for the image in mobile view.
Screenshot 2025-02-14 at 1.07.17 PM.png
132 KiB
Screenshot 2025-02-14 at 1.07.29 PM.png
216 KiB
jsnbuchanan added 1 commit 6 days ago
jsnbuchanan changed target branch from master to feat/image-feed-view-improvements 6 days ago
jsnbuchanan added 1 commit 6 days ago
jsnbuchanan merged commit f4155e557a into feat/image-feed-view-improvements 6 days ago
jsnbuchanan deleted branch fix/adding-nostr-tools-dependency 6 days ago
The pull request has been merged as f4155e557a.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
No items
No Label
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'jsnbuchanan/crowd-funder-for-time-pwa:fix/adding-nostr-tools-dependency'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes