trent_larson/crowd-funder-for-time-pwa
4
1
Fork 2
Code Issues Pull Requests 23 Releases 5 Wiki Activity

bulk-members-dialog-refactor #218

Merged
jose merged 2 commits from bulk-members-dialog-refactor into master 2025-11-05 08:34:28 +00:00
Conversation 0 Commits 2 Files Changed 2
+57 -99
jose commented 2025-11-04 12:04:13 +00:00
Owner
Copy Link
Copy Source

ClickUp: https://app.clickup.com/t/86b79j4fr

ClickUp: https://app.clickup.com/t/86b79j4fr
jose added 2 commits 2025-11-04 12:04:14 +00:00
refactor: remove redundant dialogType prop from BulkMembersDialog 8b199ec76c 
Remove dialogType prop and consolidate to use only isOrganizer prop.

- Remove dialogType prop from BulkMembersDialog component
- Replace all dialogType checks with isOrganizer boolean checks
- Add comments clarifying isOrganizer true/false meanings
- Remove dialog-type prop binding from MembersList component

This simplifies the component API while maintaining the same functionality.
refactor: combine member processing methods in BulkMembersDialog c06ffec466 
Consolidate organizerAdmitAndAddWithVisibility() and
memberAddContactWithVisibility() into a single unified method
processSelectedMembers() that handles both organizer and member
modes based on the isOrganizer prop.

- Remove redundant handleMainAction() wrapper method
- Update template to call processSelectedMembers directly
- Reduce code duplication by ~30% (140 lines → 98 lines)
- Maintain identical functionality for both modes

This simplifies the component structure and makes the processing
logic easier to maintain.
jose merged commit 1053bb6e4c into master 2025-11-05 08:34:28 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
anomalist jose (Jose Olarte 3) jsnbuchanan kentbull (Kent Bull) trentlarson
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: trent_larson/crowd-funder-for-time-pwa#218