feat: meeting members admission dialog

Conversation 0 Commits 27 Files Changed 8

jose commented 2 weeks ago

Owner

ClickUp: https://app.clickup.com/t/86b75mhhn

jose added 4 commits 2 weeks ago

e9ea89edae feat: enhance members list UI with visual indicators and improved styling

- Sort members list with organizer first, then non-admitted, then admitted
- Add crown icon for meeting organizer identification
- Add spinner icon for non-admitted members
- Implement conditional styling for non-admitted members
- Update button styling to use circle icons instead of rounded backgrounds
- Improve visual hierarchy with better spacing and color coding

035509224b feat: change icon for pending members

- Changed from an animating spinner to a static hourglass

6fbc9c2a5b feat: Add AdmitPendingMembersDialog for bulk member admission

- Add new AdmitPendingMembersDialog component with checkbox selection
- Support two action modes: "Admit + Add Contacts" and "Admit Only"
- Integrate dialog into MembersList with proper sequencing
- Show admit dialog before visibility dialog when pending members exist
- Fix auto-refresh pause/resume logic for both dialogs
- Ensure consistent dialog behavior between initial load and manual refresh
- Add proper async/await handling for data refresh operations
- Optimize dialog state management and remove redundant code
- Maintain proper flag timing to prevent race conditions

The admit dialog now shows automatically when there are pending members,
allowing organizers to efficiently admit multiple members at once while
optionally adding them as contacts and setting visibility preferences.

ad51c187aa Update AdmitPendingMembersDialog.vue

feat: add DID display to Pending Members dialog

- Restructure member display with better visual hierarchy
- Add DID display with responsive truncation for mobile
- Simplify button labels ("Admit + Add Contacts" and "Admit Only")

jose changed title from ~~meeting-members-admission-dialog~~ to feat: meeting members admission dialog 2 weeks ago

trentlarson reviewed 2 weeks ago

src/components/MembersList.vue Outdated

												
					      // If admission status is the same, maintain original order
				
					      return 0;
				
					    });

trentlarson commented 2 weeks ago

Poster

Owner

Nice touch to sort the items!

jose added 3 commits 2 weeks ago

16ed5131c4 feat: restrict dialog access based on user roles

- AdmitPendingMembersDialog now only triggers for meeting organizers
- SetBulkVisibilityDialog now only triggers for members who can see other members
- Removes overly restrictive admission status check for visibility dialog
- Ensures proper role-based access control for meeting management features

e048e4c86b fix: restrict pending member styling to organizers only

- Apply special styling (blue background, grayed text, hourglass icon) only when current user is organizer
- Non-organizers now see consistent styling for all visible members
- Maintains organizer's ability to distinguish between admitted and pending members
- Fixes issue where non-organizers saw inconsistent styling for all members

2f1eeb6700 fix: resolve duplicate names in Visibility dialog after Admit dialog

- Add deduplication logic to getMembersForVisibility() method to prevent duplicate entries
- Fix timing issue with isManualRefresh flag reset in showSetBulkVisibilityDialog()
- Ensure Visibility dialog shows each member only once when following Admit dialog
- Remove debugging console logs after issue resolution

The issue was caused by multiple calls to getMembersForVisibility() returning
duplicate member entries, which were then displayed in the Visibility dialog.
The fix deduplicates members by DID to ensure each member appears only once.

jose changed title from ~~feat: meeting members admission dialog~~ to WIP: feat: meeting members admission dialog 1 week ago

jose added 9 commits 1 week ago

f0f0f1681e chore: move a variable into most local scope

7ea6a2ef69 refactor: simplify logic for opening onboarding dialogs

39173a8db2 fix: linting

9f3c62a29c test: trying the new pre-commit logic (with a bad linting change)

9a94843b68 fix: linting

723a0095a0 feat: prompt user if the pre-commit lint-fix changed anything

9e1c267bc0 refactor: make the meeting member "set visibility" screen much like the organizer's "admit" screen

5c0ce2d1fb fix: linting

e8e00d3eae refactor: remove mistakenly-committed file

jose added 1 commit 7 days ago

1e3ecf6d0f refactor: migrate dialog styles from scoped CSS to Tailwind utilities

- Remove scoped CSS styles for .dialog-overlay and .dialog from AdmitPendingMembersDialog.vue
- Remove scoped CSS overflow style from FeedFilters.vue dialog
- Update Tailwind .dialog utility class to include max-height and overflow-y-auto
- Consolidate dialog styling into reusable Tailwind components for consistency

jose added 1 commit 7 days ago

27e38f583b feat: improve auto-refresh handling during member admission dialogs

- Add stopAutoRefresh() calls before showing confirmation dialogs
- Add startAutoRefresh() calls after dialog interactions complete
- Ensure auto-refresh resumes properly in all dialog callback paths
- Fix missing onCancel handler for contact confirmation dialog

This prevents auto-refresh from interfering with user interactions
during member admission workflows while ensuring it resumes afterward.

jose added 1 commit 7 days ago

966ca8276d refactor: simplify pending members dialog description text

- Replace verbose explanation with concise, direct question
- Streamline the admission dialog interface