Labels Milestones

feat(NewActivityView): enhance "See all" links to mark offers as read before navigation #198

Merged

jose merged 6 commits from new-activity-mark-read into master 2 days ago

Conversation 1 Commits 6 Files Changed 3

jose commented 1 week ago

Owner

• Replace router-links with click handlers for both "See all" offers links
• Add handleSeeAllOffersToUser and handleSeeAllOffersToUserProjects methods
• Modify expandOffersToUserAndMarkRead to accept fromSeeAll parameter for contextual notifications
• Modify expandOffersToUserProjectsAndMarkRead to accept fromSeeAll parameter for contextual notifications
• Show shorter notification messages when called from "See all" vs chevron expand buttons
• Add safety checks to prevent errors when offers arrays are empty
• Standardize notification message text consistency
• TypeScript and formatting lint fixes

Both "See all" links now properly mark offers as viewed before navigation,
preventing users from seeing unread offers in the detailed views.

- Replace router-links with click handlers for both "See all" offers links - Add handleSeeAllOffersToUser and handleSeeAllOffersToUserProjects methods - Modify expandOffersToUserAndMarkRead to accept fromSeeAll parameter for contextual notifications - Modify expandOffersToUserProjectsAndMarkRead to accept fromSeeAll parameter for contextual notifications - Show shorter notification messages when called from "See all" vs chevron expand buttons - Add safety checks to prevent errors when offers arrays are empty - Standardize notification message text consistency - TypeScript and formatting lint fixes Both "See all" links now properly mark offers as viewed before navigation, preventing users from seeing unread offers in the detailed views.

jose added 2 commits 1 week ago

9bdd66b9c9 feat(NewActivityView): enhance "See all" links to mark offers as read before navigation

- Replace router-links with click handlers for both "See all" offers links
- Add handleSeeAllOffersToUser and handleSeeAllOffersToUserProjects methods
- Modify expandOffersToUserAndMarkRead to accept fromSeeAll parameter for contextual notifications
- Modify expandOffersToUserProjectsAndMarkRead to accept fromSeeAll parameter for contextual notifications
- Show shorter notification messages when called from "See all" vs chevron expand buttons
- Add safety checks to prevent errors when offers arrays are empty
- Standardize notification message text consistency
- TypeScript and formatting lint fixes

Both "See all" links now properly mark offers as viewed before navigation,
preventing users from seeing unread offers in the detailed views.

ac603f66e2 Lint fix

jose added 1 commit 5 days ago

c3ff471ea1 Merge branch 'master' into new-activity-mark-read

jose added 1 commit 4 days ago

5d9f455fc8 feat: move mark-as-read logic from navigation to view loading

- Remove mark-as-read logic from NewActivityView navigation handlers
- Add mark-as-read logic to RecentOffersToUserView and RecentOffersToUserProjectsView after data loading
- Improve "You've already seen all the following" marker positioning
- Update marker styling with dashed border and centered text

This ensures the marker appears at the correct position in the list
instead of always at the top, providing better UX when viewing offers.

trentlarson commented 3 days ago

Owner

Looks great!

Looks great!

jose added 1 commit 2 days ago

6fd53b020e refactor: simplify notification messages for offer viewing

- Remove conditional notification logic in NewActivityView
- Remove redundant notification in RecentOffersToUserView and RecentOffersToUserProjectsView
- Standardize to single notification message format

jose added 1 commit 2 days ago

e2c2d54c20 Merge branch 'master' into new-activity-mark-read

jose merged commit 823fa51275 into master 2 days ago

jose referenced this issue from a commit 2 days ago

Merge pull request 'feat(NewActivityView): enhance "See all" links to mark offers as read before navigation' (#198) from new-activity-mark-read into master

The pull request has been merged as 823fa51275.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

Labels

Apply labels

Clear labels

No items

No Label

Milestone

Set milestone

Clear milestone

No items

No Milestone

Assignees

Assign users

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview

Loading…

Cancel

Save

There is no content yet.