feat(feed): Images in the home feed now take up the full width of the card and displays in lightbox when clicked #124

jsnbuchanan · 2025-02-07T17:31:47Z

jsnbuchanan commented

2025-02-07 17:31:47 +00:00

Fixed

upgrading nostr-tools dependency and update the import to be more conventional

### Fixed - upgrading nostr-tools dependency and update the import to be more conventional

jsnbuchanan added 1 commit 2025-02-07 17:31:47 +00:00

deps: npm audit fix to resolve vulnerabilities 1 low, 3 moderate, 1 high 7ce00b86e8

There are still 9 moderate severity vulnerabilities, but I will work on those independentally because they may involve updating to library version that have breaking changes.

trentlarson commented

2025-02-08 23:37:30 +00:00

Anybody know a way to check out this branch inside the trent_larson repo to test it? (I'm guessing not... but it'd be nice to submit PRs in a way where we don't have to check out the other person's repo.) @anomalist

👍 1

trentlarson commented

2025-02-08 23:38:42 +00:00

So, Jason: note that this PR does remove the types so it probably passes typechecking, but it also removes the essential functions accountFromExtendedKey and extendedKeysFromSeedWords.

So, Jason: note that this PR does remove the types so it probably passes typechecking, but it also removes the essential functions `accountFromExtendedKey` and `extendedKeysFromSeedWords`.

👍 1

trentlarson commented

2025-02-08 23:40:18 +00:00

One other note: I bet if you run on master, even though you see some error like Missing "./lib/types/core" specifier in "nostr-tools" package, your dev server is probably running on port 8080 so you can try out other UI things while we figure out these type errors.

One other note: I bet if you run on master, even though you see some error like `Missing "./lib/types/core" specifier in "nostr-tools" package`, your dev server is probably running on port 8080 so you can try out other UI things while we figure out these type errors.

👍 1

trentlarson commented

2025-02-08 23:41:50 +00:00

... at least, that's what happened on my machine: I got the error, but the server was running OK.

👍 1

jsnbuchanan force-pushed fix/adding-nostr-tools-dependency from 69eb3f923b to 53a06be734

2025-02-14 13:37:27 +00:00

Compare

jsnbuchanan added 1 commit 2025-02-14 16:56:25 +00:00

feat(feed): better image formatting, to take up the width of the feed container 781afd8954

jsnbuchanan added 1 commit 2025-02-14 16:57:15 +00:00

deps: updating the nostr-tools version from 2.7.2 to 2.10.4 to fix a bug I was seeing locally 77ebd32956

jsnbuchanan added 1 commit 2025-02-14 18:43:46 +00:00

fix(feed): long words or urls displayed in feed break the container layout be1146c7df

jsnbuchanan added 1 commit 2025-02-14 18:49:47 +00:00

feat(feed): adding image viewer for expanding images found in the feed instead of displaying in a new tab and taking the viewer away from the application 0511bbc17b

jsnbuchanan added 1 commit 2025-02-14 20:04:04 +00:00

feat(feed): improving the image viewer, to be more conventional, and also allowing the viewer to download the image on mobile with ... control f4c7805266

jsnbuchanan added 1 commit 2025-02-14 20:21:57 +00:00

deps: fixing issues around nostr-tools deps being removed that were necessary e86cf3c9f2

jsnbuchanan changed title from ~~fix(deps): upgrading nostr-tools dependency and update the import to be more conventional~~ to feat(feed): Images in the home feed now take up the full width of the card and displays in lightbox when clicked

2025-02-14 20:31:15 +00:00

jsnbuchanan commented

2025-02-14 20:33:22 +00:00

[0.4.0] - 2025.02.14

Changed

Images in the home feed now take up the full width of the card.
Clicking the image previously, would open the image in a new tab. Now, clicking the image opens the image in a lightbox view.

Added

Clicking an image also now displays an in-app lightbox view of the image.
The lightbox view includes a download button for the image in mobile view.

## [0.4.0] - 2025.02.14 ### Changed - Images in the home feed now take up the full width of the card. - Clicking the image previously, would open the image in a new tab. Now, clicking the image opens the image in a lightbox view. ### Added - Clicking an image also now displays an in-app lightbox view of the image. - The lightbox view includes a download button for the image in mobile view.

Screenshot 2025-02-14 at 1.07.17 PM.png

132 KiB

Screenshot 2025-02-14 at 1.07.29 PM.png

216 KiB