Merge branch 'master' into contacts-view-improvements

project.task.yaml

@@ -1,21 +1,14 @@
 
 tasks:
-- 01 design ideas for simple gives on the Home page
 - 01 add a location for a project via map pin
 - 04 search by a bounding box for local projects (see API by clicking on "Nearby")
 - 01 Replace Gifted/Give in ContactsView with GiftedDialog assignee:jose
-- 02 Fix images on projectview: allow choice of image from a pallete of images or a url image.
+- 02 Fix images on projectview - allow choice of image from a pallete of images or a url image.
 
 - 08 Scan QR code to import into contacts.
 
-- contacts v1 :
-  - 01 Import contact info a la QR code.
-  - .2 move all "identity" references to temporary account access assignee:trent
-
-- contacts v+ :
-  - 01 Import all the non-sensitive data (ie. contacts & settings).
-  - .2 show error to user when adding a duplicate contact
-  - 01 parse input more robustly (with CSV lib and not commas)
+- 40 notifications :
+    - push, where we trigger a ServiceWorker(?) in the app to reach out and check for new data
 
 - refactor UI :
   - .5 Alerts show at the top and can be missed if you've scrolled down on the page, eg. account data download
@@ -29,18 +22,22 @@ tasks:
   - 01 save the feed-viewed status in settings storage ("afterQuery")
   - 01 quick action - send action, maybe choose via canvas tool https://github.com/konvajs/vue-konva
 
-- .5 customize favicon
-- 04 allow user to download claims, mine + ones I can see about me from others
-
 - 24 Move to Vite
 
-- 40 notifications :
-  - push
+- .5 remove edit from project page for projects owned by others
+- .5 fix where user 0 sees no txns from user 1 on contacts page but sees them on list page
+- .2 there are three dots at the top of ProjectViewView that refreshes the page but doesn't do anything else
+- 01 fix images on project page, on discovery page
+- .2 on ProjectViewView, show different messages for "to" and "from" sections if none exist
+- .2 fix static icon to the right on project page (Matthew - I've made "Rotary" into issuer?)
+- .2 fix rate limit verbiage (with the new one-per-day allowance) assignee:trent
 
 - Discuss whether the remaining tasks are worthwhile before MVP release.
 
-- 01 fix images on project page, on discovery page
-- .2 fix static icon to the right on project page (Matthew:  I've made "Rotary" into issuer property?)
+- contacts v+ :
+  - 01 Import all the non-sensitive data (ie. contacts & settings).
+  - .2 show error to user when adding a duplicate contact
+  - 01 parse input more robustly (with CSV lib and not commas)
 
 - stats v1 :
   - 01 show numeric stats
@@ -49,7 +46,11 @@ tasks:
   - maybe - allow type annotations in World.js & landmarks.js (since we get this error - "Types are not supported by current JavaScript version")
   - 08 convert to cleaner implementation (maybe Drie -- https://github.com/janvorisek/drie)
 
-- Do we want split first name & last name?
+- .5 on ProjectView page, show immediate feedback when a gift is given (on list?) -- and consider the same for Home & Contacts pages
+- .5 customize favicon
+- 04 allow user to download claims, mine + ones I can see about me from others
+- Do we want to combine first name & last name?
+- Show a warning if both giver and recipient are the same (but still allow?)
 
 - Release Minimum Viable Product :
   - 08 thorough testing for errors & edge cases
@@ -62,9 +63,6 @@ tasks:
   - Test PWA features on Android and iOS.
   blocks: ref:https://raw.githubusercontent.com/trentlarson/lives-of-gifts/master/project.yaml#kickstarter%20for%20time
 
-- 40 notifications v+ :
-  - pull, w/ scheduled runs
-
 - linking between projects or plans :
   - show total time given to & from a project
   - terminology:
@@ -93,6 +91,10 @@ tasks:
 
 - Write to or read from a different ledger (eg. private ACDC, attest.sh)
 
+- Do we want split first name & last name?
+
+- 40 notifications v+ :
+  - pull, w/ scheduled runs
 
 log:
 - videos for multiple identities https://youtu.be/p8L87AeD76w and for adding time to contacts https://youtu.be/7Yylczevp10 done:2023-03-29

src/components/AlertMessage.vue

@@ -1,7 +1,7 @@
 <template>
   <div v-bind:class="computedAlertClassNames()">
     <button
-      class="close-button bg-slate-200 w-8 leading-loose rounded-full absolute top-2 right-2"
+      class="close-button bg-amber-400 w-8 leading-loose rounded-full absolute top-2 right-2"
       @click="onClickClose()"
     >
       <fa icon="xmark"></fa>
@@ -28,7 +28,7 @@ export default class AlertMessage extends Vue {
     return {
       hidden: !this.isAlertVisible,
       "dismissable-alert": true,
-      "bg-slate-100": true,
+      "bg-amber-200": true,
       "p-5": true,
       rounded: true,
       "drop-shadow-lg": true,

src/libs/endorserServer.ts

@@ -82,11 +82,8 @@ export function isHiddenDid(did) {
 /**
  always returns text, maybe UNNAMED_VISIBLE or UNKNOWN_ENTITY
  **/
-export function didInfo(did, activeDid, identifiers, contacts) {
-  const myId: IIdentifier | undefined = R.find(
-    (i) => i.did === did,
-    identifiers,
-  );
+export function didInfo(did, activeDid, allMyDids, contacts) {
+  const myId: string | undefined = R.find(R.identity, allMyDids);
   if (myId) {
     return "You" + (myId.did !== activeDid ? " (Alt ID)" : "");
   } else {

src/views/AccountViewView.vue

@@ -283,12 +283,12 @@ import { useClipboard } from "@vueuse/core";
 
 import { AppString } from "@/constants/app";
 import { db, accountsDB } from "@/db";
-import { AccountsSchema } from "@/db/tables/accounts";
 import { MASTER_SETTINGS_KEY } from "@/db/tables/settings";
 import { accessToken } from "@/libs/crypto";
 import { AxiosError } from "axios/index";
 import AlertMessage from "@/components/AlertMessage";
 import QuickNav from "@/components/QuickNav";
+import { IIdentifier } from "@veramo/core";
 
 // eslint-disable-next-line @typescript-eslint/no-var-requires
 const Buffer = require("buffer/").Buffer;
@@ -310,7 +310,6 @@ export default class AccountViewView extends Vue {
   limitsMessage = "";
   loadingLimits = true; // might as well now that we do it on mount, to avoid flashing the registration message
   showContactGives = false;
-  private accounts: AccountsSchema;
 
   showDidCopy = false;
   showDerCopy = false;
@@ -328,12 +327,6 @@ export default class AccountViewView extends Vue {
       .equals(activeDid)
       .first();
     const identity = JSON.parse(account?.identity || "null");
-
-    if (!identity) {
-      throw new Error(
-        "Attempted to load Give records with no identity available.",
-      );
-    }
     return identity;
   }
 
@@ -364,9 +357,8 @@ export default class AccountViewView extends Vue {
   }
 
   async beforeCreate() {
-    accountsDB.open();
-    this.accounts = accountsDB.accounts;
-    this.numAccounts = await this.accounts.count();
+    await accountsDB.open();
+    this.numAccounts = await accountsDB.accounts.count();
   }
 
   async created() {
@@ -388,14 +380,18 @@ export default class AccountViewView extends Vue {
 
       const identity = await this.getIdentity(this.activeDid);
 
+      if (identity) {
         this.publicHex = identity.keys[0].publicKeyHex;
-      this.publicBase64 = Buffer.from(this.publicHex, "hex").toString("base64");
+        this.publicBase64 = Buffer.from(this.publicHex, "hex").toString(
+          "base64",
+        );
         this.derivationPath = identity.keys[0].meta.derivationPath;
 
         db.settings.update(MASTER_SETTINGS_KEY, {
           activeDid: identity.did,
         });
-      this.checkLimits();
+        this.checkLimitsFor(identity);
+      }
     } catch (err) {
       if (
         err.message ===
@@ -454,12 +450,18 @@ export default class AccountViewView extends Vue {
   }
 
   async checkLimits() {
+    const identity = await this.getIdentity(this.activeDid);
+    if (identity) {
+      this.checkLimitsFor(identity);
+    }
+  }
+
+  async checkLimitsFor(identity: IIdentifier) {
     this.loadingLimits = true;
     this.limitsMessage = "";
 
     try {
       const url = this.apiServer + "/api/report/rateLimits";
-      const identity = await this.getIdentity(this.activeDid);
       const headers = await this.getHeaders(identity);
 
       const resp = await this.axios.get(url, { headers });

src/views/ContactAmountsView.vue

@@ -78,7 +78,6 @@ import * as R from "ramda";
 
 import { Component, Vue } from "vue-facing-decorator";
 import { accountsDB, db } from "@/db";
-import { AccountsSchema } from "@/db/tables/accounts";
 import { Contact } from "@/db/tables/contacts";
 import { MASTER_SETTINGS_KEY } from "@/db/tables/settings";
 import { accessToken, SimpleSigner } from "@/libs/crypto";
@@ -101,13 +100,11 @@ export default class ContactsView extends Vue {
   giveRecords: Array<GiveServerRecord> = [];
   alertTitle = "";
   alertMessage = "";
-  accounts: AccountsSchema;
   numAccounts = 0;
 
   async beforeCreate() {
-    accountsDB.open();
-    this.accounts = accountsDB.accounts;
-    this.numAccounts = await this.accounts.count();
+    await accountsDB.open();
+    this.numAccounts = await accountsDB.accounts.count();
   }
 
   public async getIdentity(activeDid) {

src/views/HomeView.vue

@@ -89,11 +89,9 @@
 import { Component, Vue } from "vue-facing-decorator";
 import GiftedDialog from "@/components/GiftedDialog.vue";
 import { db, accountsDB } from "@/db";
-import { AccountsSchema } from "@/db/tables/accounts";
 import { MASTER_SETTINGS_KEY } from "@/db/tables/settings";
 import { accessToken } from "@/libs/crypto";
 import { createAndSubmitGive, didInfo } from "@/libs/endorserServer";
-import { Account } from "@/db/tables/accounts";
 import { Contact } from "@/db/tables/contacts";
 import AlertMessage from "@/components/AlertMessage";
 import QuickNav from "@/components/QuickNav";
@@ -103,8 +101,8 @@ import QuickNav from "@/components/QuickNav";
 })
 export default class HomeView extends Vue {
   activeDid = "";
-  allAccounts: Array<Account> = [];
   allContacts: Array<Contact> = [];
+  allMyDids: Array<string> = [];
   apiServer = "";
   feedAllLoaded = false;
   feedData = [];
@@ -113,13 +111,11 @@ export default class HomeView extends Vue {
   isHiddenSpinner = true;
   alertTitle = "";
   alertMessage = "";
-  accounts: AccountsSchema;
   numAccounts = 0;
 
   async beforeCreate() {
-    accountsDB.open();
-    this.accounts = accountsDB.accounts;
-    this.numAccounts = await this.accounts.count();
+    await accountsDB.open();
+    this.numAccounts = await accountsDB.accounts.count();
   }
 
   public async getIdentity(activeDid) {
@@ -150,7 +146,9 @@ export default class HomeView extends Vue {
   async created() {
     try {
       await accountsDB.open();
-      this.allAccounts = await accountsDB.accounts.toArray();
+      const allAccounts = await accountsDB.accounts.toArray();
+      this.allMyDids = allAccounts.map((acc) => acc.did);
+
       await db.open();
       const settings = await db.settings.get(MASTER_SETTINGS_KEY);
       this.apiServer = settings?.apiServer || "";
@@ -247,14 +245,13 @@ export default class HomeView extends Vue {
     if (claim.claim) {
       claim = claim.claim;
     }
-
     // agent.did is for legacy data, before March 2023
     const giverDid =
       claim.agent?.identifier || claim.agent?.did || giveRecord.issuer;
     const giverInfo = didInfo(
       giverDid,
       this.activeDid,
-      this.allAccounts,
+      this.allMyDids,
       this.allContacts,
     );
     const gaveAmount = claim.object?.amountOfThisGood
@@ -267,7 +264,7 @@ export default class HomeView extends Vue {
         didInfo(
           gaveRecipientId,
           this.activeDid,
-          this.allAccounts,
+          this.allMyDids,
           this.allContacts,
         )
       : "";
@@ -332,8 +329,8 @@ export default class HomeView extends Vue {
         hours,
       );
 
-      if (isGiveCreationError(result)) {
-        const errorMessage = getGiveCreationErrorMessage(result);
+      if (this.isGiveCreationError(result)) {
+        const errorMessage = this.getGiveCreationErrorMessage(result);
         console.log("Error with give result:", result);
         this.setAlert(
           "Error",
@@ -346,7 +343,8 @@ export default class HomeView extends Vue {
       console.log("Error with give caught:", error);
       this.setAlert(
         "Error",
-        getGiveErrorMessage(error) || "There was an error recording the give.",
+        this.getGiveErrorMessage(error) ||
+          "There was an error recording the give.",
       );
     }
   }

src/views/NewEditProjectView.vue

@@ -76,7 +76,6 @@ import * as didJwt from "did-jwt";
 import { Component, Vue } from "vue-facing-decorator";
 
 import { accountsDB, db } from "@/db";
-import { AccountsSchema } from "@/db/tables/accounts";
 import { MASTER_SETTINGS_KEY } from "@/db/tables/settings";
 import { accessToken, SimpleSigner } from "@/libs/crypto";
 import { useAppStore } from "@/store/app";
@@ -92,15 +91,13 @@ export default class NewEditProjectView extends Vue {
   projectName = "";
   description = "";
   errorMessage = "";
-  accounts: AccountsSchema;
   numAccounts = 0;
   alertTitle = "";
   alertMessage = "";
 
   async beforeCreate() {
-    accountsDB.open();
-    this.accounts = accountsDB.accounts;
-    this.numAccounts = await this.accounts.count();
+    await accountsDB.open();
+    this.numAccounts = await accountsDB.accounts.count();
   }
 
   public async getIdentity(activeDid) {

src/views/NewIdentifierView.vue

@@ -50,7 +50,6 @@ export default class AccountViewView extends Vue {
   loading = true;
 
   async mounted() {
-    await accountsDB.open();
     const mnemonic = generateSeed();
     // address is 0x... ETH address, without "did:eth:"
     const [address, privateHex, publicHex, derivationPath] =
@@ -58,6 +57,8 @@ export default class AccountViewView extends Vue {
 
     const newId = newIdentifier(address, publicHex, privateHex, derivationPath);
     const identity = JSON.stringify(newId);
+
+    await accountsDB.open();
     await accountsDB.accounts.add({
       dateCreated: new Date().toISOString(),
       derivationPath: derivationPath,

src/views/ProjectViewView.vue

@@ -104,7 +104,7 @@
               <div class="flex gap-2">
                 <fa icon="user" class="fa-fw text-slate-400"></fa>
                 <span>{{
-                  didInfo(give.agentDid, activeDid, accounts, allContacts)
+                  didInfo(give.agentDid, activeDid, allMyDids, allContacts)
                 }}</span>
               </div>
               <div class="flex gap-2" v-if="give.amount">
@@ -126,7 +126,7 @@
               <div class="flex gap-2">
                 <fa icon="user" class="fa-fw text-slate-400"></fa>
                 <span>{{
-                  didInfo(give.agentDid, activeDid, accounts, allContacts)
+                  didInfo(give.agentDid, activeDid, allMyDids, allContacts)
                 }}</span>
               </div>
               <div class="flex gap-2" v-if="give.amount">
@@ -163,7 +163,6 @@ import { Component, Vue } from "vue-facing-decorator";
 
 import GiftedDialog from "@/components/GiftedDialog.vue";
 import { accountsDB, db } from "@/db";
-import { AccountsSchema } from "@/db/tables/accounts";
 import { Contact } from "@/db/tables/contacts";
 import { MASTER_SETTINGS_KEY } from "@/db/tables/settings";
 import { accessToken } from "@/libs/crypto";
@@ -179,10 +178,10 @@ import QuickNav from "@/components/QuickNav";
   components: { GiftedDialog, AlertMessage, QuickNav },
 })
 export default class ProjectViewView extends Vue {
-  accounts: AccountsSchema;
   activeDid = "";
   alertMessage = "";
   alertTitle = "";
+  allMyDids: Array<string> = [];
   allContacts: Array<Contact> = [];
   apiServer = "";
   description = "";
@@ -191,18 +190,11 @@ export default class ProjectViewView extends Vue {
   givesByThis: Array<GiveServerRecord> = [];
   name = "";
   issuer = "";
-  numAccounts = 0;
   projectId = localStorage.getItem("projectId") || ""; // handle ID
   timeSince = "";
   truncatedDesc = "";
   truncateLength = 40;
 
-  async beforeCreate() {
-    accountsDB.open();
-    this.accounts = accountsDB.accounts;
-    this.numAccounts = (await this.accounts?.count()) || 0;
-  }
-
   async created() {
     await db.open();
     const settings = await db.settings.get(MASTER_SETTINGS_KEY);
@@ -210,9 +202,11 @@ export default class ProjectViewView extends Vue {
     this.apiServer = settings?.apiServer || "";
     this.allContacts = await db.contacts.toArray();
 
-    this.accounts = accountsDB.accounts;
-    const accountsArr = await this.accounts?.toArray();
-    const account = accountsArr.find((acc) => acc.did === this.activeDid);
+    await accountsDB.open();
+    const accounts = accountsDB.accounts;
+    const accountsArr = await accounts?.toArray();
+    this.allMyDids = accountsArr.map((acc) => acc.did);
+    const account = accountsArr?.find((acc) => acc.did === this.activeDid);
     const identity = JSON.parse(account?.identity || "null");
     this.LoadProject(identity);
   }
@@ -251,8 +245,8 @@ export default class ProjectViewView extends Vue {
   }
 
   // Isn't there a better way to make this available to the template?
-  didInfo(did, activeDid, identities, contacts) {
-    return didInfo(did, activeDid, identities, contacts);
+  didInfo(did, activeDid, dids, contacts) {
+    return didInfo(did, activeDid, dids, contacts);
   }
 
   expandText() {

src/views/ProjectsView.vue

@@ -74,7 +74,6 @@
 <script lang="ts">
 import { Component, Vue } from "vue-facing-decorator";
 import { accountsDB, db } from "@/db";
-import { AccountsSchema } from "@/db/tables/accounts";
 import { MASTER_SETTINGS_KEY } from "@/db/tables/settings";
 import { accessToken } from "@/libs/crypto";
 import { IIdentifier } from "@veramo/core";
@@ -92,13 +91,11 @@ export default class ProjectsView extends Vue {
   isLoading = false;
   alertTitle = "";
   alertMessage = "";
-  accounts: AccountsSchema;
   numAccounts = 0;
 
   async beforeCreate() {
-    accountsDB.open();
-    this.accounts = accountsDB.accounts;
-    this.numAccounts = await this.accounts.count();
+    await accountsDB.open();
+    this.numAccounts = await accountsDB.accounts.count();
   }
 
   /**