Browse Source
**Type Safety Improvements:** - Replace `unknown[]` with proper `SqlValue[]` type in database query methods - Add `SqlValue` import to PlatformServiceMixin.ts for better type definitions - Update interface definitions for `$dbGetOneRow` and `$one` methods - Fix database row mapping to use `Array<SqlValue>` instead of `unknown[]` **Test Reliability Fix:** - Add backup seed modal handling to 60-new-activity.spec.ts - Follow established dialog handling pattern from 00-noid-tests.spec.ts - Use `waitForFunction` to detect backup seed modal appearance - Gracefully handle modal dismissal with "No, Remind me Later" button - Add error handling for cases where backup modal doesn't appear **Files Changed:** - src/utils/PlatformServiceMixin.ts: Enhanced type safety for database operations - test-playwright/60-new-activity.spec.ts: Fixed dialog interception causing test failures **Impact:** - Eliminates TypeScript linting errors for database query types - Resolves Playwright test timeout caused by backup seed modal blocking clicks - Improves test reliability by following established dialog handling patterns - Maintains backward compatibility while enhancing type safety **Testing:** - TypeScript compilation passes without errors - Linting checks pass with improved type definitions - Playwright test now handles backup seed modal properlypull/188/head
2 changed files with 36 additions and 8 deletions
Loading…
Reference in new issue