Browse Source

refactor(logging): replace console.* and reclassify log levels in HomeView.vue, FeedFilters.vue

- Remove all console.* calls from FeedFilters.vue
- Reclassify 12 logger.info calls to logger.debug in HomeView.vue for diagnostic messages
- Add logger import to FeedFilters.vue
- Maintain existing logging patterns and behavior
pull/162/head
Matthew Raymer 3 days ago
parent
commit
b761088839
  1. 49
      src/components/FeedFilters.vue
  2. 26
      src/views/HomeView.vue

49
src/components/FeedFilters.vue

@ -101,6 +101,7 @@ import {
import { Router } from "vue-router"; import { Router } from "vue-router";
import { PlatformServiceMixin } from "@/utils/PlatformServiceMixin"; import { PlatformServiceMixin } from "@/utils/PlatformServiceMixin";
import { logger } from "@/utils/logger";
@Component({ @Component({
components: { components: {
@ -140,44 +141,26 @@ export default class FeedFilters extends Vue {
this.settingChanged = true; this.settingChanged = true;
this.hasVisibleDid = !this.hasVisibleDid; this.hasVisibleDid = !this.hasVisibleDid;
if (this.activeDid) {
await this.$updateSettings(
{
filterFeedByVisible: this.hasVisibleDid,
},
this.activeDid,
);
} else {
await this.$updateSettings({ await this.$updateSettings({
filterFeedByVisible: this.hasVisibleDid, filterFeedByVisible: this.hasVisibleDid,
}); });
} }
}
async toggleNearby() { async toggleNearby() {
this.settingChanged = true; this.settingChanged = true;
this.isNearby = !this.isNearby; this.isNearby = !this.isNearby;
console.log("[FeedFilters] 🔄 Toggling nearby filter:", { logger.debug("[FeedFilters] 🔄 Toggling nearby filter:", {
newValue: this.isNearby, newValue: this.isNearby,
settingChanged: this.settingChanged, settingChanged: this.settingChanged,
activeDid: this.activeDid, activeDid: this.activeDid,
}); });
if (this.activeDid) {
await this.$updateSettings(
{
filterFeedByNearby: this.isNearby,
},
this.activeDid,
);
} else {
await this.$updateSettings({ await this.$updateSettings({
filterFeedByNearby: this.isNearby, filterFeedByNearby: this.isNearby,
}); });
}
console.log("[FeedFilters] ✅ Nearby filter updated in settings"); logger.debug("[FeedFilters] ✅ Nearby filter updated in settings");
} }
async clearAll() { async clearAll() {
@ -185,20 +168,10 @@ export default class FeedFilters extends Vue {
this.settingChanged = true; this.settingChanged = true;
} }
if (this.activeDid) {
await this.$updateSettings(
{
filterFeedByNearby: false,
filterFeedByVisible: false,
},
this.activeDid,
);
} else {
await this.$updateSettings({ await this.$updateSettings({
filterFeedByNearby: false, filterFeedByNearby: false,
filterFeedByVisible: false, filterFeedByVisible: false,
}); });
}
this.hasVisibleDid = false; this.hasVisibleDid = false;
this.isNearby = false; this.isNearby = false;
@ -209,40 +182,30 @@ export default class FeedFilters extends Vue {
this.settingChanged = true; this.settingChanged = true;
} }
if (this.activeDid) {
await this.$updateSettings(
{
filterFeedByNearby: true,
filterFeedByVisible: true,
},
this.activeDid,
);
} else {
await this.$updateSettings({ await this.$updateSettings({
filterFeedByNearby: true, filterFeedByNearby: true,
filterFeedByVisible: true, filterFeedByVisible: true,
}); });
}
this.hasVisibleDid = true; this.hasVisibleDid = true;
this.isNearby = true; this.isNearby = true;
} }
close() { close() {
console.log("[FeedFilters] 🚪 Closing dialog:", { logger.debug("[FeedFilters] 🚪 Closing dialog:", {
settingChanged: this.settingChanged, settingChanged: this.settingChanged,
hasCallback: !!this.onCloseIfChanged, hasCallback: !!this.onCloseIfChanged,
}); });
if (this.settingChanged) { if (this.settingChanged) {
console.log("[FeedFilters] 🔄 Settings changed, calling callback"); logger.debug("[FeedFilters] 🔄 Settings changed, calling callback");
this.onCloseIfChanged(); this.onCloseIfChanged();
} }
this.visible = false; this.visible = false;
} }
done() { done() {
console.log("[FeedFilters] ✅ Done button clicked"); logger.debug("[FeedFilters] ✅ Done button clicked");
this.close(); this.close();
} }
} }

26
src/views/HomeView.vue

@ -476,7 +476,7 @@ export default class HomeView extends Vue {
// Re-initialize identity with new settings (loads settings internally) // Re-initialize identity with new settings (loads settings internally)
await this.initializeIdentity(); await this.initializeIdentity();
} else { } else {
logger.info( logger.debug(
"[HomeView Settings Trace] 📍 DID unchanged, skipping re-initialization", "[HomeView Settings Trace] 📍 DID unchanged, skipping re-initialization",
); );
} }
@ -756,12 +756,12 @@ export default class HomeView extends Vue {
* Called by FeedFilters component when filters change * Called by FeedFilters component when filters change
*/ */
async reloadFeedOnChange() { async reloadFeedOnChange() {
logger.info("[HomeView] 🔄 reloadFeedOnChange() called - refreshing feed"); logger.debug("[HomeView] 🔄 reloadFeedOnChange() called - refreshing feed");
// Get current settings without overriding with defaults // Get current settings without overriding with defaults
const settings = await this.$accountSettings(this.activeDid); const settings = await this.$accountSettings(this.activeDid);
logger.info("[HomeView] 📊 Current filter settings:", { logger.debug("[HomeView] 📊 Current filter settings:", {
filterFeedByVisible: settings.filterFeedByVisible, filterFeedByVisible: settings.filterFeedByVisible,
filterFeedByNearby: settings.filterFeedByNearby, filterFeedByNearby: settings.filterFeedByNearby,
searchBoxes: settings.searchBoxes?.length || 0, searchBoxes: settings.searchBoxes?.length || 0,
@ -771,7 +771,7 @@ export default class HomeView extends Vue {
this.isFeedFilteredByNearby = !!settings.filterFeedByNearby; this.isFeedFilteredByNearby = !!settings.filterFeedByNearby;
this.isAnyFeedFilterOn = checkIsAnyFeedFilterOn(settings); this.isAnyFeedFilterOn = checkIsAnyFeedFilterOn(settings);
logger.info("[HomeView] 🎯 Updated filter states:", { logger.debug("[HomeView] 🎯 Updated filter states:", {
isFeedFilteredByVisible: this.isFeedFilteredByVisible, isFeedFilteredByVisible: this.isFeedFilteredByVisible,
isFeedFilteredByNearby: this.isFeedFilteredByNearby, isFeedFilteredByNearby: this.isFeedFilteredByNearby,
isAnyFeedFilterOn: this.isAnyFeedFilterOn, isAnyFeedFilterOn: this.isAnyFeedFilterOn,
@ -780,10 +780,10 @@ export default class HomeView extends Vue {
this.feedData = []; this.feedData = [];
this.feedPreviousOldestId = undefined; this.feedPreviousOldestId = undefined;
logger.info("[HomeView] 🧹 Cleared feed data, calling updateAllFeed()"); logger.debug("[HomeView] 🧹 Cleared feed data, calling updateAllFeed()");
await this.updateAllFeed(); await this.updateAllFeed();
logger.info("[HomeView] ✅ Feed refresh completed"); logger.debug("[HomeView] ✅ Feed refresh completed");
} }
/** /**
@ -862,7 +862,7 @@ export default class HomeView extends Vue {
* - this.feedLastViewedClaimId (via updateFeedLastViewedId) * - this.feedLastViewedClaimId (via updateFeedLastViewedId)
*/ */
async updateAllFeed() { async updateAllFeed() {
logger.info("[HomeView] 🚀 updateAllFeed() called", { logger.debug("[HomeView] 🚀 updateAllFeed() called", {
isFeedLoading: this.isFeedLoading, isFeedLoading: this.isFeedLoading,
currentFeedDataLength: this.feedData.length, currentFeedDataLength: this.feedData.length,
isAnyFeedFilterOn: this.isAnyFeedFilterOn, isAnyFeedFilterOn: this.isAnyFeedFilterOn,
@ -879,7 +879,7 @@ export default class HomeView extends Vue {
this.feedPreviousOldestId, this.feedPreviousOldestId,
); );
logger.info("[HomeView] 📡 Retrieved gives from API", { logger.debug("[HomeView] 📡 Retrieved gives from API", {
resultsCount: results.data.length, resultsCount: results.data.length,
endOfResults, endOfResults,
}); });
@ -890,7 +890,7 @@ export default class HomeView extends Vue {
await this.processFeedResults(results.data); await this.processFeedResults(results.data);
await this.updateFeedLastViewedId(results.data); await this.updateFeedLastViewedId(results.data);
logger.info("[HomeView] 📝 Processed feed results", { logger.debug("[HomeView] 📝 Processed feed results", {
processedCount: this.feedData.length, processedCount: this.feedData.length,
}); });
} }
@ -900,12 +900,12 @@ export default class HomeView extends Vue {
} }
if (this.feedData.length === 0 && !endOfResults) { if (this.feedData.length === 0 && !endOfResults) {
logger.info("[HomeView] 🔄 No results after filtering, retrying..."); logger.debug("[HomeView] 🔄 No results after filtering, retrying...");
await this.updateAllFeed(); await this.updateAllFeed();
} }
this.isFeedLoading = false; this.isFeedLoading = false;
logger.info("[HomeView] ✅ updateAllFeed() completed", { logger.debug("[HomeView] ✅ updateAllFeed() completed", {
finalFeedDataLength: this.feedData.length, finalFeedDataLength: this.feedData.length,
isFeedLoading: this.isFeedLoading, isFeedLoading: this.isFeedLoading,
}); });
@ -933,7 +933,7 @@ export default class HomeView extends Vue {
* @param records Array of feed records to process * @param records Array of feed records to process
*/ */
private async processFeedResults(records: GiveSummaryRecord[]) { private async processFeedResults(records: GiveSummaryRecord[]) {
logger.info("[HomeView] 📝 Processing feed results:", { logger.debug("[HomeView] 📝 Processing feed results:", {
inputRecords: records.length, inputRecords: records.length,
currentFilters: { currentFilters: {
isAnyFeedFilterOn: this.isAnyFeedFilterOn, isAnyFeedFilterOn: this.isAnyFeedFilterOn,
@ -955,7 +955,7 @@ export default class HomeView extends Vue {
} }
} }
logger.info("[HomeView] 📊 Feed processing results:", { logger.debug("[HomeView] 📊 Feed processing results:", {
processed: processedCount, processed: processedCount,
filtered: filteredCount, filtered: filteredCount,
total: records.length, total: records.length,

Loading…
Cancel
Save