Browse Source

refactor: rename SetVisibilityDialog to SetBulkVisibilityDialog and remove unused code

- Rename SetVisibilityDialog.vue to SetBulkVisibilityDialog.vue for better clarity
- Update all component references in MembersList.vue (import, registration, template usage)
- Update component class name from SetVisibilityDialog to SetBulkVisibilityDialog
- Rename calling function name to showSetBulkVisibilityDialog to match class name change
- Remove unused properties and created() method from App.vue

This cleanup removes dead code and improves component naming consistency.
pull/208/head
Jose Olarte III 2 days ago
parent
commit
4de4fbecaf
  1. 13
      src/App.vue
  2. 12
      src/components/MembersList.vue
  3. 2
      src/components/SetBulkVisibilityDialog.vue

13
src/App.vue

@ -378,19 +378,6 @@ export default class App extends Vue {
$notify!: (notification: NotificationIface, timeout?: number) => void; $notify!: (notification: NotificationIface, timeout?: number) => void;
stopAsking = false; stopAsking = false;
activeDid = "";
apiServer = "";
async created() {
// Initialize settings
const settings = await this.$accountSettings();
this.apiServer = settings.apiServer || "";
// Get activeDid from active_identity table
// eslint-disable-next-line @typescript-eslint/no-explicit-any
const activeIdentity = await (this as any).$getActiveIdentity();
this.activeDid = activeIdentity.activeDid || "";
}
async turnOffNotifications( async turnOffNotifications(
notification: NotificationIface, notification: NotificationIface,

12
src/components/MembersList.vue

@ -71,7 +71,7 @@
v-if="getMembersForVisibility().length > 0" v-if="getMembersForVisibility().length > 0"
class="text-sm bg-gradient-to-b from-slate-400 to-slate-700 shadow-[inset_0_-1px_0_0_rgba(0,0,0,0.5)] text-white px-3 py-1.5 rounded-md" class="text-sm bg-gradient-to-b from-slate-400 to-slate-700 shadow-[inset_0_-1px_0_0_rgba(0,0,0,0.5)] text-white px-3 py-1.5 rounded-md"
title="Set visibility for meeting members" title="Set visibility for meeting members"
@click="showAddMembersNotification" @click="showSetBulkVisibilityDialog"
> >
<font-awesome icon="eye" /> <font-awesome icon="eye" />
Set Visibility Set Visibility
@ -168,7 +168,7 @@
v-if="getMembersForVisibility().length > 0" v-if="getMembersForVisibility().length > 0"
class="text-sm bg-gradient-to-b from-slate-400 to-slate-700 shadow-[inset_0_-1px_0_0_rgba(0,0,0,0.5)] text-white px-3 py-1.5 rounded-md" class="text-sm bg-gradient-to-b from-slate-400 to-slate-700 shadow-[inset_0_-1px_0_0_rgba(0,0,0,0.5)] text-white px-3 py-1.5 rounded-md"
title="Set visibility for meeting members" title="Set visibility for meeting members"
@click="showAddMembersNotification" @click="showSetBulkVisibilityDialog"
> >
<font-awesome icon="eye" /> <font-awesome icon="eye" />
Set Visibility Set Visibility
@ -182,7 +182,7 @@
</div> </div>
<!-- Set Visibility Dialog Component --> <!-- Set Visibility Dialog Component -->
<SetVisibilityDialog <SetBulkVisibilityDialog
:visible="showSetVisibilityDialog" :visible="showSetVisibilityDialog"
:members-data="visibilityDialogMembers" :members-data="visibilityDialogMembers"
:active-did="activeDid" :active-did="activeDid"
@ -211,7 +211,7 @@ import {
NOTIFY_CONTINUE_WITHOUT_ADDING, NOTIFY_CONTINUE_WITHOUT_ADDING,
} from "@/constants/notifications"; } from "@/constants/notifications";
import { SOMEONE_UNNAMED } from "@/constants/entities"; import { SOMEONE_UNNAMED } from "@/constants/entities";
import SetVisibilityDialog from "./SetVisibilityDialog.vue"; import SetBulkVisibilityDialog from "./SetBulkVisibilityDialog.vue";
interface Member { interface Member {
admitted: boolean; admitted: boolean;
@ -228,7 +228,7 @@ interface DecryptedMember {
@Component({ @Component({
components: { components: {
SetVisibilityDialog, SetBulkVisibilityDialog,
}, },
mixins: [PlatformServiceMixin], mixins: [PlatformServiceMixin],
}) })
@ -594,7 +594,7 @@ export default class MembersList extends Vue {
} }
} }
showAddMembersNotification() { showSetBulkVisibilityDialog() {
// Filter members to show only those who need visibility set // Filter members to show only those who need visibility set
const membersForVisibility = this.getMembersForVisibility(); const membersForVisibility = this.getMembersForVisibility();

2
src/components/SetVisibilityDialog.vue → src/components/SetBulkVisibilityDialog.vue

@ -116,7 +116,7 @@ interface MemberData {
@Component({ @Component({
mixins: [PlatformServiceMixin], mixins: [PlatformServiceMixin],
}) })
export default class SetVisibilityDialog extends Vue { export default class SetBulkVisibilityDialog extends Vue {
@Prop({ default: false }) visible!: boolean; @Prop({ default: false }) visible!: boolean;
@Prop({ default: () => [] }) membersData!: MemberData[]; @Prop({ default: () => [] }) membersData!: MemberData[];
@Prop({ default: "" }) activeDid!: string; @Prop({ default: "" }) activeDid!: string;
Loading…
Cancel
Save