From 4de4fbecafc30fb2f7b8d0e1c18e2ee9f61c01df Mon Sep 17 00:00:00 2001
From: Jose Olarte III <jose.anomalist.design@gmail.com>
Date: Fri, 17 Oct 2025 17:59:41 +0800
Subject: [PATCH] refactor: rename SetVisibilityDialog to
 SetBulkVisibilityDialog and remove unused code

- Rename SetVisibilityDialog.vue to SetBulkVisibilityDialog.vue for better clarity
- Update all component references in MembersList.vue (import, registration, template usage)
- Update component class name from SetVisibilityDialog to SetBulkVisibilityDialog
- Rename calling function name to showSetBulkVisibilityDialog to match class name change
- Remove unused properties and created() method from App.vue

This cleanup removes dead code and improves component naming consistency.
---
 src/App.vue                                         | 13 -------------
 src/components/MembersList.vue                      | 12 ++++++------
 ...bilityDialog.vue => SetBulkVisibilityDialog.vue} |  2 +-
 3 files changed, 7 insertions(+), 20 deletions(-)
 rename src/components/{SetVisibilityDialog.vue => SetBulkVisibilityDialog.vue} (99%)

diff --git a/src/App.vue b/src/App.vue
index 01e9914f..13052500 100644
--- a/src/App.vue
+++ b/src/App.vue
@@ -378,19 +378,6 @@ export default class App extends Vue {
   $notify!: (notification: NotificationIface, timeout?: number) => void;
 
   stopAsking = false;
-  activeDid = "";
-  apiServer = "";
-
-  async created() {
-    // Initialize settings
-    const settings = await this.$accountSettings();
-    this.apiServer = settings.apiServer || "";
-
-    // Get activeDid from active_identity table
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
-    const activeIdentity = await (this as any).$getActiveIdentity();
-    this.activeDid = activeIdentity.activeDid || "";
-  }
 
   async turnOffNotifications(
     notification: NotificationIface,
diff --git a/src/components/MembersList.vue b/src/components/MembersList.vue
index 6d15e0f2..f39676ed 100644
--- a/src/components/MembersList.vue
+++ b/src/components/MembersList.vue
@@ -71,7 +71,7 @@
           v-if="getMembersForVisibility().length > 0"
           class="text-sm bg-gradient-to-b from-slate-400 to-slate-700 shadow-[inset_0_-1px_0_0_rgba(0,0,0,0.5)] text-white px-3 py-1.5 rounded-md"
           title="Set visibility for meeting members"
-          @click="showAddMembersNotification"
+          @click="showSetBulkVisibilityDialog"
         >
           <font-awesome icon="eye" />
           Set Visibility
@@ -168,7 +168,7 @@
           v-if="getMembersForVisibility().length > 0"
           class="text-sm bg-gradient-to-b from-slate-400 to-slate-700 shadow-[inset_0_-1px_0_0_rgba(0,0,0,0.5)] text-white px-3 py-1.5 rounded-md"
           title="Set visibility for meeting members"
-          @click="showAddMembersNotification"
+          @click="showSetBulkVisibilityDialog"
         >
           <font-awesome icon="eye" />
           Set Visibility
@@ -182,7 +182,7 @@
   </div>
 
   <!-- Set Visibility Dialog Component -->
-  <SetVisibilityDialog
+  <SetBulkVisibilityDialog
     :visible="showSetVisibilityDialog"
     :members-data="visibilityDialogMembers"
     :active-did="activeDid"
@@ -211,7 +211,7 @@ import {
   NOTIFY_CONTINUE_WITHOUT_ADDING,
 } from "@/constants/notifications";
 import { SOMEONE_UNNAMED } from "@/constants/entities";
-import SetVisibilityDialog from "./SetVisibilityDialog.vue";
+import SetBulkVisibilityDialog from "./SetBulkVisibilityDialog.vue";
 
 interface Member {
   admitted: boolean;
@@ -228,7 +228,7 @@ interface DecryptedMember {
 
 @Component({
   components: {
-    SetVisibilityDialog,
+    SetBulkVisibilityDialog,
   },
   mixins: [PlatformServiceMixin],
 })
@@ -594,7 +594,7 @@ export default class MembersList extends Vue {
     }
   }
 
-  showAddMembersNotification() {
+  showSetBulkVisibilityDialog() {
     // Filter members to show only those who need visibility set
     const membersForVisibility = this.getMembersForVisibility();
 
diff --git a/src/components/SetVisibilityDialog.vue b/src/components/SetBulkVisibilityDialog.vue
similarity index 99%
rename from src/components/SetVisibilityDialog.vue
rename to src/components/SetBulkVisibilityDialog.vue
index d11da966..ee55022a 100644
--- a/src/components/SetVisibilityDialog.vue
+++ b/src/components/SetBulkVisibilityDialog.vue
@@ -116,7 +116,7 @@ interface MemberData {
 @Component({
   mixins: [PlatformServiceMixin],
 })
-export default class SetVisibilityDialog extends Vue {
+export default class SetBulkVisibilityDialog extends Vue {
   @Prop({ default: false }) visible!: boolean;
   @Prop({ default: () => [] }) membersData!: MemberData[];
   @Prop({ default: "" }) activeDid!: string;