Browse Source

fix visibility after adding contact, and some messaging

starred-projects
Trent Larson 11 months ago
parent
commit
32c9076c39
  1. 11
      README.md
  2. 1
      project.task.yaml
  3. 2
      src/components/OfferDialog.vue
  4. 5
      src/libs/endorserServer.ts
  5. 8
      src/views/ContactsView.vue
  6. 4
      src/views/StartView.vue

11
README.md

@ -72,12 +72,14 @@ For your own web-push tests, change the push server URL in Advanced settings on
To add an icon, add to main.ts and reference with `fa` element and `icon` attribute with the hyphenated name.
### Manual walk-through
### Manual walk-through test
- Clear the browser cache for localhost for a new user.
- See that it's using the test API.
- Clear the browser data. (See "Reset" below.) Make sure that it's using the test API.
- On each page, verify the messaging.
- On the home page, see the feed without names, and see a message prompting to generate an ID.
- On the home page:
- Check that it generated an ID.
- Check the feed without names.
- Copy the contact URL.
- On the discovery page, check that they can see projects, and set a search area to see projects nearby.
- As User #0 in another browser on the test API, add a give & a project. (See User #0 details above.)
- With the new user on the home page, see the feed that shows User #0 in network but without the name.
@ -91,6 +93,7 @@ To add an icon, add to main.ts and reference with `fa` element and `icon` attrib
- On the contacts page, check that they cannot register someone else yet.
- Walk through the functions on each page.
- Test the mobile view.
- Test export & import.

1
project.task.yaml

@ -1,6 +1,7 @@
tasks:
- problem with making visible in test scenario adding contact?
- choose an agent via a contact chooser (not just copy-paste a DID)
- make set-name request yellow
- make the "give" on contact screen work like other give (allowing donation vs current blank)

2
src/components/OfferDialog.vue

@ -166,7 +166,7 @@ export default class OfferDialog extends Vue {
if (!identity) {
throw new Error(
"Attempted to load Offer records for DID ${activeDid} but no identifier was found",
`Attempted to load Offer records for DID ${activeDid} but no identifier was found`,
);
}
return identity;

5
src/libs/endorserServer.ts

@ -449,13 +449,14 @@ export async function createAndSubmitClaim(
} catch (error: any) {
console.error("Error creating claim:", error);
const errorMessage: string =
error.response?.data?.error?.message || error.message || "Unknown error";
error.response?.data?.error?.message ||
error.message ||
"Got some error submitting the claim. Check your permissions, network, and error logs.";
return {
type: "error",
error: {
error: errorMessage,
userMessage: "Failed to create and submit the claim.",
},
};
}

8
src/views/ContactsView.vue

@ -628,6 +628,10 @@ export default class ContactsView extends Vue {
message =
"A contact with that DID is already in your contact list. Edit them directly below.";
}
if (err.name === "ConstraintError") {
message +=
"Check that the contact doesn't conflict with any you already have.";
}
this.$notify(
{
group: "alert",
@ -782,7 +786,7 @@ export default class ContactsView extends Vue {
(visibility
? "Are you sure you want to make your activity visible to them?"
: "Are you sure you want to hide all your activity from them?");
if (visibilityPrompt && confirm(visibilityPrompt)) {
if (!visibilityPrompt || confirm(visibilityPrompt)) {
const url =
this.apiServer +
"/api/report/" +
@ -911,7 +915,7 @@ export default class ContactsView extends Vue {
}
private nameForContact(contact?: Contact, capitalize?: boolean): string {
return contact?.name || (capitalize ? "T" : "t") + "this unnamed user";
return contact?.name || (capitalize ? "T" : "t") + "his unnamed user";
}
async onClickAddGive(fromDid: string, toDid: string): Promise<void> {

4
src/views/StartView.vue

@ -44,14 +44,14 @@
@click="onClickNo()"
class="block w-full text-center text-md uppercase bg-slate-500 text-white px-1.5 py-2 rounded-md mt-2"
>
No
No, I have a seed
</a>
<a
v-if="numAccounts > 0"
@click="onClickDerive()"
class="block w-full text-center text-md uppercase bg-slate-500 text-white px-1.5 py-2 rounded-md mt-2"
>
Derive New Address from Seed Imported Previously
Derive new address from existing seed
</a>
</div>
</section>

Loading…
Cancel
Save