remove ability to mark a 'trade', ensuring this only sends & retrieves gifts

src/components/GiftedDialog.vue

@@ -117,7 +117,6 @@ export default class GiftedDialog extends Vue {
   customTitle?: string;
   description = "";
   giver?: libsUtil.GiverReceiverInputInfo; // undefined means no identified giver agent
-  isTrade = false;
   offerId = "";
   prompt = "";
   receiver?: libsUtil.GiverReceiverInputInfo;
@@ -301,7 +300,7 @@ export default class GiftedDialog extends Vue {
         unitCode,
         this.toProjectId,
         this.offerId,
-        this.isTrade,
+        false,
         undefined,
         this.fromProjectId,
       );
@@ -327,7 +326,7 @@ export default class GiftedDialog extends Vue {
             group: "alert",
             type: "success",
             title: "Success",
-            text: `That ${this.isTrade ? "trade" : "gift"} was recorded.`,
+            text: `That gift was recorded.`,
           },
           7000,
         );

src/libs/endorserServer.ts

@@ -650,7 +650,7 @@ export function hydrateGive(
   unitCode?: string,
   fulfillsProjectHandleId?: string,
   fulfillsOfferHandleId?: string,
-  isTrade: boolean = false,
+  isTrade: boolean = false, // remove, because this app is all for gifting
   imageUrl?: string,
   providerPlanHandleId?: string,
   lastClaimId?: string,
@@ -737,7 +737,7 @@ export async function createAndSubmitGive(
   unitCode?: string,
   fulfillsProjectHandleId?: string,
   fulfillsOfferHandleId?: string,
-  isTrade: boolean = false,
+  isTrade: boolean = false, // remove, because this app is all for gifting
   imageUrl?: string,
   providerPlanHandleId?: string,
 ): Promise<CreateAndSubmitClaimResult> {

src/views/GiftedDetailsView.vue

@@ -215,11 +215,6 @@
       </div>
     </div>
 
-    <div class="mt-8 flex">
-      <input v-model="isTrade" type="checkbox" class="h-6 w-6 mr-2" />
-      <label class="text-sm mt-1">This was a trade (not a gift)</label>
-    </div>
-
     <div v-if="showGeneralAdvanced" class="mt-4 flex">
       <router-link
         :to="{
@@ -307,7 +302,6 @@ export default class GiftedDetails extends Vue {
   giverName = "";
   hideBackButton = false;
   imageUrl = "";
-  isTrade = false;
   message = "";
   offerId = "";
   prevCredToEdit?: GenericCredWrapper<GiveVerifiableCredential>;
@@ -790,7 +784,7 @@ export default class GiftedDetails extends Vue {
           this.unitCode,
           fulfillsProjectId,
           this.offerId,
-          this.isTrade,
+          false,
           this.imageUrl,
           this.providerProjectId,
         );
@@ -806,7 +800,7 @@ export default class GiftedDetails extends Vue {
           this.unitCode,
           fulfillsProjectId,
           this.offerId,
-          this.isTrade,
+          false,
           this.imageUrl,
           this.providerProjectId,
         );
@@ -833,7 +827,7 @@ export default class GiftedDetails extends Vue {
             group: "alert",
             type: "success",
             title: "Success",
-            text: `That ${this.isTrade ? "trade" : "gift"} was recorded.`,
+            text: `That gift was recorded.`,
           },
           3000,
         );
@@ -878,7 +872,7 @@ export default class GiftedDetails extends Vue {
       this.unitCode,
       fulfillsProjectId,
       this.offerId,
-      this.isTrade,
+      false,
       this.imageUrl,
       this.providerProjectId,
       this.prevCredToEdit?.id as string,