forked from trent_larson/crowd-funder-for-time-pwa
refactor for clarity (no logic changes)
This commit is contained in:
@@ -107,16 +107,9 @@ class AbsurdSqlDatabaseService implements DatabaseService {
|
||||
const extractMigrationNames: (result: QueryExecResult[]) => Set<string> = (
|
||||
result,
|
||||
) => {
|
||||
const queryResult = result as QueryExecResult[];
|
||||
// Even with the "select name" query, the QueryExecResult may be [] (which doesn't make sense to me).
|
||||
if (queryResult.length > 0) {
|
||||
const singleResult = queryResult[0];
|
||||
const executedMigrations: Set<string> = new Set(
|
||||
singleResult.values.map((row) => row[0] as string),
|
||||
);
|
||||
return executedMigrations;
|
||||
}
|
||||
return new Set();
|
||||
const names = result?.[0]?.values.map((row) => row[0] as string) || [];
|
||||
return new Set(names);
|
||||
};
|
||||
|
||||
// Run migrations
|
||||
|
||||
@@ -236,6 +236,10 @@ export class CapacitorPlatformService implements PlatformService {
|
||||
throw new Error("Database not initialized");
|
||||
}
|
||||
|
||||
const sqlExec: (sql: string) => Promise<capSQLiteChanges> =
|
||||
this.db.execute.bind(this.db);
|
||||
const sqlQuery: (sql: string) => Promise<DBSQLiteValues> =
|
||||
this.db.query.bind(this.db);
|
||||
const extractMigrationNames: (result: DBSQLiteValues) => Set<string> = (
|
||||
result,
|
||||
) => {
|
||||
@@ -243,10 +247,6 @@ export class CapacitorPlatformService implements PlatformService {
|
||||
result.values?.map((row: { name: string }) => row.name) || [];
|
||||
return new Set(names);
|
||||
};
|
||||
const sqlExec: (sql: string) => Promise<capSQLiteChanges> =
|
||||
this.db.execute.bind(this.db);
|
||||
const sqlQuery: (sql: string) => Promise<DBSQLiteValues> =
|
||||
this.db.query.bind(this.db);
|
||||
runMigrations(sqlExec, sqlQuery, extractMigrationNames);
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user