Commit Graph

8 Commits

Author SHA1 Message Date
Jose Olarte III
eb44e7b51e Chore: convert "unnamed" into constant
- "Unnamed/Unknown" simplified into just "Unnamed"
- Phrase variations have their own constants
2025-08-18 20:33:19 +08:00
Jose Olarte III
ec1a725832 Refactor: improve dialog logic and entity handling
- Split openDialog into separate methods to improve code readability and maintainability through method extraction
- Add receiver name fallback in GiftedDialog when receiver exists but has no name
- Enhance shouldShowYouEntity to prevent selecting "You" as both giver and recipient
- Improve labeling of "(No name)" entities while retaining original entity object properties
- Apply special styling to "Unnamed" and "(No Name)" entities
2025-08-12 18:34:47 +08:00
Matthew Raymer
e0b2f35e5e Refactor EntitySummaryButton to use function props instead of events
Replace @Emit decorator with function prop pattern for better parent control over edit behavior. EntitySummaryButton now accepts onEditRequested function prop that parent components can use to handle edit requests with custom validation logic. Updated GiftDetailsStep to use new function prop interface with proper parameter handling.
2025-07-18 07:34:04 +00:00
Matthew Raymer
7bf8cb855e feat: migrate GiftDetailsStep.vue with template streamlining
- Extract long CSS classes to computed properties
- Fix header comment formatting to JSDoc format
- Enhance component documentation
- No database/notification migration needed (pure UI component)
- Human testing completed

Security: No risks (cosmetic changes only)
Lint:  Passed
Migration: Phase 4 only - Template streamlining
2025-07-09 09:06:16 +00:00
Matthew Raymer
c49c137cae EntitySummaryButton.vue: Phase 4 template streamlining migration
- Extract long CSS class to computed property containerClasses
- Fix header comment formatting to proper JSDoc format
- Enhance component documentation for template streamlining
- Update class binding from static to dynamic for better maintainability
- Migration completed in 3 minutes (within estimate)
- No database or SQL operations needed (pure UI component)
- Lint validation passed with no errors

Security audit: No security risks (cosmetic template changes only)
Migration status: 67% complete (62/92 components migrated)
2025-07-09 08:57:24 +00:00
Jose Olarte III
e1db9083c2 Fix: handle special "You" entity 2025-07-07 17:16:59 +08:00
Matthew Raymer
3585290872 Fix TypeScript any type warnings in Vue components
Replace generic 'any' types with specific type definitions:
- EntitySummaryButton: Define edit-requested event payload type
- GiftDetailsStep: Add proper types for edit-entity and submit events
- HomeView: Use GiftedDialog type for customDialog ref

Resolves 7 TypeScript linting warnings, improves type safety
2025-07-05 03:08:12 +00:00
Matthew Raymer
56286e1fea Fix TypeScript any types and remove deprecated Dexie code
- Replace Record<string, any> with Record<string, string> for query params
- Fix error handling from catch(err: any) to catch(err: unknown)
- Add EntityData interface for proper entity typing
- Update EntitySelectionEvent interface with union types
- Remove USE_DEXIE_DB conditionals and unused import
- Clean up database service calls removing Dexie fallbacks

Resolves 9 TypeScript any type warnings, improves type safety across
entity selection components, and removes deprecated database migration code.
2025-07-04 08:06:08 +00:00