Matthew Raymer
d355d51ea3
feat: centralize identity creation with router navigation guard
...
Migrate automatic identity creation from scattered view components to centralized
router navigation guard for consistent behavior across all entry points.
**Key Changes:**
- Add global beforeEach navigation guard in router/index.ts
- Remove automatic identity creation from HomeView, ContactsView, InviteOneAcceptView,
and OnboardMeetingMembersView
- Keep minimal fallback logic in deep link scenarios with logging
- Exclude manual identity creation routes (/start, /new-identifier, /import-account)
**Benefits:**
- Eliminates code duplication and race conditions
- Ensures consistent identity creation regardless of entry point
- Centralizes error handling with fallback to manual creation
- Improves maintainability with single point of change
**Files Modified:**
- src/router/index.ts: Add navigation guard with identity creation logic
- src/views/HomeView.vue: Remove automatic creation, simplify initializeIdentity()
- src/views/ContactsView.vue: Add fallback with logging
- src/views/InviteOneAcceptView.vue: Add fallback with logging
- src/views/OnboardMeetingMembersView.vue: Add fallback with logging
**Testing:**
- Verified first-time user navigation creates identity automatically
- Confirmed existing users bypass creation logic
- Validated manual creation routes remain unaffected
- Tested deep link scenarios with fallback logic
**Documentation:**
- Created docs/identity-creation-migration.md with comprehensive details
- Includes migration rationale, implementation details, testing scenarios
- Documents security considerations and rollback plan
Resolves inconsistent identity creation behavior across different app entry points.
2025-07-17 04:03:05 +00:00
Matthew Raymer
9f86ab4f80
Complete MembersList.vue notification migration with complex modals (3 minutes)
...
Notification Migration: Use TIMEOUTS.MODAL instead of -1 for complex confirm dialogs
Complex Modal Pattern: Retain raw $notify calls for advanced modal features (custom titles, button text, multiple callbacks)
Constants Integration: All notification text uses centralized NOTIFY_ADD_CONTACT_FIRST and NOTIFY_CONTINUE_WITHOUT_ADDING constants
Time: 3 minutes | Complexity: Simple | Issues: None
Testing: Manual required | Validation: Complex modals documented as legitimate raw $notify use case
Note: Validation script flags as mixed pattern but component follows documented complex modal pattern
2025-07-07 10:17:44 +00:00
Matthew Raymer
f9a1be81b4
Extract literal strings from complex modals to notification constants
...
Replace hardcoded text in raw $notify calls with centralized constants:
- MembersList.vue: 2 complex modals (contact admission workflow)
- ContactsView.vue: 2 complex modals (registration, onboarding meeting)
- ProjectViewView.vue: 1 complex modal (claim confirmation)
Preserves advanced modal features (promptToStopAsking, custom buttons,
nested workflows) while standardizing text through constants for
maintainability and future localization support.
2025-07-07 07:22:06 +00:00
Matthew Raymer
ba15b500c4
Replace hardcoded notification strings with standardized constants
...
- Replace literal strings with notification constants in ContactsView.vue:
* "Got an error sending the invite." → NOTIFY_INVITE_ERROR.message
* "Could not set visibility on the server." → NOTIFY_VISIBILITY_ERROR.message
* "Unconfirmed Hours" → NOTIFY_UNCONFIRMED_HOURS.title
- Remove unused NOTIFY_REGISTER_PROCESSING import
- Remove unused NOTIFICATION_TIMEOUTS constant in ShareMyContactInfoView.vue
- Fix unused parameter warnings in danger() and warning() methods
- Resolve all notification-related linting errors
2025-07-07 07:02:33 +00:00
Matthew Raymer
a5784cdfc1
Complete notification migration across 13 components and views
...
- Replace raw $notify calls with notification helper system
- Add createNotifyHelpers and TIMEOUTS constants integration
- Migrate AccountViewView, ClaimAddRawView, ContactGiftingView, ContactImportView, ContactsView, NewActivityView, ProjectViewView, RecentOffersToUserProjectsView, RecentOffersToUserView, ShareMyContactInfoView
- Update MembersList, TopMessage, UserNameDialog components
- Add notification constants for standardized messaging
- Enhance validation script to eliminate false positives
- Achieve 86% notification migration completion rate
2025-07-07 06:53:30 +00:00
Matthew Raymer
2e2d858cc9
Fix migration dates, add multi-platform testing infrastructure, and organize docs
...
Migration Date Corrections:
- Update all migration TODO comments to use correct date: 2025-07-06
- Add proper TypeScript type declarations for $route and $router in DeepLinkErrorView
- Fix template property references to use $route instead of route
Multi-Platform Testing Infrastructure:
- Add comprehensive multi-platform testing requirements for migrations
- Update component migration template with platform testing requirements
- Establish sign-off requirements for web, desktop, and mobile platforms
- Document expected outcomes and validation procedures
Migration Testing Organization:
- Create docs/migration-testing/ folder for testing documentation
- Move TESTING_CONTACTIMPORT.md from project root to migration-testing/
- Relocate all migration-checklist-*.md files to migration-testing/
- Add comprehensive README.md with organization guidelines
- Update file references in components and TODOs
- Establish naming conventions and quality standards
Files added:
- docs/migration-testing/README.md
- docs/migration-testing/TESTING_CONTACTIMPORT.md
- docs/migration-testing/migration-checklist-ContactImportView.md
- docs/migration-testing/migration-checklist-MembersList.md
Files modified:
- src/views/ContactImportView.vue (date correction)
- src/components/MembersList.vue (date correction, reference path update)
- src/views/DeepLinkErrorView.vue (date correction, Vue router types)
- docs/migration-templates/component-migration.md (multi-platform requirements)
Files moved:
- TESTING_CONTACTIMPORT.md → docs/migration-testing/
- docs/migration-checklist-*.md → docs/migration-testing/
This establishes comprehensive testing infrastructure for all future migrations
with proper organization and multi-platform validation requirements.
2025-07-06 06:05:18 +00:00
Matthew Raymer
34563c2240
Add comprehensive migration documentation and testing infrastructure
...
- Add TODO annotation to MembersList.vue requiring human testing validation
- Create migration templates for systematic component migration
- Add best practices guide for PlatformServiceMixin usage
- Create ESLint rules template for pattern enforcement
- Add validation script to track migration progress
- Document Phase 1 completion summary with current state
Migration Infrastructure:
- Component migration checklist template
- Automated validation script (validate-migration.sh)
- Best practices documentation
- ESLint rules for preventing regression
Status: MembersList.vue migration complete but requires human testing
Next: Select next component for migration when ready to continue
2025-07-06 05:43:15 +00:00
Matthew Raymer
08a9fa9946
Migrate MembersList.vue to PlatformServiceMixin logging patterns
...
- Remove legacy logConsoleAndDb import from db/index
- Replace 3 logging calls with this.$logAndConsole() mixin method
- Add CSS linting suppressions for Tailwind @apply directives
- Create migration checklist documentation
Note: Untested due to meeting component accessibility limitations
Passes lint checks and TypeScript compilation
2025-07-06 05:32:50 +00:00
Matthew Raymer
ec3c603894
refactor: Replace databaseUtil import with PlatformServiceMixin in MembersList
...
- Remove direct databaseUtil dependency from MembersList.vue
- Use $accountSettings() method from PlatformServiceMixin instead
- Improves code consistency and enables caching benefits
- Maintains identical functionality with enhanced error handling
2025-07-05 06:04:29 +00:00
Matthew Raymer
91a1618f40
Fix JavaScript runtime errors for undefined name property access
...
- Add null checks to prevent "Cannot read properties of undefined (reading 'name')" errors
- Fix ProjectCard, MembersList, ProjectsView, DiscoverView, ProjectViewView components
- Add null validation in DIDView.claimDescription() and ClaimReportCertificateView.drawCanvas()
- Add missing databaseUtil import in MembersList component
- Use meaningful fallback text for undefined names ("Unnamed Project", "Unnamed Member")
- Resolves template rendering crashes when entities lack name properties
2025-07-05 05:38:20 +00:00
Matthew Raymer
d359263704
feat: enhance GenericVerifiableCredential interface with explicit optional properties
...
- Add name, description, and agent as optional properties to GenericVerifiableCredential
- Improve type safety and IntelliSense for common claim properties
- Maintain backward compatibility with existing code
- Reduce need for type assertions when accessing claim properties
2025-06-23 10:30:08 +00:00
Matthew Raymer
ebc241eba0
WIP: restore database migration system and improve error handling
...
- Restore runMigrations functionality for database schema migrations
- Remove indexedDBMigrationService.ts (was for IndexedDB to SQLite migration)
- Recreate migrationService.ts and db-sql/migration.ts for schema management
- Add proper TypeScript error handling with type guards in AccountViewView
- Fix CreateAndSubmitClaimResult property access in QuickActionBvcBeginView
- Remove LeafletMouseEvent from Vue components array (it's a type, not component)
- Add null check for UserNameDialog callback to prevent undefined assignment
- Implement extractErrorMessage helper function for consistent error handling
- Update router to remove database-migration route
The migration system now properly handles database schema evolution
across app versions, while the IndexedDB to SQLite migration service
has been removed as it was specific to that one-time migration.
2025-06-23 08:25:10 +00:00
987f9217de
Merge branch 'sql-absurd-sql-back'
2025-06-07 17:18:10 -06:00
8092d1c576
convert all remaining DB writes & reads to SQL (with successful registration & claim)
2025-05-27 21:07:24 -06:00
3f691ef880
add SQL DB access to everywhere we are using the DB, up to the "C" files
2025-05-27 01:27:04 -06:00
7517ac583d
add projectLink to onboarding meeting, plus enhancements to setup usability
2025-05-13 19:36:23 -06:00
Matthew Raymer
c9536dd643
refactor: Replace console logging with logger utility
...
- Add logger import across multiple view components
- Replace console.error/warn/log with logger methods
- Update error handling to use structured logging
- Improve type safety for error objects
- Add crypto-browserify polyfill for browser environment
The changes improve logging by:
1. Using consistent logging interface
2. Adding structured error logging
3. Improving error type safety
4. Centralizing logging configuration
5. Fixing browser compatibility issues
Affected files:
- Multiple view components
- vite.config.ts
- Build configuration
2025-03-11 09:35:55 +00:00
Matthew Raymer
3dbb836ae5
style: reorder v-model and v-bind directives
...
Changes:
- Move v-model directives before other attributes
- Move v-bind directives before event handlers
- Reorder attributes for better readability
- Fix template attribute ordering across components
- Improve eslint rules
- add default vite config for testing (handles nostr error too)
This follows Vue.js style guide recommendations for attribute
ordering and improves template consistency.
2025-02-26 09:27:04 +00:00
Matthew Raymer
79ef59c5a9
refactor: migrate interfaces to dedicated directory
...
Reorganizes TypeScript interfaces into a modular structure:
- Create dedicated interfaces directory with specialized files
- Split interfaces by domain (claims, common, limits, records, user)
- Update imports in endorserServer.ts to use new interface locations
- Replace 'any' types with 'unknown' for better type safety
- Add proper type imports and exports
This improves code organization and maintainability by:
- Centralizing interface definitions
- Reducing file size of endorserServer.ts
- Making interface relationships more explicit
- Improving type safety with stricter types
2025-02-24 11:21:08 +00:00
Matthew Raymer
61e32dd560
Merge branch 'master' into split_build_process
...
fix: image server references and test configurations
- Update image server references to use test server by default for local dev
- Fix registration status checks in tests
- Remove verbose console logging
- Update environment configurations for consistent image server usage
- Fix alert handling in contact registration tests
- Clean up component lifecycle logging
- Add clarifying comments about shared image server usage
- Update playwright test configurations for better reliability
This commit ensures consistent image server behavior across environments
and improves test reliability by properly handling registration status
checks and alerts.
2025-02-17 06:36:40 +00:00
09b43226f9
for meeting invitees, create their ID and allow them to set a name
2025-02-11 08:15:01 -07:00
c9c60582cc
add 'isRegistered' flag to encrypted contents in an onboarding meeting
2025-02-06 19:58:09 -07:00
1a38baf59d
show a better message when admission to an onboarding meeting succeeds but registration fails
2025-02-06 19:35:33 -07:00
Matthew Raymer
15783cdbe6
(chore): cleaning up formatting and relative references
2025-02-06 14:08:54 +00:00
5b29d97173
prompt organizer about adding a contact if not in list, and other sanity checks
2025-02-05 21:03:57 -07:00
bb5913fef4
make member view available to onboard meeting organizer and reorganize buttons
2025-02-05 20:07:25 -07:00
29a81c48c8
fix problem with you-are-missing message and refactor other messages in onboard meeting
2025-02-05 19:03:54 -07:00
03bfd364ce
fix linting
2025-02-03 20:37:46 -07:00
1b869a23b0
now add registration when the organizer admits them
2025-02-03 20:31:22 -07:00
074c12da63
add an icon for each attendee to add them to their contact list
2025-02-03 19:55:41 -07:00
763398ff1b
organizer can toggle admission to the meeting
2025-02-03 19:00:11 -07:00
6a070a1715
fix linting (and change a little wording in onboarding page)
2025-02-03 16:36:13 -07:00
b3daa27d20
split out group-meeting member list into a separate component, and fix some edit/create mode titles
2025-02-03 14:30:49 -07:00
