forked from jsnbuchanan/crowd-funder-for-time-pwa
feat(db): improve settings retrieval resilience and logging
Enhance retrieveSettingsForActiveAccount with better error handling and logging while maintaining core functionality. Changes focus on making the system more debuggable and resilient without overcomplicating the logic. Key improvements: - Add structured error handling with specific try-catch blocks - Implement detailed logging with [databaseUtil] prefix for easy filtering - Add graceful fallbacks for searchBoxes parsing and missing settings - Improve error recovery paths with safe defaults - Maintain existing security model and data integrity Security: - No sensitive data in logs - Safe JSON parsing with fallbacks - Proper error boundaries - Consistent state management - Clear fallback paths Testing: - Verify settings retrieval works with/without active DID - Check error handling for invalid searchBoxes - Confirm logging provides clear debugging context - Validate fallback to default settings works
This commit is contained in:
@@ -115,6 +115,7 @@ import { MASTER_SETTINGS_KEY } from "../db/tables/settings";
|
||||
import * as databaseUtil from "../db/databaseUtil";
|
||||
import { retrieveAllAccountsMetadata } from "../libs/util";
|
||||
import { logger } from "../utils/logger";
|
||||
import { PlatformServiceFactory } from "@/services/PlatformServiceFactory";
|
||||
|
||||
@Component({ components: { QuickNav } })
|
||||
export default class IdentitySwitcherView extends Vue {
|
||||
@@ -138,8 +139,10 @@ export default class IdentitySwitcherView extends Vue {
|
||||
this.apiServerInput = settings.apiServer || "";
|
||||
|
||||
const accounts = await retrieveAllAccountsMetadata();
|
||||
console.log("[IdentitySwitcherView] accounts: ", JSON.stringify(accounts, null, 2));
|
||||
for (let n = 0; n < accounts.length; n++) {
|
||||
const acct = accounts[n];
|
||||
console.log("[IdentitySwitcherView] acct: ", JSON.stringify(acct, null, 2));
|
||||
this.otherIdentities.push({
|
||||
id: (acct.id ?? 0).toString(),
|
||||
did: acct.did,
|
||||
@@ -149,6 +152,7 @@ export default class IdentitySwitcherView extends Vue {
|
||||
}
|
||||
}
|
||||
} catch (err) {
|
||||
console.log("[IdentitySwitcherView] error: ", JSON.stringify(err, null, 2));
|
||||
this.$notify(
|
||||
{
|
||||
group: "alert",
|
||||
@@ -160,6 +164,7 @@ export default class IdentitySwitcherView extends Vue {
|
||||
);
|
||||
logger.error("Telling user to clear cache at page create because:", err);
|
||||
}
|
||||
console.log("[IdentitySwitcherView] end");
|
||||
}
|
||||
|
||||
async switchAccount(did?: string) {
|
||||
@@ -167,10 +172,18 @@ export default class IdentitySwitcherView extends Vue {
|
||||
if (did === "0") {
|
||||
did = undefined;
|
||||
}
|
||||
await db.open();
|
||||
await db.settings.update(MASTER_SETTINGS_KEY, {
|
||||
activeDid: did,
|
||||
});
|
||||
if (USE_DEXIE_DB) {
|
||||
await db.open();
|
||||
await db.settings.update(MASTER_SETTINGS_KEY, {
|
||||
activeDid: did ?? "",
|
||||
});
|
||||
} else {
|
||||
const platformService = PlatformServiceFactory.getInstance();
|
||||
await platformService.dbExec(
|
||||
`UPDATE settings SET activeDid = ? WHERE id = ?`,
|
||||
[did ?? "", MASTER_SETTINGS_KEY],
|
||||
);
|
||||
}
|
||||
this.$router.push({ name: "account" });
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user