forked from jsnbuchanan/crowd-funder-for-time-pwa
fix(types): resolve TypeScript any type violations
- Replace any types in ProfileService with AxiosErrorResponse interface - Add type-safe error URL extraction method - Fix Leaflet icon type assertion using Record<string, unknown> - Enhance AxiosErrorResponse interface with missing properties - Maintain existing functionality while improving type safety Closes typing violations in ProfileService.ts and AccountViewView.vue
This commit is contained in:
@@ -60,9 +60,13 @@ export interface AxiosErrorResponse {
|
|||||||
[key: string]: unknown;
|
[key: string]: unknown;
|
||||||
};
|
};
|
||||||
status?: number;
|
status?: number;
|
||||||
|
statusText?: string;
|
||||||
config?: unknown;
|
config?: unknown;
|
||||||
};
|
};
|
||||||
config?: unknown;
|
config?: {
|
||||||
|
url?: string;
|
||||||
|
[key: string]: unknown;
|
||||||
|
};
|
||||||
[key: string]: unknown;
|
[key: string]: unknown;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -10,6 +10,7 @@ import { getHeaders, errorStringForLog } from "@/libs/endorserServer";
|
|||||||
import { handleApiError } from "./api";
|
import { handleApiError } from "./api";
|
||||||
import { logger } from "@/utils/logger";
|
import { logger } from "@/utils/logger";
|
||||||
import { ACCOUNT_VIEW_CONSTANTS } from "@/constants/accountView";
|
import { ACCOUNT_VIEW_CONSTANTS } from "@/constants/accountView";
|
||||||
|
import { AxiosErrorResponse } from "@/interfaces/common";
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Profile data interface
|
* Profile data interface
|
||||||
@@ -124,34 +125,27 @@ export class ProfileService {
|
|||||||
async deleteProfile(activeDid: string): Promise<boolean> {
|
async deleteProfile(activeDid: string): Promise<boolean> {
|
||||||
try {
|
try {
|
||||||
const headers = await getHeaders(activeDid);
|
const headers = await getHeaders(activeDid);
|
||||||
logger.debug("Attempting to delete profile for DID:", activeDid);
|
const response = await this.axios.delete(
|
||||||
logger.debug("Using partner API server:", this.partnerApiServer);
|
`${this.partnerApiServer}/api/partner/userProfile`,
|
||||||
logger.debug("Request headers:", headers);
|
{ headers },
|
||||||
|
);
|
||||||
|
|
||||||
const url = `${this.partnerApiServer}/api/partner/userProfile`;
|
if (response.status === 204 || response.status === 200) {
|
||||||
logger.debug("DELETE request URL:", url);
|
logger.info("Profile deleted successfully");
|
||||||
|
|
||||||
const response = await this.axios.delete(url, { headers });
|
|
||||||
|
|
||||||
if (response.status === 200 || response.status === 204) {
|
|
||||||
logger.debug("Profile deleted successfully");
|
|
||||||
return true;
|
return true;
|
||||||
} else {
|
} else {
|
||||||
logger.error("Unexpected response status when deleting profile:", {
|
throw new Error(
|
||||||
status: response.status,
|
`Profile not deleted - HTTP ${response.status}: ${response.statusText}`,
|
||||||
statusText: response.statusText,
|
);
|
||||||
data: response.data
|
|
||||||
});
|
|
||||||
throw new Error(`Profile not deleted - HTTP ${response.status}: ${response.statusText}`);
|
|
||||||
}
|
}
|
||||||
} catch (error) {
|
} catch (error) {
|
||||||
if (this.isApiError(error) && error.response) {
|
if (this.isApiError(error) && error.response) {
|
||||||
const response = error.response as any; // Type assertion for error response
|
const response = error.response;
|
||||||
logger.error("API error deleting profile:", {
|
logger.error("API error deleting profile:", {
|
||||||
status: response.status,
|
status: response.status,
|
||||||
statusText: response.statusText,
|
statusText: response.statusText,
|
||||||
data: response.data,
|
data: response.data,
|
||||||
url: (error as any).config?.url
|
url: this.getErrorUrl(error),
|
||||||
});
|
});
|
||||||
|
|
||||||
// Handle specific HTTP status codes
|
// Handle specific HTTP status codes
|
||||||
@@ -163,7 +157,9 @@ export class ProfileService {
|
|||||||
return true; // Consider this a success if profile doesn't exist
|
return true; // Consider this a success if profile doesn't exist
|
||||||
} else if (response.status === 400) {
|
} else if (response.status === 400) {
|
||||||
logger.error("Bad request when deleting profile:", response.data);
|
logger.error("Bad request when deleting profile:", response.data);
|
||||||
throw new Error(`Profile deletion failed: ${response.data?.message || 'Bad request'}`);
|
throw new Error(
|
||||||
|
`Profile deletion failed: ${response.data?.error?.message || "Bad request"}`,
|
||||||
|
);
|
||||||
} else if (response.status === 401) {
|
} else if (response.status === 401) {
|
||||||
logger.error("Unauthorized to delete profile");
|
logger.error("Unauthorized to delete profile");
|
||||||
throw new Error("You are not authorized to delete this profile");
|
throw new Error("You are not authorized to delete this profile");
|
||||||
@@ -242,13 +238,22 @@ export class ProfileService {
|
|||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Type guard for API errors
|
* Type guard for API errors with proper typing
|
||||||
*/
|
*/
|
||||||
private isApiError(
|
private isApiError(error: unknown): error is AxiosErrorResponse {
|
||||||
error: unknown,
|
|
||||||
): error is { response?: { status?: number } } {
|
|
||||||
return typeof error === "object" && error !== null && "response" in error;
|
return typeof error === "object" && error !== null && "response" in error;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Extract error URL safely from error object
|
||||||
|
*/
|
||||||
|
private getErrorUrl(error: unknown): string | undefined {
|
||||||
|
if (this.isApiError(error) && error.config) {
|
||||||
|
const config = error.config as { url?: string };
|
||||||
|
return config.url;
|
||||||
|
}
|
||||||
|
return undefined;
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
|||||||
@@ -182,7 +182,9 @@
|
|||||||
@change="onLocationCheckboxChange"
|
@change="onLocationCheckboxChange"
|
||||||
/>
|
/>
|
||||||
<label for="includeUserProfileLocation">Include Location</label>
|
<label for="includeUserProfileLocation">Include Location</label>
|
||||||
<span class="text-xs text-slate-400 ml-2">(Debug: {{ isMapReady ? 'Map Ready' : 'Map Loading' }})</span>
|
<span class="text-xs text-slate-400 ml-2"
|
||||||
|
>(Debug: {{ isMapReady ? "Map Ready" : "Map Loading" }})</span
|
||||||
|
>
|
||||||
</div>
|
</div>
|
||||||
<div v-if="includeUserProfileLocation" class="mb-4 aspect-video">
|
<div v-if="includeUserProfileLocation" class="mb-4 aspect-video">
|
||||||
<p class="text-sm mb-2 text-slate-500">
|
<p class="text-sm mb-2 text-slate-500">
|
||||||
@@ -922,11 +924,17 @@ export default class AccountViewView extends Vue {
|
|||||||
// Fix Leaflet icon issues in modern bundlers
|
// Fix Leaflet icon issues in modern bundlers
|
||||||
// This prevents the "Cannot read properties of undefined (reading 'Default')" error
|
// This prevents the "Cannot read properties of undefined (reading 'Default')" error
|
||||||
if (L.Icon.Default) {
|
if (L.Icon.Default) {
|
||||||
delete (L.Icon.Default.prototype as any)._getIconUrl;
|
// Type-safe way to handle Leaflet icon prototype
|
||||||
|
const iconDefault = L.Icon.Default.prototype as Record<string, unknown>;
|
||||||
|
if ("_getIconUrl" in iconDefault) {
|
||||||
|
delete iconDefault._getIconUrl;
|
||||||
|
}
|
||||||
L.Icon.Default.mergeOptions({
|
L.Icon.Default.mergeOptions({
|
||||||
iconRetinaUrl: 'https://unpkg.com/leaflet@1.7.1/dist/images/marker-icon-2x.png',
|
iconRetinaUrl:
|
||||||
iconUrl: 'https://unpkg.com/leaflet@1.7.1/dist/images/marker-icon.png',
|
"https://unpkg.com/leaflet@1.7.1/dist/images/marker-icon-2x.png",
|
||||||
shadowUrl: 'https://unpkg.com/leaflet@1.7.1/dist/images/marker-shadow.png',
|
iconUrl: "https://unpkg.com/leaflet@1.7.1/dist/images/marker-icon.png",
|
||||||
|
shadowUrl:
|
||||||
|
"https://unpkg.com/leaflet@1.7.1/dist/images/marker-shadow.png",
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -1543,12 +1551,18 @@ export default class AccountViewView extends Vue {
|
|||||||
try {
|
try {
|
||||||
logger.debug("Map ready event fired, map object:", map);
|
logger.debug("Map ready event fired, map object:", map);
|
||||||
// doing this here instead of on the l-map element avoids a recentering after a drag then zoom at startup
|
// doing this here instead of on the l-map element avoids a recentering after a drag then zoom at startup
|
||||||
const zoom = this.userProfileLatitude && this.userProfileLongitude ? 12 : 2;
|
const zoom =
|
||||||
|
this.userProfileLatitude && this.userProfileLongitude ? 12 : 2;
|
||||||
const lat = this.userProfileLatitude || 0;
|
const lat = this.userProfileLatitude || 0;
|
||||||
const lng = this.userProfileLongitude || 0;
|
const lng = this.userProfileLongitude || 0;
|
||||||
map.setView([lat, lng], zoom);
|
map.setView([lat, lng], zoom);
|
||||||
this.isMapReady = true;
|
this.isMapReady = true;
|
||||||
logger.debug("Map ready state set to true, coordinates:", [lat, lng], "zoom:", zoom);
|
logger.debug(
|
||||||
|
"Map ready state set to true, coordinates:",
|
||||||
|
[lat, lng],
|
||||||
|
"zoom:",
|
||||||
|
zoom,
|
||||||
|
);
|
||||||
} catch (error) {
|
} catch (error) {
|
||||||
logger.error("Error in onMapReady:", error);
|
logger.error("Error in onMapReady:", error);
|
||||||
this.isMapReady = true; // Set to true even on error to prevent infinite loading
|
this.isMapReady = true; // Set to true even on error to prevent infinite loading
|
||||||
@@ -1710,7 +1724,10 @@ export default class AccountViewView extends Vue {
|
|||||||
|
|
||||||
onLocationCheckboxChange(): void {
|
onLocationCheckboxChange(): void {
|
||||||
try {
|
try {
|
||||||
logger.debug("Location checkbox changed, new value:", this.includeUserProfileLocation);
|
logger.debug(
|
||||||
|
"Location checkbox changed, new value:",
|
||||||
|
this.includeUserProfileLocation,
|
||||||
|
);
|
||||||
if (!this.includeUserProfileLocation) {
|
if (!this.includeUserProfileLocation) {
|
||||||
// Location checkbox was unchecked, clean up map state
|
// Location checkbox was unchecked, clean up map state
|
||||||
this.isMapReady = false;
|
this.isMapReady = false;
|
||||||
|
|||||||
Reference in New Issue
Block a user