Replace console statements with structured logger calls

- Replace 30 console.log/error/warn statements with appropriate logger calls
- Add logger imports where missing (PlatformServiceFactory, PlatformServiceMixin)
- Maintain eslint-disable comments for critical error logging in worker context
- Improve error handling consistency across platform services
- Clean up commented-out logger statements in WebPlatformService

Files affected:
- src/db/databaseUtil.ts: 4 console statements → logger calls
- src/main.electron.ts: 3 console statements → logger calls
- src/registerSQLWorker.js: 9 console statements → logger calls
- src/services/PlatformServiceFactory.ts: 1 console statement → logger call
- src/services/platforms/WebPlatformService.ts: 8 console statements → logger calls
- src/utils/PlatformServiceMixin.ts: 5 console statements → logger calls

Reduces ESLint warnings from 111 to 82 (eliminates all no-console warnings)
This commit is contained in:
Matthew Raymer
2025-07-03 08:32:41 +00:00
parent b377667207
commit 3d7d663f64
6 changed files with 37 additions and 79 deletions

View File

@@ -14,7 +14,7 @@
* @since 2025-07-02
*/
// import { logger } from "./utils/logger"; // DISABLED FOR DEBUGGING
import { logger } from "./utils/logger";
/**
* Worker state management
@@ -65,14 +65,11 @@ async function initializeDatabase() {
initializationPromise = (async () => {
try {
// logger.log("[SQLWorker] Starting database initialization..."); // DISABLED
const dbService = await getDatabaseService();
await dbService.initialize();
isInitialized = true;
// logger.log("[SQLWorker] Database initialization completed successfully"); // DISABLED
} catch (error) {
// logger.error("[SQLWorker] Database initialization failed:", error); // DISABLED
console.error("[SQLWorker] Database initialization failed:", error); // Keep only critical errors
logger.error("[SQLWorker] Database initialization failed:", error);
isInitialized = false;
initializationPromise = null;
throw error;
@@ -88,16 +85,13 @@ async function initializeDatabase() {
async function handleQuery(id, sql, params = []) {
try {
await initializeDatabase();
// logger.log(`[SQLWorker] Executing query: ${sql}`, params); // DISABLED
const dbService = await getDatabaseService();
const result = await dbService.query(sql, params);
// logger.log(`[SQLWorker] Query completed successfully`); // DISABLED
sendResponse(id, "success", { result });
} catch (error) {
// logger.error(`[SQLWorker] Query failed:`, error); // DISABLED
console.error(`[SQLWorker] Query failed:`, error); // Keep only critical errors
logger.error(`[SQLWorker] Query failed:`, error);
sendResponse(id, "error", null, {
message: error.message,
stack: error.stack,
@@ -111,16 +105,13 @@ async function handleQuery(id, sql, params = []) {
async function handleExec(id, sql, params = []) {
try {
await initializeDatabase();
// logger.log(`[SQLWorker] Executing statement: ${sql}`, params); // DISABLED
const dbService = await getDatabaseService();
const result = await dbService.run(sql, params);
// logger.log(`[SQLWorker] Statement executed successfully:`, result); // DISABLED
sendResponse(id, "success", result);
} catch (error) {
// logger.error(`[SQLWorker] Statement execution failed:`, error); // DISABLED
console.error(`[SQLWorker] Statement execution failed:`, error); // Keep only critical errors
logger.error(`[SQLWorker] Statement execution failed:`, error);
sendResponse(id, "error", null, {
message: error.message,
stack: error.stack,
@@ -134,17 +125,14 @@ async function handleExec(id, sql, params = []) {
async function handleGetOneRow(id, sql, params = []) {
try {
await initializeDatabase();
// logger.log(`[SQLWorker] Executing getOneRow: ${sql}`, params); // DISABLED
const dbService = await getDatabaseService();
const result = await dbService.query(sql, params);
const oneRow = result?.[0]?.values?.[0];
// logger.log(`[SQLWorker] GetOneRow completed successfully`); // DISABLED
sendResponse(id, "success", oneRow);
} catch (error) {
// logger.error(`[SQLWorker] GetOneRow failed:`, error); // DISABLED
console.error(`[SQLWorker] GetOneRow failed:`, error); // Keep only critical errors
logger.error(`[SQLWorker] GetOneRow failed:`, error);
sendResponse(id, "error", null, {
message: error.message,
stack: error.stack,
@@ -158,11 +146,9 @@ async function handleGetOneRow(id, sql, params = []) {
async function handleInit(id) {
try {
await initializeDatabase();
// logger.log("[SQLWorker] Initialization request completed"); // DISABLED
sendResponse(id, "init-complete");
} catch (error) {
// logger.error("[SQLWorker] Initialization request failed:", error); // DISABLED
console.error("[SQLWorker] Initialization request failed:", error); // Keep only critical errors
logger.error("[SQLWorker] Initialization request failed:", error);
sendResponse(id, "error", null, {
message: error.message,
stack: error.stack,
@@ -174,7 +160,6 @@ async function handleInit(id) {
* Handle ping request for health check
*/
function handlePing(id) {
// logger.log("[SQLWorker] Ping received"); // DISABLED
sendResponse(id, "pong");
}
@@ -185,13 +170,10 @@ onmessage = function (event) {
const { id, type, sql, params } = event.data;
if (!id || !type) {
// logger.error("[SQLWorker] Invalid message received:", event.data); // DISABLED
console.error("[SQLWorker] Invalid message received:", event.data);
logger.error("[SQLWorker] Invalid message received:", event.data);
return;
}
// logger.log(`[SQLWorker] Received message: ${type} (${id})`); // DISABLED
switch (type) {
case "query":
handleQuery(id, sql, params);
@@ -214,8 +196,7 @@ onmessage = function (event) {
break;
default:
// logger.error(`[SQLWorker] Unknown message type: ${type}`); // DISABLED
console.error(`[SQLWorker] Unknown message type: ${type}`);
logger.error(`[SQLWorker] Unknown message type: ${type}`);
sendResponse(id, "error", null, {
message: `Unknown message type: ${type}`,
});
@@ -227,13 +208,11 @@ onmessage = function (event) {
* Handle worker errors
*/
onerror = function (error) {
// logger.error("[SQLWorker] Worker error:", error); // DISABLED
console.error("[SQLWorker] Worker error:", error);
logger.error("[SQLWorker] Worker error:", error);
};
/**
* Auto-initialize on worker startup (removed to prevent circular dependency)
* Initialization now happens on first database operation
*/
// logger.log("[SQLWorker] Worker loaded, ready to receive messages"); // DISABLED
console.log("[SQLWorker] Worker loaded, ready to receive messages");
logger.log("[SQLWorker] Worker loaded, ready to receive messages");