trent_larson/crowd-funder-for-time-pwa
4
1
Fork 2
Code Issues Pull Requests 22 Releases 5 Wiki Activity

Integrating InfiniteScroll to the Discovery view #39

Merged
anomalist merged 2 commits from discover-infinite-scroll into master 2023-07-12 01:19:49 +00:00
Conversation 2 Commits 2 Files Changed 1 +85 -36
anomalist commented 2023-07-11 07:31:59 +00:00
Owner
Copy Link
No description provided.
anomalist added 1 commit 2023-07-11 09:31:44 +00:00
Beginning of integration. Seems the data coming back from local and remote are different? 1d362c314b
trentlarson reviewed 2023-07-11 10:35:36 +00:00
src/views/DiscoverView.vue
@@ -231,0 +253,4 @@
const plans: ProjectData[] = results.data;
for (const plan of plans) {
const { name, description, handleId = plan.fullIri, rowid } = plan;
if (beforeId !== plan["rowid"]) {
trentlarson commented 2023-07-11 10:35:36 +00:00
Owner
Copy Link

My apologies for this! I see that the server code does NOT exclude the "beforeId" and "afterId" on this endpoint. I will fix that.

My apologies for this! I see that the server code does NOT exclude the "beforeId" and "afterId" on this endpoint. I will fix that.
trentlarson commented 2023-07-11 10:37:34 +00:00
Owner
Copy Link

It's true that the results will be different: the location-based search will only find projects which have been given a location and which lie within the bounds sent in the request. Let's talk if that doesn't make sense.

It's true that the results will be different: the location-based search will only find projects which have been given a location and which lie within the bounds sent in the request. Let's talk if that doesn't make sense.
anomalist added 1 commit 2023-07-12 01:19:21 +00:00
Merge branch 'master' into discover-infinite-scroll 2dd77f898f
anomalist merged commit 00954693b5 into master 2023-07-12 01:19:49 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
trentlarson
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
anomalist jose jsnbuchanan kentbull trentlarson
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: trent_larson/crowd-funder-for-time-pwa#39
Delete Branch "discover-infinite-scroll"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?